Question about deleting Node by value function.

[Jas Singh]

So I made this function to delete node by value. But if the value of the node that I'm trying to delete doesn't exist, it crashes. Does anyone know how to fix that?

void deltarget (int value)
{

    if (front -> item == value)
        {
        Node *temp = front;
        temp = temp -> next;
        temp -> prev = NULL;
        front = temp;
        }
    else
    {
        Node *temp = front;
        while(temp -> item != value)
        {
            temp = temp -> next;
        }
        temp -> next -> prev = temp -> prev;
        temp -> prev -> next = temp -> next;
        delete temp;
    }

[Disch]

You have to check to see if you reached the end of the list. And if you have, then stop searching and don't try to delete any node.


Also, if the matching node is 'front', you are leaking memory because you aren't deleteing the front node.

[Jas Singh]

Even after doing that, it crashes.

void deltarget (int value)
{

    if (front -> item == value)
        {
        Node *temp = front;
        temp = temp -> next;
        temp -> prev = NULL;
        delete front;
        front = temp;
        }
    else if (tail -> item == value)
    {
        Node *temp = tail;
        temp -> prev -> next = NULL;
        temp = temp -> prev;
        delete tail;
        tail = temp;
    }
    else
    {
        Node *temp = front;
        while(temp -> item != value && temp -> next != NULL)
        {
            temp = temp -> next;
        }
        temp -> next -> prev = temp -> prev;
        temp -> prev -> next = temp -> next;
        delete temp;
    }