Issues with if loop and strcmp function

[snailtier]

I am almost done with this program except for one last issue! I have managed to isolate the problem to the if loop in the sort function, but I am unable to find any problems? However, all I am getting back is a blank window, the program never gets out of the void function.

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

void sort(char [][11]);

main()
{
      
char state[3][11];      

char str1[]="Florida";
char str2[]="Oregon";
char str3[]="California";
char str4[]="Georgia";

strcpy(state[0], str1);
strcpy(state[1], str2);
strcpy(state[2], str3);
strcpy(state[3], str4); 

sort(state); 

printf("%s\n", state[0]); 
printf("%s\n", state[1]);
printf("%s\n", state[2]);
printf("%s\n", state[3]);
 
system("PAUSE");
return 0; 
       
}


void sort (char Str[][11])
{
 int i=1;
 char temp[3][10];
 int flag=1;
 int d=4;
 
 while(flag =1 )
  {
    flag=0;
    d=(d+1)/2;       
    for(i=0; i<4-d; i++)
      {
         if( strcmp(Str[i+d],Str[i])>0)
          {
            *temp[0]=*Str[i+d];
            *Str[i+d]=*Str[i];
            *Str[i]=*temp[0];
            flag=1;
          }
          
      }   
  }    

  return;
}

[ne555]

42: warning: suggest parentheses around assignment used as truth value [-Wparentheses]

[snailtier]

I don't quite understand? There are already parenthesis around the truth value?

[Yanson]

Line 10 should look like this char state[4][11]; and line 42 should look like this while(flag ==1 )

[snailtier]

Thanks for the help! It now compiles properly, but however it won't sort?

It just outputs

Florida
Oregon
California
Georgia

and the goal of the program is to get them alphabetized!

Here is the updated program

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

void sort(char [][11]);

main()
{
      
char state[4][11];      

char str1[]="Florida";
char str2[]="Oregon";
char str3[]="California";
char str4[]="Georgia";

strcpy(state[0], str1);
strcpy(state[1], str2);
strcpy(state[2], str3);
strcpy(state[3], str4); 

sort(state); 

printf("%s\n", state[0]); 
printf("%s\n", state[1]);
printf("%s\n", state[2]);
printf("%s\n", state[3]);
 
system("PAUSE");
return 0; 
       
}


void sort (char Str[][11])
{
 int i=1;
 char temp[3][10];
 int flag=1;
 int d=4;
 
 while(flag==1)
  {
    flag=0;
    d=(d+1)/2;       
    for(i=0; i<4-d; i++)
      {
         if( strcmp(Str[i+d],Str[i])>0)
          {
            *temp[0]=*Str[i+d];
            *Str[i+d]=*Str[i];
            *Str[i]=*temp[0];
            flag=1;
          }
          
      }   
  }    

  return;
}

[Yanson]

Something like this

#include <stdio.h>
#include <stdlib.h>
#include <string.h>


void sort(char [][11]);

int main()
{
	char state[4][11];      

	char str1[]="Florida";
	char str2[]="Oregon";
	char str3[]="California";
	char str4[]="Georgia";

	strcpy(state[0], str1);
	strcpy(state[1], str2);
	strcpy(state[2], str3);
	strcpy(state[3], str4); 

	sort(state); 

	printf("%s\n", state[0]); 
	printf("%s\n", state[1]);
	printf("%s\n", state[2]);
	printf("%s\n", state[3]);

	system("PAUSE");
	return 0; 

}


void sort (char Str[][11])
{
	int i= 0;
	int j = 0;
	char temp[11];
	
	for(j = 0; j < 4; j++)
		{
			for(i=0; i<4; i++)
			{
				if( strcmp(Str[i], Str[i+1]) > 0)
				{
					strcpy(temp,Str[i]);
					strcpy(Str[i], Str[i+1]);
					strcpy(Str[i+1], temp);
				}
			} /*End inner for loop*/
		} /*End outer for loop*/ 
}