Please help me with this Run-Time Cjeck error

[Sinux Sand]

I've written a program in order to learn C++ but keeps giving me this error when I enter my choice.

Run-Time Check Failure #3 - The variable 'stdDetailsStruct_1' is being used without being initialized.

I don't know how to solve this I've checked and rechecked my code but can't understand what I've done wrong can some please help me with this.

My full code as follows

// e.cpp : Defines the entry point for the console application.


/********************************************************************************

Crated by Sadaruwan Samaraweera
In behalf of New Eastern Campus
Coding Start Date 22nd April 2013

*********************************************************************************/

#include <iostream>

#include <string>

 

using namespace std;

 
//Struct Declaration for stdDetails
struct stdDetails {

   	int stdNum; //Student Registration Number
    char fName[25]; // Student First Name
    char lName[25]; // Student Last Name
	char resAdd[50]; //Resident Address
	char dBirth[10]; // Student Date Of Birth
	int stdAge; // Student Age
	char nicNum[10]; // Sudent National ID number
	int conNum; // Student Contact Number
    char dateEnroll[10]; // Student Enrollment date
	char corsSelect[25]; // Course Selected
	char payMethod[10]; // Fee payment method
    double amtPaid; // Amount Student Paid for the course    
    char bksIssue[25]; //Issued Books

};


//Declartion of methods usend in this program
void ui(); //Method for displaying the UI
void output(stdDetails  stdDetailsStruct_1);
stdDetails  enterDetails (stdDetails stdDetailsStruct_1); //Method for entering student details to the prgoram
void entLine(); //To make interface more nice
void stars(); //Draws a line of stars to make CLI look more nice

//Declaration of i as a Variable for the counter
int i=0;

//Start of main method
int main(){

	ui();
    return 0;
}

//CLI method start from here on
void ui (){

    int  choice;
    stdDetails  stdDetailsStruct_1;
	stdDetails  stdDetailsStruct_2[1000];
	char ansr = 'y';
	int search = 0;

	stars();
	cout<<"		Welcome to New Eastern Campus "<<endl;
	cout<<endl;
	stars();
	entLine();

//Beginning of the while loop which will display the options that user have to enter
		do{

			cout<<"		Press Number [1] for New Student Registration  : "<<endl;
			cout<<"		Press Number [2] to Search Student Details : "<<endl;
			cout<<"		Press Number [3] to Delete Student Details : "<<endl;
			cout<<"		Press Number [4] to View Student Details: "<<endl;
			entLine();
			cout<<"		Enter your choice here: ";
			cin>>choice;
			entLine();
//Start of the switch case for every choice selected will perform an action
			switch(choice){

//This Case will add the details entered to the stdDetails array
				case 1:
					stdDetailsStruct_1 = enterDetails(stdDetailsStruct_1);
					stdDetailsStruct_2[i]=stdDetailsStruct_1;
					i++;
				break;

//This Case will search the array for a given keyword 
				case 2:{
					stdDetails stdDetailsStruct_0[1000];
					int kWord;
					stdDetails  stdFindRes;
					cout<<"Enter the Student Registration Number of the Student: ";
					cin>>kWord;
						for(int x=0;x<i;x++){
						stdFindRes = stdDetailsStruct_0[x];
						if(kWord == stdFindRes.stdNum){
								search=1;
							break;
							}
						}
						if(search==1){
							output(stdFindRes);
						}else{
							cout<<"Student details not found please try again."<<endl;
							search = 0;
						}
					   }
				break;

//This case will delete the students details form the array 
				case 3:{
					search=0;
					int delStd,m;
					stdDetails  stdDel;
					cout<<"Enter the Registration Numeber of the student: ";
					cin>>delStd;
						for(m=0;m<i;m++){
						stdDel = stdDetailsStruct_2[m];
							if(delStd==stdDel.stdNum){
								search=1;
							break;
							}
						}
						if(search==1){
							for(int z=m;z<i;z++){
								stdDetailsStruct_2[z]=stdDetailsStruct_2[z+1];
								i--;
							}
						}else{
							cout<<"Std  not found"<<endl;
						}
					   }
				break;
//This case will display the student details
				case 4:
					cout<<"=================================="<<endl<<endl;;
					for(int x=0;x<i;x++){
						stdDetails  stdView = stdDetailsStruct_2[x];
						output(stdView);
						cout<<endl;
						cout<<"***********************************"<<endl;
						cout<<endl;
					}
					cout<<"=================================="<<endl;
				break;

//The default message if  any thing goes wrong
				default:
					cout<<"Invalid Option Please Enter a Valid Entry"<<endl;
					break;
				}

//The option case list ends from here
				entLine();
				cout<<"Continue [y/n]: ";
				cin>>ansr;
				entLine();
			}while(ansr == 'y'||ansr == 'Y');

//While Loop Ends here

			cout<<"Thank You"<<endl;
}
//Ending of the UI system

//This method is used to decorate the interface
void entLine(){
	cout<<endl;
    cout<<endl;
}
//Method End

//Data Display Method Starts from here
void output(stdDetails  stdDetailsStruct_1){
    cout<<"Student Registration Number: "<<stdDetailsStruct_1.stdNum<<endl;
    cout<<"Student First Name: "<<stdDetailsStruct_1.fName<<endl;
    cout<<"Student Last Name: "<<stdDetailsStruct_1.lName<<endl;
	cout<<"Student Resident Address: "<<stdDetailsStruct_1.resAdd<<endl;
	cout<<"Student Date Of Birth: "<<stdDetailsStruct_1.dBirth<<endl;
	cout<<"Student Age: "<<stdDetailsStruct_1.stdAge<<endl;
	cout<<"Student National ID number: "<<stdDetailsStruct_1.nicNum<<endl;
	cout<<"Student Contact Number: "<<stdDetailsStruct_1.conNum<<endl;
	cout<<"Student Enrollment Date: "<<stdDetailsStruct_1.dateEnroll<<endl;
	cout<<"Selected Course: "<<stdDetailsStruct_1.corsSelect<<endl;
	cout<<"Payment Mthod: "<<stdDetailsStruct_1.payMethod<<endl;
	cout<<"Paid Amount: "<<stdDetailsStruct_1.amtPaid<<endl;
	cout<<"Books Issued: "<<stdDetailsStruct_1.bksIssue<<endl;
}
//Data Display Method Ends

//Data Entery Method start from here
stdDetails  enterDetails (stdDetails  stdDetailsStruct_1){

	cout<<"Enter Student Registration Number : ";
	cin>>stdDetailsStruct_1.stdNum;
	cout<<"Enter Sutdent Firs Name : ";
	cin>>stdDetailsStruct_1.fName;
	cout<<"Enter Student Last Name : ";
	cin>>stdDetailsStruct_1.lName;
	cout<<"Enter Student Resident Address : ";
	cin>>stdDetailsStruct_1.resAdd;
	cout<<"Enter Student DoB : ";
	cin>>stdDetailsStruct_1.dBirth;
	cout<<"Enter Student Age : ";
	cin>>stdDetailsStruct_1.stdAge;
	cout<<"Enter Student NIC number : ";
	cin>>stdDetailsStruct_1.nicNum;
	cout<<"Enter Student Contact number : ";
	cin>>stdDetailsStruct_1.conNum;
	cout<<"Enter Student Enrollment Date : ";
	cin>>stdDetailsStruct_1.dateEnroll;
	cout<<"Selected Course : ";
	cin>>stdDetailsStruct_1.corsSelect;
	cout<<"Payment Method : ";
	cin>>stdDetailsStruct_1.payMethod;
	cout<<"Amount Paid : ";
	cin>>stdDetailsStruct_1.amtPaid;
	cout<<"Books Issued : ";
	cin>>stdDetailsStruct_1.bksIssue;
	return stdDetailsStruct_1;
}
//Data Entry  Method End

//CLI Line of stars
void stars(){
for (int i=1; i<=50; i++) {
	cout << "*"<<endl;
}
}

[JLBorges]

> I don't know how to solve this I've checked and rechecked my code
> but can't understand what I've done wrong

What is wrong is easy to understand.

The variable 'stdDetailsStruct_1' is being used without being initialized.

To find out where the error is occurring, and then where you have forgotten to initialise the variable, run the program with the debugger.
Typically, from an IDE, Menu => Debug => ....

[ats15]

You cannot invoke stdDetailsStruct_1 = enterDetails(stdDetailsStruct_1); since stdetailsStruct_1 is not initialized.
Here is how you initialize a structure

#include <iostream>
#include <cstring>

struct test{
  int a;
  int b;
  char x[25];
  char y[25];
  
  test()
  {
    a=0;
    b=0;
    std::strcpy(x,"x");
    std::strcpy(y,"");
  }
};

int main()
{
  test p;
  std::cout<<p.a<<p.b<<p.y<<p.x<<std::endl;
  return 0;
}

[Sinux Sand]

This is the place where this error occurs.

//This Case will add the details entered to the stdDetails array
				case 1:
					stdDetailsStruct_1 = enterDetails(stdDetailsStruct_1);
					stdDetailsStruct_2[i]=stdDetailsStruct_1;
					i++;
				break;

I think I've initialized all the structs

[cire]

I think I've initialized all the structs

Nope. stdDetailsStruct_1 has not been assigned any meaningful value when it is fed to enterDetails. Looking at the implementation of enterDetails one wonders why it takes a parameter.

//Data Entery Method start from here
stdDetails enterDetails (){
        stdDetails stdDetailsStruct_1 ;
	cout<<"Enter Student Registration Number : ";
	cin>>stdDetailsStruct_1.stdNum;
        // ... 

would make more sense and then the case would become:

				case 1:
					stdDetailsStruct_1 = enterDetails();
					stdDetailsStruct_2[i++]=stdDetailsStruct_1;
				break;

[Sinux Sand]

I'm very sorry to be this dumb guys I've just started to learn C++ more of a PHP person any way I tried "CIRE" solution then it started to give fatal error so reverted back to the normal one.

Is there a any other way to initialize struct ats15 his way looks good but if some one can how to do the char is that way is correct.

[ajh32]

Add a default constructor to your struct. This will be called when ever your code creates an instance of the struct, and will initialise the member variables:

#include <string> // for memset

//Struct Declaration for stdDetails
struct stdDetails
{
	// default constructor will automatically
	// initialise member variables
	stdDetails()
		: stdNum(0)
		, stdAge(0)
		, conNum(0)
		, amtPaid(0)
	{
		memset(fName, 0, 25);
		memset(lName, 0, 25);
		memset(resAdd, 0, 50);
		memset(dBirth, 0, 10);
		memset(nicNum, 0, 10);
		memset(dateEnroll, 0, 10);
		memset(corsSelect, 0, 25);
		memset(payMethod, 0, 10);
		memset(bksIssue, 0, 25);
	}

	int stdNum;	//Student Registration Number
	int stdAge;	// Student Age
	int conNum;	// Student Contact Number
	double amtPaid;	// Amount Student Paid for the course
	char fName[25];	// Student First Name
	char lName[25];	// Student Last Name
	char resAdd[50];	//Resident Address
	char dBirth[10];	// Student Date Of Birth
	char nicNum[10];	// Sudent National ID number
	char dateEnroll[10]; // Student Enrollment date
	char corsSelect[25]; // Course Selected
	char payMethod[10];// Fee payment method    
	char bksIssue[25];	//Issued Books
};

[Sinux Sand]

ajh32 Thank you very much for teaching me thank you all for the help I'm very sorry to trouble you with my dumb questions but you have helped me a lot thank you again.