C++ LLL!

[geeksquad007]

Hi all!

I was just trying a simple c++ with LLL. I don't know why it adds data but when displaying, it shows nothing. Can anyone help? Thanks!

main.h //all the declaration of classes



#include<iostream>
using namespace std;

class profiledata
{
	public:
		profiledata();
		~profiledata();
		int addname(char newname[]);
		int addssn(char newssn[]);
		int adddob(char newdob[]);
		int copy(profiledata &);
		int display();
	
	private:
		char *name;
		char *ssn;
		char *dob;

};

struct node
{
	profiledata nodedata;
	node *next;
};

class operation
{
	public:
		operation();
		~operation();
		int add(profiledata &data);
		int display();
	
	private:
		node *head;
};




implementation.cpp     // implementation of all the member function



#include "main.h"
using namespace std;

profiledata::profiledata()
{
	name = NULL;
	ssn = NULL;
	dob = NULL;
}

profiledata::~profiledata()
{
	if(name)
	{
		delete name;
		delete []name;
	}
	
	if(ssn)
	{
		delete ssn;	
		delete []ssn;
	}	
	
	if(dob)
	{
		delete dob;
		delete []dob;
	}
}

int profiledata::addname(char newname[])
{
	if(name)
		delete []name;
	name = new char[strlen(newname) + 1];
	strcpy(newname,name);
	return 1;
}

int profiledata::addssn(char newssn[])
{
	if(ssn)
		delete []ssn;
	ssn = new char[strlen(newssn) + 1];
	strcpy(newssn,ssn);
	return 1;
}

int profiledata::adddob(char newdob[])
{
	if(dob)
		delete []dob;
	dob = new char[strlen(newdob) + 1];
	strcpy(newdob,dob);
	return 1;
}

int profiledata::copy(profiledata &datas)
{
	if(!name || !ssn || !dob)
		return 0;

	if(datas.name)
		delete datas.name;
	datas.name = new char [strlen(name) +1];
	strcpy(datas.name,name);
	
	if(datas.ssn)
		delete datas.ssn;
	datas.ssn = new char [strlen(ssn) +1];
	strcpy(datas.ssn,ssn);

	if(datas.dob)
		delete datas.dob;
	datas.dob = new char [strlen(dob) +1];
	strcpy(datas.dob,dob);
	return 1;
}

int profiledata::display()
{
	if(!name)
		return 0;

	cout<<"NAME: "<<name<<endl;
	cout<<"SSN: "<<ssn<<endl;
	cout<<"DOB: "<<dob<<endl;
	return 1;
}


operation::operation()
{
	head = NULL;
}

operation::~operation()
{
	node *temp = head;
	if(head)
	{
		while(head != NULL)
		{
			temp = head;
			delete []temp;
			delete temp;
		}	
	}
}

int operation::add(profiledata &data)
{
	node *temp = head;
	
	
	if(head == NULL)
	{
		head = new node;
		data.copy(head->nodedata);
		head ->next = NULL;
		return 1;
	}
		
	if(head != NULL)
	{
		while(temp->next!=NULL)
		{
			temp = temp->next;
		}	
		
		temp->next = new node;
		temp = temp->next;
		data.copy(temp->nodedata);
		temp->next = NULL;
		return 1;
	}
}


int operation::display()
{
	int count = 1;
	node *temp = head;
	
	if(!temp)
	{
		return 0;
	}
	else
	{
		while(temp != NULL)
		{
			cout<<endl<<count<<". "<<endl;
			temp->nodedata.display();
			temp = temp->next;
			count++;
		}
		return 1;
	}
	
	
}




application.cpp //user interaction




#include "main.h"
using namespace std;

int main()
{
	char name[100];
	char ssn[100];
	char dob[100];	

	profiledata data1;
	operation data;
	int choice = 0;
	

	do
	{
		cout<<endl<<endl<<"MAIN MENU:"<<endl<<endl;
		cout<<"1. ADD PROFILE"<<endl;
		cout<<"2. DISPLAY ALL"<<endl;
		cout<<"Enter your choice: ";
		cin>>choice;
		
		if(choice == 1)
		{
			cout<<endl<<"ENTER NAME: ";
			cin>>name;
			cout<<endl<<"ENTER SSN: ";
			cin>>ssn;
			cout<<endl<<"ENTER DOB: ";
			cin>>dob;

			data1.addname(name);
			data1.addssn(ssn);
			data1.adddob(dob);

			data.add(data1);
		}
		
		if(choice == 2)
		{
			data.display();
		}

	}while(choice>0&&choice<3);
}

[28poGNh0]

Your problem is to to much hard ,well,I am gonna do my best .

In your code you have those functions:

int addname(char newname[]);
int addssn(char newssn[]);
int adddob(char newdob[]);

right?

In those functions you have those strcpys!!

strcpy(newname,name);
strcpy(newssn,ssn);
strcpy(newdob,dob);

right?

shouldnt you turn them to

strcpy(name,newname);
strcpy(ssn,newssn);
strcpy(dob,newdob);

right?

uffffff that was not easy

[coder777]

you're using strcpy the wrong way. The destination is the first parameter:

http://www.cplusplus.com/reference/cstring/strcpy/?kw=strcpy

[geeksquad007]

LoL :) . Thanks for the reply!

[ne555]

By the way, stop shooting yourself on the foot

delete ssn;	
delete []ssn;

is undefined behaviour.

If you new then delete
If you new[] then delete[]

You'll also need to implement a proper copy constructor and assignment operator.
However, you may simply use std::string and don't worry about memory management