GCD

[coder1]

i wrote this GCD function to find gcd of an array of numbers
here is the code:

long long GCD(long long min,int loc,long long b[])
{
	for (long long i=min;i>0;i--)
	{
		bool p=0;
		for (long long x=0;x<loc;x++)
		{
			if (b[x]%i!=0)
			{
				p==1;
				break;
			}
		}
		if (p==0)
			return i;
	}
}

its returning wrong answers, please help
when i tried 6 14 it returns 6

[vlad from moscow]

Your function has undefined behaviour. It does not return any value in case then the outer loop finished its iterations.

[coder1]

i corrected it i put

return 0;

Out of the outer loop but still its giving wrong answers

[vlad from moscow]

If I have correctly understood the task your function could look the following way

unsigned long long GCD( unsigned long long a[], size_t n, unsigned long long min )
{
	unsigned long long i = min;

	while (  i > 1 && 
	         !std::all_of( a, a + n, std::not1( std::bind2nd( std::modulus<int>(), i ) ) ) i--;

	return i;
}

[coder1]

im sorry i didnt understand ur function, it should find the largest number that divides all the array elements without remainder

[vlad from moscow]

Here you use the comparison operator instead of the assignment operator.

			if (b[x]%i!=0)
			{
				p==1;
				break;
			}

[coder1]

oh thanks for helping me, many times i repeat this error