Solved.

Pages: 12

1
2
3

        this->r *= rhs.r;
        this->i *= rhs.r;
        return *this;

is not a rule for multiplication

Impossible. Are you sure that you did as in your previous code I even provided link to? Declaration in class, definition outside?

Look ↑

omiexstrike (64)

Solved.

Last edited on

MiiNiPaa (8886)

You did it again. Please look at code you had earlier and i provided link to and make operator<< exactly like that. In two places.

lines 47-49 will not be executed because return before them will stop function execution.

omiexstrike (64)

Solved.

Last edited on

MiiNiPaa (8886)

Why did you change addition and deduction assigment operators? They were completely fine. And you still made the same mistake with friend function declaration.

Ok, I officially give up. Here is the fixed code:
http://pastebin.com/Ae9xDUFg
It only lacks unari minus function and code that uses it was commented so it will not prevent compiling.
It compiles and works. You can look how you should make friend functions.

andywestken (4087)

@MiiNiPaa

Regarding

2) You cannot have friend definition inside class, only declaration.

Actually, this is perfectly valid in this case.

You are allowed to define a friend function within a class declaration (to quote the standard) "if and only if the class is a non-local class, the function name is unqualified, and the function has namespace scope."

#include <iostream>
#include <string>

class Message {
private:
    std::string m_text;

public:
    Message() : m_text("Hello, world!") {
    }

    Message(const std::string text) : m_text(text) {
    }

    friend std::ostream& operator<<(std::ostream& os, const Message& msg) {
        os << msg.m_text;
        return os;
    }
};

int main() {
    Message greeting;
    Message salutation("Bonjour le monde !");

    std::cout << greeting   << std::endl;
    std::cout << salutation << std::endl;

    return 0;
}

Hello, world!
Bonjour le monde !

Andy

Last edited on

omiexstrike (64)

Oh, so that's what you meant about the friend part of the code. Thanks a lot. I'm going to try to write the - (unary) part now.

omiexstrike (64)

Solved.

Last edited on

MiiNiPaa (8886)

Ok, problem with multiplication:

    Complex& operator*=(const Complex& rhs)
    {
		this->r = (this->r * rhs.r) - (this->i * rhs.i);
		this->i = (this->r * rhs.i) + (this->i * rhs.r);
		return *this; //↑ this.r is already changed on previous line
    }

fix:

   Complex& operator*=(const Complex& rhs)
    {
		int im = (this->r * rhs.i) + (this->i * rhs.r);
		this->r = (this->r * rhs.r) - (this->i * rhs.i);
		this->i = im;
		return *this;
    }

Share your unary minus code.