Random Number Generator

[mclemmon]

Hey guys, I am creating a random number generator and have run into a problem with my do while loop. it continually prints one of the lines of output infinitely. what am i missing here?

#include <iostream>
#include <cstdlib>
#include <ctime>
using namespace std;

int main()
{
	unsigned seed = time(0);
	srand(seed);
	int randomNum, guess;

	cout << "Guess A Number Between 1 and 100:   ";
	cin >> guess;
	randomNum = 1 + rand() % 100;

	do
	{
	
		cout << "\n\n";

		if (guess > randomNum)
		{
			cout << "Your guess is too high. Try again!\n";
		}
		else if (guess < randomNum)
		{
			cout << "Your guess is too low. Try again!\n";
		}
		else
		{
			cout << "You guessed the number. Congratulations! The number was " << randomNum;
		}
	} 
	while (guess != randomNum);
		cin.get();
		cin.get();

	return 0;
}

[Peter87]

The guess variable is never updated inside the loop.

[mclemmon]

oh yeah, right. Got that now, thanks. but now I don't see any text appear when the number is guessed correctly.

do
	{
		if (guess > randomNum)
		{
			cout << "Your guess is too high. Try again!\n";
			cout << "Guess A Number Between 1 and 100:   ";
			cin >> guess;
		}
		else if (guess < randomNum)
		{
			cout << "Your guess is too low. Try again!\n";
			cout << "Guess A Number Between 1 and 100:   ";
			cin >> guess;
		}
		else
		{
			cout << "You guessed the number. Congratulations! The number was " << randomNum;
		}
	} 
	while (guess != randomNum);

[wildblue]

The congratulations text will only appear if they guess correctly on the first try. If they get the right number on line 7 or line 13 after a wrong guess, the condition of the while loop on line 20 will be no longer be true and the loop will terminate.

[Peter87]

You probably need to flush cout.

cout << flush;
// or 
cout.flush();

Or you could use endl. It will output a newline character and flush cout. I guess you want a newline after the output anyway.

cout << "You guessed the number. Congratulations! The number was " << randomNum << endl;

[mclemmon]

flushing cout/using endl didn't do anything to fix the problem, but probably a good idea either way.

If they get the right number on line 7 or line 13 after a wrong guess, the condition of the while loop on line 20 will be no longer be true and the loop will terminate.

this makes sense... very raw to C++, any suggestions?

[whiteReve]

try to put

cout << "Guess A Number Between 1 and 100:   ";
cin >> guess;

inside do ... while and before the tests, and remove it from if else blocks

do
{
     cout << "Guess A Number Between 1 and 100:   ";
     cin >> guess;
     if()
     //...
}

[mclemmon]

try to put
1
2
cout << "Guess A Number Between 1 and 100: ";
cin >> guess;


inside do ... while and before the tests, and remove it from if else blocks

that did the trick. thanks a million, peeps :)