C++

Forum

 
Help with password program my strong and medium functions don't seem to work. I need them to

christellemecca (3)
#include<fstream>
#include<string>
#include<iostream>
using namespace std;

bool searchCommon(string userpassword, int count,string commonpasswords[])
{
for(int i =0; i<count;i++)
{
if(userpassword.find(commonpasswords[i])!=string::npos)
{
return true;
}
}
return false;
}
bool isCommon(string userpassword,int count,string commonpasswords[] )
{
for (int i = 0; i<count; i++)
{
if (userpassword == commonpasswords[i])
{
return true;
}
}
return false;
}




bool specialChar(string userpassword, int count)
{
for(int count = 0; count < userpassword.length(); count++)
{

if(userpassword[count]=='!'|| userpassword[count]=='$'|| userpassword[count]=='%'|| userpassword[count]=='?')
{
return true;
}
}

return false;
}

bool containsNum(string userpassword, int count)
{
for(int count = 0; count < userpassword.length();count++)
{
if(userpassword[count]>='0'&&userpassword[count]<='9')
{
return true;
}
}

return false;
}
bool containUpper(string userpassword, int count)
{
for(int count =0;count<userpassword.length();count++)
{
if(userpassword[count]>='A' && userpassword[count]<='Z')
{
return true;

}
}
return false;

}
bool containLower(string userpassword, int count)
{
for(int count =0;count<userpassword.length();count++)
{
if(userpassword[count]>='a' && userpassword[count]<='z')
{
return true;

}
}
return false;
}

bool isAlpha(string userpassword,int count)
{
for(int count = 0; count < userpassword.length(); count++)
{
if(userpassword[count]>='A' && userpassword[count]<='Z' && userpassword[count]>='a'&& userpassword[count]<='z')
{
return true;
}
}
return false;
}

bool lengthCheck(string userpassword, int count)
{
for(int count =0; count<userpassword.length();count++)
{
if(userpassword[count]>=8)
{
return true;
}
}
return false;
}

int main()
{

int length,size,i = 0,iscommon = 0,count = 0; ;
string special,userpassword;
const int maxpassword=10000;
string commonpassword[maxpassword];


ifstream passwordFile("Text.txt");
ofstream outputfile("User.txt",ofstream::app);

if(passwordFile.is_open())
{
if(!passwordFile)
{
cout<<"File not found!"<<endl;
return 1;
}
while(!passwordFile.eof())
{
passwordFile >> commonpassword[count++];
}

while(userpassword != "q")
{

cout<<"PASSWORD RULES: \n";
cout<<" "<<endl;
cout<<"-Your password MUST be atleast 8 characters long \n";
cout<<"\n -Contain at least one alpha charcater \n";
cout<<"\n -Contain at least one numeric character \n";
cout<<"\n -Atleast one special character from this set: ! $ % ? \n ";
cout<<"- No spaces allowed \n";
cout<<"\n Enter your password (or 'Q' to quit): \n";

getline(cin,userpassword);
size=userpassword.length();
bool iscommonpasswords;
bool iscontainLetter;
bool iscontainUpper;
bool islengthCheck;
bool iscontainNum;
bool iscontainSpecial;
bool iscontainLower;
bool trueCommon;
bool weak;
bool medium;
bool strong;

if(isCommon(userpassword,count,commonpassword))
{
outputfile<<userpassword << "True\n";
iscommonpasswords=true;
}

if(isAlpha(userpassword,count))
{
iscontainLetter=true;
}

if(containUpper(userpassword, count))
{
iscontainUpper=true;
}

if(lengthCheck(userpassword,count))
{
islengthCheck=true;
}

if(containsNum(userpassword, count))
{
iscontainNum=true;

}

if(specialChar(userpassword, count))
{
iscontainSpecial=true;
}

if(containLower(userpassword,count))
{
iscontainLower=true;
}
if(searchCommon(userpassword,count,commonpassword))
{
trueCommon=true;
}
if(containLower&&containsNum&&lengthCheck&&isAlpha&&isCommon&&searchCommon)
{
weak= true;
}
else if (containLower&&containsNum&&lengthCheck&&isAlpha&&isCommon&&containUpper&&searchCommon)
{
medium=true;
}
else if (containLower&&containsNum&&lengthCheck&&isAlpha&&!isCommon&&containUpper&&searchCommon)
{
strong=true;
}
if(weak)
{
cout<<"Password is weak"<<endl;
}
else if(medium)

{
cout<<"Password is medium"<<endl;
}
else if(strong)
{
cout<<"Password is strong"<<endl;
}
}
outputfile.close();
passwordFile.close();
}
system("pause");
return 0;

}
giblit (3750)
Please use code tags around your code. You can either edit, select all code then press the <> button or put [ code] (without spaces) before and [/code] after. example 
[code]int main()
{
    return 0;
}[/code]
looks like 
1
2
3
4
 
int main()
{
    return 0;
}
Please refer to http://www.cplusplus.com/articles/z13hAqkS/ for more information.

As far as your actual problem would you be a little more specific on what you need help with. You didn't ask any questions you just provided code and said you need them to "work." If you won't help us know what your problem is we won't be able to help you.
Last edited on
christellemecca (3)
Sorry I'm not sure what your talking about with the whole putting [code].
But my problem is whenever I run the code, no matter what kind of password I enter, the results I get output says "weak" all the time. What I mean by "I need them to work" is my medium and strong functions. I'm not sure if the program is just outputting weak all the time cause that's the function I have written first in the program (weak function). But then that would make all my password strength functions wrong. I just need help with that. Thanks!
Last edited on
wildblue (1505)
On the right side of the post, there's a Format: menu - if you highlight your code and click the <> button at the top left, it will format your code for the forum like it is below. It makes it much easier for others to read, especially if there's a lot of code :) And it adds in row numbers so it's easier to point out certain lines.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
 
#include<fstream>
#include<string>
#include<iostream>
using namespace std;

bool searchCommon(string userpassword, int count,string commonpasswords[])
{
	for(int i =0; i<count;i++)
	{
		if(userpassword.find(commonpasswords[i])!=string::npos)
		{
			return true;
		}
	}
	return false;
}

bool isCommon(string userpassword,int count,string commonpasswords[] )
{
	for (int i = 0; i<count; i++)
	{
		if (userpassword == commonpasswords[i])
		{
			return true;	
		}
	}
	return false;
}

bool specialChar(string userpassword, int count)
{
	for(int count = 0; count < userpassword.length(); count++)
	{
		if(userpassword[count]=='!'|| userpassword[count]=='$'|| userpassword[count]=='%'|| userpassword[count]=='?')
		{
		return true;
		}
	}
	return false;
}

bool containsNum(string userpassword, int count)
{
	for(int count = 0; count < userpassword.length();count++)
	{
		if(userpassword[count]>='0'&&userpassword[count]<='9')
		{
			return true;
		}
	}
	return false;
}

bool containUpper(string userpassword, int count)
{
	for(int count =0;count<userpassword.length();count++)
	{ 
		if(userpassword[count]>='A' && userpassword[count]<='Z')
		{
			return true;
		}
	}
	return false;
}

bool containLower(string userpassword, int count)
{
	for(int count =0;count<userpassword.length();count++)
	{ 
		if(userpassword[count]>='a' && userpassword[count]<='z')
		{
			return true;
		}
	}
	return false;
}

bool isAlpha(string userpassword,int count)
{
	for(int count = 0; count < userpassword.length(); count++)
	{
		if(userpassword[count]>='A' && userpassword[count]<='Z' && userpassword[count]>='a'&& userpassword[count]<='z')
		{
			return true;
		}
	}
	return false;
}

bool lengthCheck(string userpassword, int count)
{
	for(int count =0; count<userpassword.length();count++)
	{
		if(userpassword[count]>=8)
		{
			return true;
		}
	}
	return false;
}

int main()
{
	int length,size,i = 0,iscommon = 0,count = 0; ; 
	string special,userpassword;
	const int maxpassword=10000;
	string commonpassword[maxpassword];

	ifstream passwordFile("Text.txt");
	ofstream outputfile("User.txt",ofstream::app);

	if(passwordFile.is_open())
	{
		if(!passwordFile)
		{
			cout<<"File not found!"<<endl;
			return 1;
		}
		while(!passwordFile.eof())
		{
			passwordFile >> commonpassword[count++];
		}
		while(userpassword != "q")
		{
			cout<<"PASSWORD RULES: \n";
			cout<<" "<<endl;
			cout<<"-Your password MUST be atleast 8 characters long \n";
			cout<<"\n -Contain at least one alpha charcater \n";
			cout<<"\n -Contain at least one numeric character \n";
			cout<<"\n -Atleast one special character from this set: ! $ % ? \n ";
			cout<<"- No spaces allowed \n";
			cout<<"\n Enter your password (or 'Q' to quit): \n";
		
			getline(cin,userpassword);
			size=userpassword.length();
			bool iscommonpasswords;
			bool iscontainLetter;
			bool iscontainUpper;
			bool islengthCheck;
			bool iscontainNum;
			bool iscontainSpecial;
			bool iscontainLower;
			bool trueCommon;
			bool weak;
			bool medium;
			bool strong;
	
			if(isCommon(userpassword,count,commonpassword))
			{
				outputfile<<userpassword << "True\n";
				iscommonpasswords=true;
			}
			if(isAlpha(userpassword,count))
			{
				iscontainLetter=true;
			}
			if(containUpper(userpassword, count))
			{
				iscontainUpper=true;
			}
			if(lengthCheck(userpassword,count))
			{
				islengthCheck=true;
			}
			if(containsNum(userpassword, count))
			{
				iscontainNum=true;
			}
			if(specialChar(userpassword, count))
			{
				iscontainSpecial=true;
			}
			if(containLower(userpassword,count))
			{
				iscontainLower=true;
			}
			if(searchCommon(userpassword,count,commonpassword))
			{
				trueCommon=true;
			}
			if(containLower&&containsNum&&lengthCheck&&isAlpha&&isCommon&&searchCommon)
			{
				weak= true;
			}
			else if (containLower&&containsNum&&lengthCheck&&isAlpha&&isCommon&&containUpper&&searchCommon)
			{
				medium=true;
			}
			else if (containLower&&containsNum&&lengthCheck&&isAlpha&&!isCommon&&containUpper&&searchCommon)
			{
				strong=true;
			}
			if(weak)
			{
				cout<<"Password is weak"<<endl;
			}
			else if(medium)
			{
				cout<<"Password is medium"<<endl;
			}
			else if(strong)
			{
				cout<<"Password is strong"<<endl;
			}
		}
		outputfile.close();
		passwordFile.close();
	}
	system("pause");
	return 0;
}
booradley60 (896)
Lines 181-192 are problematic. They are logically equivalent to:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
 
            if(containLower && containsNum && lengthCheck && isAlpha && searchCommon)
            {
                if(isCommon)
                {
                    weak = true;
                }
                else if(isCommon && containUpper)
                {
                    medium = true;
                }
                else if(!isCommon && containUpper)
                {
                    strong = true;
                }
            }

There is a way that none of those bools will be set, and the medium=true line could never, ever execute (a condition of that 'else if' already satisfies the 'if' above).

You may want to think about this differently. Consider:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
 
//some #includes... other stuff at the top of the file
enum PasswordStrength { WEAK, MEDIUM, STRONG };
//your functions...
int main()
{
    //...
            PasswordStrength pwStrength = PasswordStrength::WEAK; //default to WEAK until we prove it is stronger
            if(containLower && containsNum && lengthCheck && isAlpha && searchCommon && containUpper)
            {
                if(isCommon)
                {
                    pwStrength = PasswordStrength::MEDIUM;
                }
                else
                {
                    pwStrength = PasswordStrength::STRONG;
                }
            }
    //...

Your code uses three booleans to represent 1 piece of information: "strength of password". The only way these booleans are meaningful is if only one of them is true. That means there are several arrangements of them (none of them true, more than one of them being true) that don't make sense. Using an enum reduces this to one variable. One variable to represent one piece of information.
Topic archived. No new replies allowed.