Console app crashing after calling function


Im new to debugging but it says the problem is on line 97 which is the verb menu function being called in the first switch statement case 0:


verb menu is one of the sub menus i want ,and it loads but then it crashes ...



1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292


#include <iostream>
#include <string>
#include "spanishverbs.h"
#include <windows.h>

#include <cmath>
#include <cstdlib>

using namespace std;


void nounmenu();

void verbmenu();





void mainmenu()
{
system("cls");
cout<<tospeak;
string menu[4]={"Verb Study and Quizzes ","Noun and pronouns","Sentences","Exit"};

  int  pointer =0;


//menu main menu

while(true) {
system("cls");


SetConsoleTextAttribute(GetStdHandle(STD_OUTPUT_HANDLE), 15);
cout << "SPANISH STUDY and QUIZZES\n\n";
for(int i=0;i < 4; ++i){
  if (i==pointer){

SetConsoleTextAttribute(GetStdHandle(STD_OUTPUT_HANDLE), 11);
cout<<menu[i]<<endl;
}

else {




SetConsoleTextAttribute(GetStdHandle(STD_OUTPUT_HANDLE), 15);

cout<<menu[i]<<endl;
}
}
while(true){
if (GetAsyncKeyState(VK_UP) !=0 )

{


pointer-=1;
if (pointer == -1)

{
pointer=3;


}
break;
}



else if(GetAsyncKeyState(VK_DOWN)!=0)

{
pointer +=1;
if (pointer==4){
    pointer=0;
Sleep(500);

}
break;
}
else if(GetAsyncKeyState(VK_RETURN)!=0){

switch(pointer){




pointer=0;

case 0:



 verbmenu();


break;


case 1:




nounmenu();

break;
case 2:





break;

case 3:






break;

case 4:


break;


}

}

Sleep(500);
}
}
}




void verbmenu(){

int pointer=0;
string menu[3]={"Verb StudY","Verb Quizzes","Exit"};
while(true){
system("cls");
SetConsoleTextAttribute(GetStdHandle(STD_OUTPUT_HANDLE), 15);
cout<<"VERB MENU\n\n";



for (int i=0; i<4  ; ++i){





if(i==pointer){

SetConsoleTextAttribute(GetStdHandle(STD_OUTPUT_HANDLE), 11);
cout<<menu[i]<<endl;


}

else
{


SetConsoleTextAttribute(GetStdHandle(STD_OUTPUT_HANDLE), 15);
cout<<menu[i]<<endl;


}
}


while (true){

    if (GetAsyncKeyState(VK_UP)!=0){
            pointer-=1;
            if(pointer==-1)

            {
Sleep(500);
                pointer=2;
            }
            break;
            }
            else if(GetAsyncKeyState(VK_DOWN)!=0){

                    pointer+=1;
                if (pointer==2)

                {
                    Sleep(500);
                    pointer=0;

                }
                break;
            }
            else if(GetAsyncKeyState(VK_RETURN)!=0)

            {
switch(pointer){

pointer =0;

case 0 :

    {
        cout<<"hello0";
    }

break;

case 1:

    {

        cout<<"hello 1";
    }
    break;




case 2:{
  mainmenu();

}

break;



            }

            }


}

// FIRST  while TRUE STATEMENT





}

}
void nounmenu(){






}

int main (){


 mainmenu();
return 0;


}















At line 151, an array of 3 items is declared:
 
    string menu[3]


Then at line 159, there is a loop,
 
    for (int i=0; i<4  ; ++i){


when i reaches the value 3, at line 178, an out of bounds array access is done,
 
    cout<<menu[i]<<endl;
which results in the crash.

By the way, the formatting of the code is horrible, a bit less vertical space and consistent indentation would help a lot with legibility.
I cleaned up your code a bit.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
#include <iostream>
#include <string>
#include "spanishverbs.h"
#include <windows.h>


using namespace std;


void verbmenu ( );

void nounmenu ( );


void mainmenu ( )
{
    system ( "cls" );

    cout << tospeak;

    string menu[4] = { "Verb Study and Quizzes", "Noun and Pronouns", "Sentences", "Exit" };
    
    int pointer = 0;


    while ( true )
    {
        system ( "cls" );


        SetConsoleTextAttribute ( GetStdHandle ( STD_OUTPUT_HANDLE ) , 15 );

        cout << "SPANISH STUDY and QUIZZES\n\n";


        for ( int i = 0; i < 4; ++i )
        {
            if ( i == pointer )
                SetConsoleTextAttribute ( GetStdHandle ( STD_OUTPUT_HANDLE ) , 11 );

            else
                SetConsoleTextAttribute ( GetStdHandle ( STD_OUTPUT_HANDLE ) , 15 );

            cout << menu[i] << '\n';
        }


        while ( true )
        {
            if ( GetAsyncKeyState ( VK_UP ) )
            {
                if ( --pointer == -1 ) pointer = 3;

                break;
            }

            else if ( GetAsyncKeyState ( VK_DOWN ) )
            {
                if ( ++pointer == 4 )
                {
                    pointer = 0;

                    Sleep ( 500 );
                }

                break;
            }


            else if ( GetAsyncKeyState ( VK_RETURN ) )
            {
                switch ( pointer )
                {
                    pointer = 0;

                    case 0:
                        verbmenu ( );
                        break;
                    case 1:
                        nounmenu ( );
                        break;
                    case 2:
                        break;
                    case 3:
                        break;
                    case 4:
                        break;
                }
            }

            Sleep ( 500 );
        }
    }
}

void verbmenu ( )
{
    int pointer = 0;

    string menu[3] = { "Verb Study", "Verb Quizzes", "Exit" };


    while ( true )
    {
        system ( "cls" );

        SetConsoleTextAttribute ( GetStdHandle ( STD_OUTPUT_HANDLE ) , 15 );

        cout<<"VERB MENU\n\n";


        for ( int i = 0; i < 3; ++i )
        {
            if ( i == pointer )
                SetConsoleTextAttribute ( GetStdHandle ( STD_OUTPUT_HANDLE ) , 11 );

            else
                SetConsoleTextAttribute ( GetStdHandle ( STD_OUTPUT_HANDLE ) , 15 );

            cout << menu[i] << '\n';
        }


        while ( true )
        {
            if ( GetAsyncKeyState ( VK_UP ) )
            {
                if ( --pointer == -1 )
                {
                    pointer = 2;

                    Sleep ( 500 );
                }

                break;
            }

            else if ( GetAsyncKeyState ( VK_DOWN ) )
            {
                if ( ++pointer == 2 )
                {
                    pointer = 0;

                    Sleep ( 500 );
                }

                break;
            }

            else if ( GetAsyncKeyState ( VK_RETURN ) )
            {
                switch ( pointer )
                {
                    pointer = 0;

                    case 0:
                    case 1:
                        cout << "hello " << pointer;
                        break;
                    case 2:
                        mainmenu ( );
                        break;
                }
            }
        }
    }
}

void nounmenu ( )
{
}

int main ( )
{
    mainmenu ( );
}

Can you give us more information on the crash? Does it crash when it tries to run verbmenu(), or inside verbmenu()? What error message do you get?
Looks like Chervil found the problem.

You seem to have a lot of repeated code. You could probably combine some of it.
Last edited on
Thank you both of you ,but that was the problem the for ( int i = 0; i < 4; ++i )
in the verbmenu function i changed the 4 to 3 and it works thanks .
Topic archived. No new replies allowed.