Help me

[lekha]

well i have 2 new problems...

1. when i play again the percentage is increasing to 160% 180% and so on... why is tat so.. i know its something to do wit my "per=" code but im not preety sure how to edit it.. please teach me..

2. if let say i remove the srand() and paste it out side its showing error..
and if i remove for the rest and remain it only on void add()... the subract and the rest is not generating random number...

the code..

#include <cstdlib>
#include <iostream>
#include <stdlib.h>
#include <ctime>
#include <iomanip>
#include <string>
#include <fstream>

using namespace std;
int correctcounter=0;
int incorrectcounter=0;
float per;        
static int number;

void add()
{
         unsigned seed = time(0);    
         srand(seed);
         int A = rand()%20+1;
         int B = rand()%20+1;
        
         int result=0;

         cout<<A<<" + "<<B<<" = ?"<<endl;
         cout<< "Answer : ";
         cin>>result;
         cout<<endl;
        
         if(result == A+B)
         {
         correctcounter++;
         cout<<"CORRECT!! Well done!! "<<endl<<endl;
         cout<<"----------------------------------------------------"<<endl;
        
         }
         if(result !=A+B)
         {
         incorrectcounter++;
         cout<<"WRONG!! The answer is "<<A+B<<endl<<endl;
         cout<<"----------------------------------------------------"<<endl;
         }
}

void subtract()
{
        unsigned seed = time(0);    
        srand(seed);
        int A = rand()%20+1;
        int B = rand()%20+1;
        
        int result=0;

        cout<<A<<" - "<<B<<" = ?"<<endl;
        cout<< "Answer : ";
        cin>>result;
        cout<<endl;
        
        if(result == A-B){
        correctcounter++;
        cout<<"CORRECT!! Well done!! "<<endl<<endl;
        cout<<"----------------------------------------------------"<<endl;
        
        }
        if(result !=A-B){
        incorrectcounter++;
        cout<<"WRONG!! The answer is "<<A-B<<endl<<endl;
        cout<<"----------------------------------------------------"<<endl;
        }
}

void multiply()
{
        int result=0;

        unsigned seed = time(0);    
        srand(seed);
        int A = rand()%20+1;
        int B = rand()%20+1;
        
        cout<<A<<" * "<<B<<" = ?"<<endl;
        cout<< "Answer : ";
        cin>>result;
        cout<<endl<<endl;
        
        if(result == A*B){
        correctcounter++;
        cout<<"CORRECT!! Well done!! "<<endl<<endl;
        cout<<"----------------------------------------------------"<<endl;
        
        }
        if(result !=A*B){
        incorrectcounter++;
        cout<<"WRONG!! The answer is "<<A*B<<endl<<endl;
        cout<<"----------------------------------------------------"<<endl;
        }

}

void divide()
{
        int result=0;

        unsigned seed = time(0);    
        srand(seed);
        int A = rand()%20+1;
        int B = rand()%20+1;
        if (B>A)
            {
              int temp = A;
              A = B;
              B = temp;
             }
        
        cout<<A<<" / "<<B<<" = ?"<<endl;
        cout<< "Answer : ";
        cin>>result;
        
        if(result == A/B){
        correctcounter++;
        cout<<"CORRECT!! Well done!! "<<endl;
        cout<<"----------------------------------------------------"<<endl;
        
        }
        if(result !=A/B){
        incorrectcounter++;
        cout<<"WRONG!! The answer is "<<A/B<<endl;
        cout<<"----------------------------------------------------"<<endl;
        }
}
char displayMenu();
int Selection;
char displayMenu()
 {   
     cout << "Select a topic"<<endl;
     cout <<endl;  
          cout << "1.Addition"<<endl;
          cout << "2.Subtraction"<<endl;   
          cout << "3.Multiplication"<<endl;
          cout << "4.Division"<<endl<<endl;
          cout << "Topic No. : ";
     cin >> Selection;
     
     system("cls");
}  
int main()
{
  char again;
  do
  {  displayMenu();
     switch(Selection){		//	Switchcase on said number
		case 1:
            for(int i=1;i<=5;i++) 
            {  
                cout << "QUESTION " << i<< endl<< endl;
    	    	add();	//	If 1; addition
            }
    	    	cout<< "CORRECT ANSWER : "<< correctcounter<<endl;
    	    	cout<< "WRONG ANSWER : "<< incorrectcounter<<endl<<endl;
    	    	per=(correctcounter*100)/5;
    	    	cout<<"Percentage is "<<per<<"%"<<endl<<endl;
            break;
        
		case 2:
            for(int i=1;i<=5;i++) 
            {  
                cout << "QUESTION " << i<< endl<< endl;
    			subtract(); //	If 2; subtraction
            }
    	    	cout<< "CORRECT ANSWER : "<< correctcounter<<endl;
    	    	cout<< "WRONG ANSWER : "<< incorrectcounter<<endl<<endl;
    	    	per=(correctcounter*100)/5;
    	    	cout<<"Percentage is "<<per<<"%"<<endl<<endl;

            break;
            
		case 3:
            for(int i=1;i<=5;i++) 
            {  
                cout << "QUESTION " << i<< endl<< endl;
    			multiply(); //	If 3; multiplication
    		}
    	    	cout<< "CORRECT ANSWER : "<< correctcounter<<endl;
    	    	cout<< "WRONG ANSWER : "<< incorrectcounter<<endl<<endl;
    	    	per=(correctcounter*100)/5;
    	    	cout<<"Percentage is "<<per<<"%"<<endl<<endl;

            break;
        
		case 4:

            for(int i=1;i<=5;i++) 
            {  
                cout << "QUESTION " << i<< endl<< endl;
    			divide(); //	If 4; division
    		}
    	    	cout<< "CORRECT ANSWER : "<< correctcounter<<endl;
        	    cout<< "WRONG ANSWER : "<< incorrectcounter<<endl<<endl;
        	    per=(correctcounter*100)/5;
    	    	cout<<"Percentage is "<<per<<"%"<<endl<<endl;

            break;
            
        default:
			cout << "ERROR: Please enter the topic number from 1-4." << endl<<endl;
            
            
      	}
    cout << "Do you want to play again? (y/n)";
    cin >> again;
           system("cls");
  } while (again == 'y');


   

    system("PAUSE");
    return EXIT_SUCCESS;
}

[Peter87]

1. You never reset correctcounter and incorrectcounter.

2. Call srand once, at the beginning of main().

[lekha]

should i add like this before the main...

unsigned seed = time(0);
srand(seed);

and,
how do i write code to reset...

im searching online but cant find anything...

[Peter87]

srand should be called from inside main but before the loop starts.

By reset I mean set correctcounter and incorrectcounter to zero.

correctcounter = 0;
incorrectcounter = 0;

[lekha]

thank sooooo muchh... i really appreciate your help alot... thank you...

have a nice day... :D