Multiple account login problems

[jasonwynn10]

How can I be able to use more than one account? Please Help!
**Updated**
Code:

#include <iostream>
#include <string>
#include <fstream>
#include <stdio.h>
#include <conio.h>
#include <stdlib.h>
#include <cstdlib>
#include <string.h>
#include <windows.h>
#include <sstream>
using namespace std;

void menu();
void userinput();
void accountinput();
void accountlogin();
void Deposit();
void Withdraw();
void balanceholder();
void seconds_count();

double answer,deposit, withdraw,balance=0,chances = 3,Id,pass;
int choice;
const int MAX_WRONG = 5;
char cChoice;
string Pass, ID,Balance,s,IDin,Passin;
string username;
string password;

int main()
{
system ("color 2f");
printf("Do you want to register y/n -> ");
                cin>>cChoice;
                printf("\n");

                if(cChoice=='Y'||cChoice=='y')
                {
    ofstream myfile ("IDs_file.txt");
    if (myfile.is_open())
    {
    printf("\nEnter your new Pin -> ");
    cin>>ID;
    myfile << ID;
    printf("\nEnter your new Password -> ");
    cin>>Pass;
    myfile << ":" << Pass<<"\n";
    myfile.close();
    }
    else cout << "Unable to open file";
printf("\n\nRestart the program for the new pin and password to take effect\n\n");
system("pause");
return 0;}
accountlogin();
accountinput();
}
void accountlogin()
{
    ifstream myfile("IDs_file.txt");
    if(!myfile)
    {
        cerr << "Error opening ID input file.";
    }
    if(getline(myfile, username, ':') >> password){
    int wrong = 0;
    string userChoice;
    string userChoice2;
SYSTEM_LOOP:
    system ("cls");
    cout << "Username : " << endl;
    cin >> userChoice;
    cout<<endl;

    cout << "Password : " << endl;
    cin >> userChoice2;
    cout<<endl;

    if (userChoice == username && userChoice2 == password)
    {
        cout<<"correct !"<<endl;
        system ("pause");
        system ("cls");
    }
    else if (userChoice != username && userChoice2 != password)
    {
        cout<<"incorrect !"<<endl;
        wrong++;
        system ("pause");

        if (wrong == MAX_WRONG)
        {
            seconds_count();
        }
        goto SYSTEM_LOOP;
    }
    else if (userChoice == username && userChoice2 != password)
    {
        cout<<"incorrect !"<<endl<<endl;
        system ("pause");
        goto SYSTEM_LOOP;
    }
    else if (userChoice != username && userChoice2 == password)
    {
        cout<<"incorrect !"<<endl<<endl;
        system ("pause");
        goto SYSTEM_LOOP;
    }
}}
void accountinput()
{
  ifstream myfile("Balance.txt");
    if(!myfile){cerr << "Error opening ID input file.";}
    string data;
    getline(myfile, data, ':') >> balance;
    if(data==username)
    {

    }
    myfile.close();
userinput();
}
void userinput()
{
while (choice != 4)
{
cout << "Welcome to jasonwynn10's ATM Machine\n";
cout << "[1]Display Balance \n";
cout << "[2]Deposit Money\n";
cout << "[3]Withdraw Money\n";
cout << "[4]Exit\n";
cout << "Enter your Choice:";
cin >> choice;
switch (choice)
{
case 1:
cout << "Your Balance is :" <<balance<< endl;
system("pause");
system("cls");
break;
case 2:
Deposit();
break;
case 3:
Withdraw();
break;
case 4:
cout << "Your Balance is :" <<balance<< endl;
balanceholder();
system("pause");
break;
default:
cout<<"Say Again? \n> ";
cin >> choice;
break;
}
}
}
void Deposit()
{
cout << "Your Current Balance is " << balance << endl;
cout << "How much Money you want to deposit:" << endl;
cin >> deposit;
balance = balance + deposit;
cout << "Your new balance is :" << endl;
cout << balance;
cout << endl;
system("pause");
system("cls");
userinput();

}
void Withdraw()
{
cout << "Your Current Balance is " << balance << endl;
cout << "How much Money do you want to withdraw:" << endl;
cin >> withdraw;
if (withdraw > balance)
cout << "Sorry you don't have enough money to withdraw" << endl;
else if (withdraw <= 0)
cout << "sorry amount can not be zero or negative" << endl;
else
balance = balance - withdraw;
cout << "You Withdraw :" << withdraw << endl;
cout << "Your new balance is :" << endl;
cout << balance<<endl;
system("pause");
system("cls");
userinput();
}
void balanceholder()
{
    ofstream myfile ("Balance.txt");
    if (myfile.is_open())
    {
    myfile <<username<<":"<<balance;
    myfile.close();}
    else cout << "Unable to open file";
}
void seconds_count()
{
    for (int c = 30 ; c > 0 ; c--)
    {
        cout<<"Please wait "<<c<<" seconds"<<endl;
        Sleep (1000);
        system ("cls");
    }
}

IDs_file.txt:

Id: 1911
Pass: 1234
Id: 2202
Pass: 4452

Balance.txt:

1911: 1234332
2202: 2253

[jasonwynn10]

anyone there?

[jlb]

ow could one create a Login system using my program I started in the accountlogin() function.

Probably the easiest thing to do would be to start over from the beginning. With all the bad practices demonstrated in the code you supplied along with the horrible, shall I say lack of any, indentation that makes reading the program a chore, starting over is the best option IMO.

Before you start screaming "What bad practices", start with your includes, here your mixing C++ and C standard headers. If you're going to write a C++ program stick with the C++ standard headers (<cstdlib>) and leave the C standard headers (<stdlib.h>) home.

Next stop using the global variables, put the variables into the correct functions and pass the required variables to and from your functions.

Next stop mixing C-stdio functions and C++ streams this seems to be a C++ program so stick with the C++ streams.

[jasonwynn10]

I didn't build this entire program so I don't know what I can and can't remove some parts of the program that he made, and so I will not remove the standard C headers. Here's a code update aswell.

[jasonwynn10]

there is a problem on line 68. I don't understand it. can anyone help me?

[jlb]

What don't you understand? Is balance a std::string? The getline() function requires a std::string for it's second argument.

[jasonwynn10]

then how do you convert a string to a double?

[TwilightSpectre]

Assuming a C++11 compiler, here is an example:

#include <string>
#include <fstream>

int main() {
    std::fstream myfile("file.txt");

    std::string line;
    std::getline(myfile, line);

    double val = std::stod(line);

    // or you could just do this (which is easier and makes more sense): 
    myfile >> val; 
}

So, for your case the best solution for line 68 (and the other places) is probably this:
while(std::cin >> balance)

[jasonwynn10]

My compiler does not accept stod(), I've tried before. But I found a solution. I used stringstream.

[jasonwynn10]

I need to be able to read the file using Id: and Pass: as a guide to where the inputs are. any help?

[jlb]

Why do you need to convert the string to a double? Why not just extract the double from the file. First extract the text to a string, ie Id: then extract the double.

example:

int main()
{
    ifstream myfile("IDs_file.txt");
    if(!myfile)
    {
        cerr << "Error opening ID input file.";
        return(10);
    }

    string data;
    int number; 
    if(getline(myfile, data, ':') >> number) 
    {
        // now use the data however you want!
       if( data == "Id")
          this is the Id number.
       else
           this is the Pin number.

    }

[jasonwynn10]

thanks, I really appreciate the help!

[jasonwynn10]

What about the balance.txt file? same thing?

[jlb]

You should be able to use the extraction operator to extract the first number, a trash character (:) and then the last number.

int Id;
char trash;
double balance;

YourFileStreamName >> Id >> trash >> balance;

[jasonwynn10]

ok, now I need a way to be able to have more than one account usable, and I also need to be able to pull up their balances.
Once again, Thank you for your help.

Code update:

#include <iostream>
#include <string>
#include <fstream>
#include <stdio.h>
#include <conio.h>
#include <stdlib.h>
#include <cstdlib>
#include <string.h>
#include <windows.h>
#include <sstream>
using namespace std;

void menu();
void userinput();
void accountinput();
void accountlogin();
void Deposit();
void Withdraw();
void balanceholder();
void seconds_count();

double answer,deposit, withdraw,balance=0,chances = 3,Id,pass;
int choice;
const int MAX_WRONG = 5;
char cChoice;
string Pass, ID,Balance,s,IDin,Passin;
string username;
string password;

int main()
{
system ("color 2f");
printf("Do you want to register y/n -> ");
                cin>>cChoice;
                printf("\n");

                if(cChoice=='Y'||cChoice=='y')
                {
    ofstream myfile ("IDs_file.txt");
    if (myfile.is_open())
    {
    printf("\nEnter your new Pin -> ");
    cin>>ID;
    myfile << ID;
    printf("\nEnter your new Password -> ");
    cin>>Pass;
    myfile << ":" << Pass<<"\n";
    myfile.close();
    }
    else cout << "Unable to open file";
printf("\n\nRestart the program for the new pin and password to take effect\n\n");
system("pause");
return 0;}
accountlogin();
accountinput();
}
void accountlogin()
{
    ifstream myfile("IDs_file.txt");
    if(!myfile)
    {
        cerr << "Error opening ID input file.";
    }
    if(getline(myfile, username, ':') >> password){
    int wrong = 0;
    string userChoice;
    string userChoice2;
SYSTEM_LOOP:
    system ("cls");
    cout << "Username : " << endl;
    cin >> userChoice;
    cout<<endl;

    cout << "Password : " << endl;
    cin >> userChoice2;
    cout<<endl;

    if (userChoice == username && userChoice2 == password)
    {
        cout<<"correct !"<<endl;
        system ("pause");
        system ("cls");
    }
    else if (userChoice != username && userChoice2 != password)
    {
        cout<<"incorrect !"<<endl;
        wrong++;
        system ("pause");

        if (wrong == MAX_WRONG)
        {
            seconds_count();
        }
        goto SYSTEM_LOOP;
    }
    else if (userChoice == username && userChoice2 != password)
    {
        cout<<"incorrect !"<<endl<<endl;
        system ("pause");
        goto SYSTEM_LOOP;
    }
    else if (userChoice != username && userChoice2 == password)
    {
        cout<<"incorrect !"<<endl<<endl;
        system ("pause");
        goto SYSTEM_LOOP;
    }
}}
void accountinput()
{
  ifstream myfile("Balance.txt");
    if(!myfile){cerr << "Error opening ID input file.";}
    string data;
    getline(myfile, data, ':') >> balance;
    if(data==username)
    {

    }
    myfile.close();
userinput();
}
void userinput()
{
while (choice != 4)
{
cout << "Welcome to jasonwynn10's ATM Machine\n";
cout << "[1]Display Balance \n";
cout << "[2]Deposit Money\n";
cout << "[3]Withdraw Money\n";
cout << "[4]Exit\n";
cout << "Enter your Choice:";
cin >> choice;
switch (choice)
{
case 1:
cout << "Your Balance is :" <<balance<< endl;
system("pause");
system("cls");
break;
case 2:
Deposit();
break;
case 3:
Withdraw();
break;
case 4:
cout << "Your Balance is :" <<balance<< endl;
balanceholder();
system("pause");
break;
default:
cout<<"Say Again? \n> ";
cin >> choice;
break;
}
}
}
void Deposit()
{
cout << "Your Current Balance is " << balance << endl;
cout << "How much Money you want to deposit:" << endl;
cin >> deposit;
balance = balance + deposit;
cout << "Your new balance is :" << endl;
cout << balance;
cout << endl;
system("pause");
system("cls");
userinput();

}
void Withdraw()
{
cout << "Your Current Balance is " << balance << endl;
cout << "How much Money do you want to withdraw:" << endl;
cin >> withdraw;
if (withdraw > balance)
cout << "Sorry you don't have enough money to withdraw" << endl;
else if (withdraw <= 0)
cout << "sorry amount can not be zero or negative" << endl;
else
balance = balance - withdraw;
cout << "You Withdraw :" << withdraw << endl;
cout << "Your new balance is :" << endl;
cout << balance<<endl;
system("pause");
system("cls");
userinput();
}
void balanceholder()
{
    ofstream myfile ("Balance.txt");
    if (myfile.is_open())
    {
    myfile <<username<<":"<<balance;
    myfile.close();}
    else cout << "Unable to open file";
}
void seconds_count()
{
    for (int c = 30 ; c > 0 ; c--)
    {
        cout<<"Please wait "<<c<<" seconds"<<endl;
        Sleep (1000);
        system ("cls");
    }
}