Problem accessing StringOfcars

[olette]

#include <iostream>
#include <string>
#include <vector>
#include <fstream> //for file operations

using namespace std;
//Car class

//Defined enum here
enum Kind{business,maintenance,other,box,tank,flat,otherFreight,chair,seater,otherPassenger};
//Defined array of strings
string KIND_ARRAY[]={"business","maintenance","other,box","tank,flat","otherFreight","chair","seater","otherPassenger"};
class Car
{
protected: //changed to protected
string reportingMark;
int carNumber;
Kind kind; //changed to Kind
bool loaded;
string destination;

public:

//Defined setKind function
Kind setKind(string knd)
{
   for(int i=0;i<8;i++) //repeat upto 8 kinds
   {
       if(knd.compare(KIND_ARRAY[i])==0) //if matched in Array
        kind=(Kind)i; //setup that kind
   }
   return kind;
}
  
  
  
//Default constructor
Car()
{
}
//Parameterized constructor
Car(string _reportingMark,int _carNumber,string _kind,bool _loaded,string _destination)
{
reportingMark = _reportingMark;
carNumber = _carNumber;
kind = setKind(_kind);
loaded = _loaded;
destination = _destination;
}

//Destructor
~Car()
{
}

//Copy constructor
Car( const Car &other)
{
reportingMark = other.reportingMark;
carNumber = other.carNumber;
kind = other.kind; //calls setup function
loaded = other.loaded;
destination = other.destination;

}

Car operator=(Car other)
{
reportingMark = other.reportingMark;
carNumber = other.carNumber;
kind = other.kind;
loaded = other.loaded;
destination = other.destination;
return *this;
}
friend bool operator==(Car c1,Car c2);

void setUp() //Implemented setup() code here
{
string knd;
//cout<<"Implementing Progress\n";
cout<<"Enter Type/Kind of car : ";
cin>>knd;
setKind(knd);
}

void output()
{
cout<<"Reporting Mark: "<<reportingMark<<endl;
cout<<"Card Number: "<< carNumber<<endl;
cout<<"Kind: "<< KIND_ARRAY[kind]<<endl; //Modified printing of Kind
cout<<"Loaded: "<< loaded<<endl;
cout<<"Destination: "<< destination<<endl;
}
};
//Friend function
bool operator==(Car c1,Car c2)
{
if(c1.reportingMark==c2.reportingMark
&& c1.carNumber == c2.carNumber
&& c1.kind == c2.kind
&& c1.loaded == c2.loaded
&& c1.destination == c2.destination)
{
return true;
}
else
{

return false;
}

}

//Class FreightCar

class FreightCar:public Car
{
public:
//Default constructor
FreightCar()
{
   Car();
}
//Parameterized constructor
FreightCar(string _reportingMark,int _carNumber,string _kind,bool _loaded,string _destination)
{
Car(_reportingMark,_carNumber,_kind,_loaded,_destination); //calling base class constructor
}

//Defined virtual setKind() function
virtual Kind setKind(string knd)
{
   for(int i=0;i<8;i++) //repeat upto 8 kinds
   {
       if(knd.compare(KIND_ARRAY[i])==0) //if matched in Array
        kind=(Kind)i; //setup that kind
   }
   return kind;
}

//Virtual Destructor
virtual ~FreightCar()
   {
   }
};


//Class PassengerCar here

class PassengerCar:public Car
{
public:
//Default constructor
PassengerCar()
{
   Car();
}
//Parameterized constructor
PassengerCar(string _reportingMark,int _carNumber,string _kind,bool _loaded,string _destination)
{
Car(_reportingMark,_carNumber,_kind,_loaded,_destination); //calling base class constructor
}

//Defined virtual setKind() function
virtual Kind setKind(string knd)
{
   for(int i=0;i<8;i++) //repeat upto 8 kinds
   {
       if(knd.compare(KIND_ARRAY[i])==0) //if matched in Array
        kind=(Kind)i; //setup that kind
   }
   return kind;
}

//Virtual Destructor
virtual ~PassengerCar()
   {
   }
};

/* ********** StringOfCars member functions ********** */

class StringOfCar
{
private:
Car *cars; //pointer of cars
int carCount; //defined additional data member carCount
public:
//Default constructor
StringOfCar()
{
   cars=NULL;
   carCount=0;
}
//Parameterized constructor
StringOfCar(Car *_cars)
{
cars = _cars;
carCount=0;
}

//Copy construtor
StringOfCar( const StringOfCar &obj)
{
cars = obj.cars;
carCount=0;
}

//Destructor
~StringOfCar()
{
   //deleting each car allocated
   for(int i=0;i<carCount;i++)
   delete cars;
}

int getCount() //UFD here defined here
{return carCount;}

void output()
{
for(int i=0; i<carCount; i++)
{
cars[i].output();
}
}

void push(Car car)
{
  
cars[carCount++]=car;
}

Car pop()
{
Car lastObj = cars[--carCount]; //getting top of stack of cars
return lastObj;
}

void input()
{
cout<<"In progress!\n";

ifstream infile("cars.txt");
while(!infile.eof()) //reading from file of cars.txt
{
infile>>reportingMark;
infile>>carNumber;
infile>>kind;
infile>>loaded;
infile>>destination;
Car c(reportingMark,carNumber,kind,loaded,destination); //store to object car
push(c); //store to stack
}
infile.close();
}


};

int main()
{

//Removed code and added modified code here
StringOfCar scars; //create object of StringOfCar
scars.input(); //read from file
for(int i=0;i<scars.getCount();i++) //repeat of loop
scars.pop(); //pop each StrngOfCar

return 0;

}

Any ideas?

[Peter87]

The input() function is not a member function. That's why you can't access any of the member variables directly.

[olette]

So what would I have to do to go about accessing it?

[Peter87]

I got a bit confused by the lack of indentation. I see now that the input() function is part of the StringOfCar class.

Inside the input() function you have not yet declared the variables (reportingMark, carNumber, etc.) in scope when you try to use them on line 248-252. You probably want to declare these variables locally inside the input() function (preferably inside the loop).