TIC-TAC-TOE Debugging

[Karina]

I need help debugging this code.

  #include <iostream>
#include <vector>
#include <iomanip>
#include <string>
using namespace std;

// Change these to match your letters
const char L = 'L';
const char U = 'U';

const int SIZE = 3;
// For testing we might change this to 5 or 7,our code should still work

const int MAXMOVES = SIZE*SIZE;
// The max number of moves is the size of the SIZE by SIZE grid

const int WID = 3;
// can help to align the board


int getNumber(string prompt, int range) {
	if (range > 1) {
		int num = 0;
		while ((num < 1) || (num >(range))) {
			cout << prompt << " (";
			for (int i = 0; i < range; ++i) {
				cout << (i + 1) << " ";
			}
			cout << "): ";
			cin >> num;
			if (cin.fail()) {
				cin.clear(); // unset failbit
				cin.ignore(numeric_limits<streamsize>::max(), '\n'); // skip bad input 
				cout << "Must be between 1 and " << SIZE << "." << endl;
			}
			cout << endl;
		}
		return num - 1;
	}
	else if (range == 1) {
		return 0;
	}
	return -1;
}

int getNum(string prompt) {
	int num = 0;
	bool done = false;
	while (!done) {
		cout << prompt << " ";
		if (cin >> num) {
			done = true;
		}
		if (cin.fail()) {
			cin.clear(); // unset failbit
			cin.ignore(numeric_limits<streamsize>::max(), '\n'); // skip bad input 
			cout << "Must be an integer." << endl;
		}
	}
	return num;
}

void doSeed() {
	int seedVal = -1;
	char inputSeed = 'n'; // asks user if they want to input the random seed

	cout << "Input Seed? (y/n) ";
	cin >> inputSeed;
	cout << endl;

	if (inputSeed == 'y') {
		seedVal = getNum("Seed: ");
	}

	// set seed for random numbers
	if (inputSeed != 'y' || seedVal < 0) {  // seed value must be positive,
											// so if you get a negative value, just use time
		srand(time(NULL));
	}
	else {
		srand(seedVal);
	}

	cin.clear(); // unset failbit
	cin.ignore(numeric_limits<streamsize>::max(), '\n'); // skip bad input 
}

/*
Function: userMove

Query the user for row and column for their move
Ask repeatedly/loop until they choose a location that is still empty
Mark the location with the user's symbol
Use the getNumber function to get the row and column values
exit loop

*/
void userMove(vector< vector<char> >& board) {  //remove for exam
	bool done = false;
	while (!done) {
		int i = getNumber("Which row? ", SIZE);
		int j = getNumber("Which column? ", SIZE);
		if (board.at(i).at(j) == '_') {
			done = true;
			board.at(i).at(j) = L;
		}
		else {
			cout << "(" << (i + 1) << ", " << (j + 1) << ") already taken." << endl;
		}
	}
}

/*
Write this function

Function: computerMove

Randomly create a row and column in the range of the board
Repeat/loop until a location is found that is still empty
Mark the location with the computer's symbol
exit loop
*/
void computerMove(vector< vector<char> >board) { 
	bool done = false;
	while (!done) {
		int i = rand() % 3;
		int j = rand() % 3;

		if (board.at(i).at(j) == 'L' || board.at(i).at(j) == 'U') {
			done = false;
		}
		else {
			board.at(i).at(j) = 'L';
		}
	}
	
}



/*
Write this function

Function: printBoard

outputs the content of the board in a SIZE by SIZE grid

_  _  X
O  _  X
_  O  _

*/

void printBoard(vector<vector<char>>& board) {
	for (int i = 0; i < SIZE; i++) {
		for (int j = 0; j < SIZE; j++) {
			cout << " " << board.at(i).at(j);
			;
		}
		cout << endl;
	}
	cout << endl;
}

/*
Write this function

Function checkRow

Check to see if the character passed in is the
character all the way across a row.
If it is a win, return true
otherwise, return false

*/
bool checkRow(vector< vector<int> >& board, vector<int> called) {
	bool rowWon = false;  
	int i = 0;
	
	while (!rowWon && i < SIZE) {
		rowWon = true; 
		int j = 0;
		while (rowWon && j < SIZE) {
			if (called.at(board.at(i).at(j) - 1) == 0) { 
				rowWon = false; 
			}
			++j;
		}
		++i;
	}
	return rowWon;
}

/*
Write this function

Function checkColumn

Check to see if the character passed in is the
character all the way down a column.
If it is a win, return true
otherwise, return false
*/
bool checkCol(vector< vector<int> >& board, vector<int> called) {
	bool colWon = false;
	int j = 0;

	while (!colWon && j < SIZE) {
		colWon = true;
		int i = 0;
		while (colWon && i < SIZE) {
			if (called.at(board.at(i).at(j) - 1) == 0) {
				colWon = false;
				++i;
			}
			++j;
		}
		return colWon;
	}
}
/*
Write this function

Function checkDiag

Check to see if the character passed in is the
character all the way across a diagonal.
The diagonals are from top-left to bottom-right,
and from bottom-left to top-right.
If it is a win, return true
otherwise, return false
*/
bool checkDiag(vector< vector<int> >& board, vector<int> called) {
	// check diagonal top-left to bottom-right
	int i = 0;  // i is both the row AND the column
	bool diagWon = true;
	while (diagWon && i < SIZE) {
		if (called.at(board.at(i).at(i) - 1) == 0) {
			diagWon = false;
		}
		++i;
	}
	if (diagWon) { // no need to check further if won
		return diagWon;
	}

	// check diagonal bottom-left to top-right
	i = 0;  // row is i, column is last index minus i
	diagWon = true;
	while (diagWon && i < SIZE) {
		if (called.at(board.at(i).at(SIZE - 1 - i) - 1) == 0) {
			// checks 0,4; 1,3; 2,2; 3,1; 4,0 
			diagWon = false;
		}
		++i;
	}
	return diagWon;
}

bool checkWin(vector< vector<char> >& board, vector<int> called) {
	return checkRow(board, called) || checkCol(board, called) || checkDiag(board, called);
}

bool checkCat(int moves) { // i.e. a tie, no more moves to make
	if (moves == MAXMOVES) {
		return true;
	}
	return false; 
}

char getWinner(vector< vector<char> >& board, int moves) {
	if (checkWin(board, L)) {   // see if user wins
		return L;  
	}
	if (checkWin(board, U)) { // see if computer wins
		return U;
	}
	// if no winner yet... check and see if it is a tie game / cat
	if (checkCat(moves)) {
		return 'c';
	}
	// Neither player is a winner and not a tie game so return the blank 
	//   location symbol '_'
	return '_';
}

int main() {
	char playAgain = 'y';
	while (playAgain == 'y') {
		doSeed();
		vector< vector<char> > board(SIZE, vector<char>(SIZE, '_'));
		// initializes the vector with '_' (underscore)
		//  this allows to blank locations to be visible
		cout << "Welcome to Tic Tac Toe" << endl << endl;
		printBoard(board);
		
		// use a char instead of a boolean
		//  when a winner is found, their symbol will be used to indicate
		//  not only that there is a winner, but who won
		char winner = '_';
		// no winner until assigned with appropriate symbol for user or computer
		int moves = 0;
		// we have to count moves so we don't get stuck once we run out
		//    , i.e. fill up the board
		//  if we look for a move when there isn't one, we will end up
		//  in an infinite loop
		while (winner == '_') { // repeat/loop until there is a winner 
                            //  or cat (i.e. a tie)

			if (moves < MAXMOVES) { // only let the user fill a square if there is
                              //   still one empty
				userMove(board);
				moves++;
			}

			if (moves < MAXMOVES) { // only let the computer fill a square if there is
                              //   still one empty
				computerMove(board);
				moves++;
			}

			printBoard(board);

			winner = getWinner(board, moves);
			// set to the winner's symbol or 'c' if cat (i.e. a tie)

		}
		// once we get here a winner was found so
		if (winner == 'c') { // tie
			cout << "CAT!" << endl;
		}
		else { // winner
			cout << winner << " Won!!!" << endl;
		}
		cout << endl << "Play again? (y/n) ";
		cin >> playAgain;
		cin.clear(); // unset failbit
		cin.ignore(numeric_limits<streamsize>::max(), '\n'); // skip bad input 
		playAgain = tolower(playAgain);
	}
	system("pause");
}      

[cire]

I need help debugging this code.

You might start by telling us whatever it is that makes you believe it needs debugging.