Moving code from CPP to Header(s)?

[J Plant]

I need some help. I am working on creating a game with three games in them. 
I have most/all the code in the CPP file. 
However, I would like to move some of the code from the CPP file into Header files, 
to make it look nicer. 
Below are the files used in the game. Only Hangman has code, so far, 
so that I can do the same for the other games later. 
Any help would be greatly appreciated! Thanks!

Game.cpp

#include <iostream>
#include <fstream>
#include <string>
#include <vector>
#include <algorithm>
#include <ctime>
#include <cctype>
#include <chrono>
#include <thread>
#include <stdio.h>

#include "BlackJack.h"
#include "Hangman.h"
#include "HangmanEasy.h"
#include "HangmanHard.h"
#include "Snake.h"

using namespace std;

void ClearScreen()
{
	int n;
	for (n = 0; n < 10; n++)
		printf("\n\n\n\n\n\n\n\n\n\n");
}

int main()
{
	bool MenuRepeat = true;
	int UserSelection;

	do
	{
		cout << endl;
		cout << "Welcome! Please pick one of the following options. 
                \n1. Play BlackJack \n2. Play Hangman \n3. Play Snake \n4. Quit \nOption: ";
		cin >> UserSelection;
		cout << endl;

		switch (UserSelection)
		{
			
		case 1:
		{
			blackjack bl;
			bl.BlackJack();
			break;
		}

		case 2:
		{
			hangman hm;
			hm.Hangman();
			break;
		}

		case 3:
		{
			snake sk;
			sk.Snake();
			break;
		}

		case 4:
		{
			MenuRepeat = false;
			break;
		}

		default:
		{
			cout << "Incorrect Option. Please either play one of the games or Quit." << endl;
			break;
		}

		}
	} while (MenuRepeat);

	return 0;
}

void blackjack::BlackJack()
{
	cout << "Welcome to BlackJack!";

    /*
	Code goes here.
	*/
	
	cout << "Returning to Menu...";

	int frameWait = 5000;
	std::this_thread::sleep_for(std::chrono::milliseconds(frameWait));

	ClearScreen();
}

void hangman::Hangman()
{
	{
		bool HangmanMenuRepeat = true;
		int HangmanDifficultySetting;

		do
		{
			cout << endl;
			cout << "Welcome to Hangman! Please Select A Difficulty Setting 
or Quit the Game.\n(1 for Easy | 2 for Hard | 3 to Return to Main Menu)\n";
			cin >> HangmanDifficultySetting;
			cout << endl;

			switch (HangmanDifficultySetting)
			{

			case 1:
			{
				hangmaneasy es;
				es.HangmanEasy();
				break;
			}

			case 2:
			{
				hangmanhard hr;
				hr.HangmanHard();
				break;
			}

			case 3:
			{
				HangmanMenuRepeat = false;
				break;
			}

			default:
			{
				cout << "Invalid Option." << endl;
				break;
			}

			}

		} while (HangmanMenuRepeat);

		return;
	}
	
}

void hangmaneasy::HangmanEasy()
{
	const int MAX_WRONG_EASY = 8;
	vector<string> easywords;

	easywords.push_back("ALGORITHM");
	easywords.push_back("POINTER");
	easywords.push_back("COMPILER");
	easywords.push_back("SYNTAX");
	easywords.push_back("VARIABLE");
	easywords.push_back("FUNCTION");
	easywords.push_back("PUBLIC");
	easywords.push_back("PRIVATE");
	easywords.push_back("PROTECTED");
	easywords.push_back("HEADER");

	srand(static_cast<unsigned int>(time(0)));
	random_shuffle(easywords.begin(), easywords.end());
	const string THE_EASY_WORD = easywords[0];
	int easywrong = 0;
	string EasySoFar(THE_EASY_WORD.size(), '-');
	string EasyUsed = " ";

	cout << "Welcome to Beginner Hangman!\n\nBefore we begin, all letters entered 
MUST be in capitals, other than that...\nGood Luck and have fun!";

	while ((easywrong < MAX_WRONG_EASY) && (EasySoFar != THE_EASY_WORD))
	{
		cout << "\n\nSo far, the word is:\n\n" << EasySoFar << endl;
		cout << "\nYou've used the following letters:\n" << EasyUsed << endl;
		cout << "You have " << (MAX_WRONG_EASY - easywrong) << " incorrect guesses left.\n";

		char EasyGuess;
		cout << "\nEnter your guess: ";
		cin >> EasyGuess;
		EasyGuess = toupper(EasyGuess);
		while (EasyUsed.find(EasyGuess) != string::npos)
		{
			cout << "\nYou've already guessed " << EasyGuess << endl;
			cout << "Enter your guess: ";
			cin >> EasyGuess;
			EasyGuess = toupper(EasyGuess);
		}

		EasyUsed += EasyGuess;

		if (THE_EASY_WORD.find(EasyGuess) != string::npos)
		{
			cout << "\nThat's Correct! " << EasyGuess << " is in the word!";

			for (int i = 0; i < THE_EASY_WORD.length(); i++)
			{
				if (THE_EASY_WORD[i] == EasyGuess)
				{
					EasySoFar[i] = EasyGuess;
				}
			}
		}
		else
		{
			cout << "\nSorry, " << EasyGuess << " isn't in the word.";
			++easywrong;
		}
	}

	if (easywrong == MAX_WRONG_EASY)
	{
		cout << "\n\nSorry! You've been hanged!\n";
	}
	else
	{
		cout << "\nGood job! You've guessed it!\n";
	}

	cout << "\nThe word was: " << THE_EASY_WORD << endl;

	cout << "Returning to Menu...";

	int frameWait = 5000;
	std::this_thread::sleep_for(std::chrono::milliseconds(frameWait));

	ClearScreen();

	return;
}

void hangmanhard::HangmanHard()
{
	const int MAX_WRONG_HARD = 5;
	vector<string> hardwords;

	hardwords.push_back("DHTML");
	hardwords.push_back("INHERITANCE");
	hardwords.push_back("POLYMORPHISM");
	hardwords.push_back("PSEUDOCODE");
	hardwords.push_back("XHTML");
	hardwords.push_back("METALANGUAGE");
	hardwords.push_back("ENCAPSULATION");
	hardwords.push_back("DECLARATION");
	hardwords.push_back("BACKPROPAGATION");
	hardwords.push_back("ARITHMETIC");

	srand(static_cast<unsigned int>(time(0)));
	random_shuffle(hardwords.begin(), hardwords.end());
	const string THE_HARD_WORD = hardwords[0];
	int hardwrong = 0;
	string HardSoFar(THE_HARD_WORD.size(), '-');
	string HardUsed = " ";

	cout << "Welcome to Expert Hangman!\n\nBefore we begin, all letters entered 
MUST be in capitals, other than that...\nGood Luck and have fun!";

	while ((hardwrong < MAX_WRONG_HARD) && (HardSoFar != THE_HARD_WORD))
	{
		cout << "\n\nSo far, the word is:\n\n" << HardSoFar << endl;
		cout << "\nYou've used the following letters:\n" << HardUsed << endl;
		cout << "You have " << (MAX_WRONG_HARD - hardwrong) << " incorrect guesses left.\n";

		char HardGuess;
		cout << "\nEnter your guess: ";
		cin >> HardGuess;
		HardGuess = toupper(HardGuess);
		while (HardUsed.find(HardGuess) != string::npos)
		{
			cout << "\nYou've already guessed " << HardGuess << endl;
			cout << "Enter your guess: ";
			cin >> HardGuess;
			HardGuess = toupper(HardGuess);
		}

		HardUsed += HardGuess;

		if (THE_HARD_WORD.find(HardGuess) != string::npos)
		{
			cout << "\nThat's Correct! " << HardGuess << " is in the word!";

			for (int i = 0; i < THE_HARD_WORD.length(); i++)
			{
				if (THE_HARD_WORD[i] == HardGuess)
				{
					HardSoFar[i] = HardGuess;
				}
			}
		}
		else
		{
			cout << "\nSorry, " << HardGuess << " isn't in the word.";
			++hardwrong;
		}
	}

	if (hardwrong == MAX_WRONG_HARD)
	{
		cout << "\n\nSorry! You've been hanged!\n";
	}
	else
	{
		cout << "\nGood job! You've guessed it!\n";
	}

	cout << "\nThe word was: " << THE_HARD_WORD << endl;

	cout << "Returning to Menu...";

	int frameWait = 5000;
	std::this_thread::sleep_for(std::chrono::milliseconds(frameWait));

	ClearScreen();

	return;
}

void snake::Snake()
{
	cout << "Welcome to Snake!";

	/*
	Code goes here.
	*/

	cout << "Returning to Menu...";

	int frameWait = 5000;
	std::this_thread::sleep_for(std::chrono::milliseconds(frameWait));

	ClearScreen();
}

Hangman.h

#ifndef _HANGMAN_H_
#define _HANGMAN_H_

class hangman
{
public:
	void Hangman();
};

#endif

HangmanEasy.h

#ifndef _HANGMANEASY_H_
#define _HANGMANEASY_H_

class hangmaneasy
{
public:
	void HangmanEasy();
};

#endif

HangmanHard.h

#ifndef _HANGMANHARD_H_
#define _HANGMANHARD_H_

class hangmanhard
{
public:
	void HangmanHard();
};

#endif

BlackJack.h

#ifndef _BLACKJACK_H_
#define _BLACKJACK_H_

class blackjack
{
public:
	void BlackJack();
};

#endif

Snake.h

#ifndef _SNAKE_H_
#define _SNAKE_H_

class snake
{
public:
	void Snake();
};

#endif 

[MikeyBoy]

When posting code, please use code tags to make it readable:

http://www.cplusplus.com/articles/z13hAqkS/

You've been asked this before. If you're going to ignore what people write in their replies to you, why should we continue to bother replying?

You don't move code into a header file to "make it look nicer". You move code into a header file because you need certain definitions to be available to other translation units.

Typically, that includes things like:

- class definitions (including method declarations, but not method definitions)
- function declarations
- const symbol definitions
- type definitions

Basically, if something needs to be publically accessible by other translation units, you should put them into a header file.

Are you also planning to split your code up into separate CPP files?

[J Plant]

Sorry,

Well, okay, what I meant was to separate it into Headers and possibly CPP files.

So, would an example that could work be 'easyword.push_back("word")' if I put it into a Header file?

[MikeyBoy]

You don't have anything called easyword in your code. You have a vector called easywords, but that's a local variable in a method, so no other translation unit could access that variable anyway.

[TheIdeasMan]

Hi,

Each class should have it's own header file (I like *.hpp ) with the class definition inside, and it's own cpp file with the class function definitions. Name the files exactly the same as the class name. You may actually already (nearly) have this, just you posted it all in one lump?

Any file that needs to use a class should #include that class' header file. There is potential to have a problem called circular includes, which is solved by doing a forward declaration of a class. Google to see what I mean about that.

Your classes don't have constructors - well you have a function with the same name but different case, so it's not a constructor. And all the code is in this function, no member data or public interface at all.

Have a read of the tutorial at the top left of this page, look at the examples of classes.

[J Plant]

Hi!

Sorry I haven't replied in over a week,
but I've managed to split the Game.cpp into more cpp files.
Thanks for the help!