Vector Inventory problem fixed

[NoviceNate333]

This is my implementation of a vector based inventory system. I had a lot of help from AbstractAnon,jlb, && cire. If anyone has any recommendation or any fixes on a bug i dont see please feel free to share. The commands i used are just the commands in the api i am using (Dark gdk). It should be pretty simple to change based on other APIs.
Main Code

#include "DarkGDK.h"
#include "Inventory.h"

void DarkGDK( )
{
	dbSyncOn( );
	dbSyncRate( 60 );

	dbLoadImage("back.jpg",1);
	Inventory ui;
	ui.AddItem("Sword",1,"Weapon",150);
	ui.AddItem("Health Potion",1,"Potion",70);
	


	while( LoopGDK( ) )
	{
		
		ui.Update();
		dbSync( );
	}
        ui.~Inventory();

}

Inventory class

#include "darkgdk.h"

#include "Item.h"
#include "WeaponItem.h"
#include "potionItem.h"

#include <vector>
#include <string.h>
#ifndef INV_H
#define INV_H

class Inventory
{
public:
	std::vector<Item*> items;
	Inventory()
	{
		inMenu = false;
		timer = 0;
		s=0;
	}
	~Inventory()
	{
		for(unsigned i = 0; i < items.size(); i++)
		{
			delete items[i];
		}
	}
	void AddItem(std::string name, int amnt, std::string type, int price)
	{
		
			if(type.compare("Weapon")==0) 
			{
				Item *ITEM = new WeaponItem(name,type,amnt,price);
				items.push_back(ITEM);
			}
			if(type.compare("Potion")==0) 
			{
				Item *ITEM = new PotionItem(name,type,amnt,price);
				items.push_back(ITEM);
			}
			
		//and so on for each item 
		
	}

	int Select(int x, int y, std::string name, int amnt, std::string type, int price, unsigned position )
	{
			char *cName = &name[0u];
			dbText(x,y,cName);
			dbSetCursor(x+ 100,y);
			dbPrint(amnt*1.0);
			char *cType = &type[0u];
			dbText(x+150,y,cType);
			dbSetCursor(x+ 300,y);
			dbPrint(price*1.0);
		
		if(position==s)
		{


			if(dbReturnKey()==1  ) return 1;

			dbInk(dbRGB(0,255,0),dbRGB(0,0,0));
			
			dbText(x,y,cName);
			dbSetCursor(x+ 100,y);
			dbPrint(amnt*1.0);
			dbText(x+150,y,cType);
			dbSetCursor(x+ 300,y);
			dbPrint(price*1.0);
			dbInk(dbRGB(255,255,255),dbRGB(0,0,0));

		}
			
			return 0;
	}
	void Update()
	{
		if(timer>0) timer--;
		if(dbDownKey()==1 && timer == 0 )
		{

			if(s<items.size())s++;
			if(s>=items.size()) s = 0;
			timer = 10;
		}
		if(dbUpKey()==1 && timer == 0 )
		{
			
			if(s>=0)s--;
			if(s<0) s = items.size();
			timer = 10;
		}
		
		if(dbKeyState(15)==1 && timer==0 && inMenu == false)
		{
			inMenu=true;
			timer=30;
		}
		if(dbKeyState(15)==1 && timer==0 && inMenu == true)
		{
			inMenu=false;
			timer=30;
			dbCLS();
		}
		
		if(inMenu==true)
		{
			
			for(unsigned i =0; i < items.size(); i++)
			{
				items[i]->Update();
			}
			for(unsigned i =0; i < items.size(); i++)
			{
				if(Select(10,i*32,items[i]->get_Name(),items[i]->get_Amount(),items[i]->get_Type(),items[i]->get_Price(),i)==1 && timer==0)
				{
					items[i]->Use();
					if(items[i]->get_Amount()==0) items.erase(items.begin()+i);
					timer = 80;
					dbCLS();
				}
				
			}
		}
	}



protected:
	bool inMenu;
	int timer;
	int s;


};
#endif 

I am only going to post the WeaponItem class

#ifndef WEAPON_H
#define WEAPON_H
class WeaponItem : public Item
{
public:
	WeaponItem(std::string name, std::string type, int amount, int price)
	{
		Item::name = name;
		Item::type = type;
		Item::amount = amount;
		Item::price = price;
		Item::isEquiped = false;
	}
	~WeaponItem()
	{

	}
	virtual void Use()
	{
		Item::Equip();
	}
	virtual void Update()
	{
		//dbText(10,300,"NOOO");
		if(Item::is_Equiped()==true) dbText(10,300,"Is Equiped");
		if(Item::is_Equiped()==false) dbText(10,300,"not Equiped");
	}



protected:


};



#endif 

[RUNNER PRO AGARIO]

Am I blind or do I not see any code ...?

[TarikNeaj]

You are blind, look closer...

[jlb]

std::vector<Item*> items;
Why the pointer?

[RUNNER PRO AGARIO]

oh @TarikNeaj, he didn't have code before, he edited his post.

[TarikNeaj]

@RPA I wrote that before he edited his post and added code, it was sarcasm :p

[RUNNER PRO AGARIO]

oooooooh lol, nice abbreviation for me!!

[NoviceNate333]

jlb when i dont use a pointer i get a ton of errors. Im not sure what would happen if i did it without the pointer its just the way i know works lol. would you suggest something else?

[jlb]

I recommend staying away from pointers unless it is absolutely necessary. And if it is absolutely necessary then you should consider using smart pointers.

when i dont use a pointer i get a ton of errors.

What errors?

[NoviceNate333]

when i use

std::vector<Item> items;

then

 Item item = new WeaponItem(stuff);
items.push_back(item);

I get
\inventory.h(36) : error C2440: 'initializing' : cannot convert from 'WeaponItem *' to 'Item'

[NoviceNate333]

Oh i was not thiking so would this
WeaponItem item(name,type,amount,price,damage,img,health);
be a better idea?

[jlb]

IMO, yes.

[NoviceNate333]

So after some tinkering i have found that it is better to use pointers for the class because with out using pointers you cannot use polymorphism, that i am aware of, this disables the ability to use virtual functions for each item derived from the item class instead when you call

for(i = 0; i < items.size(); i++)
{
items[i].Use(); // this will call Use() from the item class not based on the type of item 
}

and with polymorphism you can do this

for(i = 0; i < items.size(); i++)
{
items[i]->Use(); // this will call Use() from the class that is derived from item with a virtual function 
}