Write in file in file_makeacc() does ove

Forum

Forum
General C++ Programming
Write in file in file_makeacc() does ove

Write in file in file_makeacc() does overwriting to the file even with ios::app

#include<iostream>
#include<fstream>
#include "conio.h" //GCC conio.h
#include<iomanip>
#include<windows.h>

using namespace std;

/* **************************************************
CLASSES
***************************************************** */

class Account
{
public:
int acno;
char name[20];
int amt;
char type;

void makeacc(int ac)
{
acno=ac;
cin.ignore();
cout<<"Enter Name : ";
cin.getline(name,20);
cout<<"Enter Account Type [(C)urrent||(S)avings] : ";
cin>>type;
type=toupper(type);
X:
cout<<"Enter Amount to be deposited [Current(>5000)||Saving(>1000)] :";
cin>>amt;
if(amt<5000)
{
if(type=='C')
{
cout<<"Error . Minimum amount = 5000 \n\n";
cin.ignore();
goto X;
}
else if(type=='S'&& amt<1000)
{
cout<<"Error . Minimum amount = 1000 \n\n";
cin.ignore();
goto X;
}

}
system("cls");

}

void modify(int acno)
{
int flag=0;
char ch,ch2;
cout<<"The Selected account is "<<acno;
cout<<"\nDo you want to modify this account? (Y/N)";
cin>>ch;
if(ch=='y'||ch=='Y')
{
cin.ignore();
cout<<"Update Name ? (Y/N)";
cin>>ch2;
if(ch2=='y'||ch2=='Y')
{
cin.ignore();
cout<<"Enter new name : ";
cin.getline(name,20);
flag=1;

}
cout<<"Update Account Type? (Y/N)";
cin>>ch2;
if(ch2=='y'||ch2=='Y')
{
cout<<"Enter new account type : ";
cin>>type;
type=toupper(type);
flag=1;

}

}

else if(flag==0 && ch=='n' || ch=='N')
{

cout<<"Nothing has been modified. Exiting...Press Any Key... ";
getch();
}
system("cls");
}
void draw(int x)
{
amt-=x;
}
void add(int x)
{
amt-=x;
}
int retacc()
{
return acno;
}
void showacc()
{
cout<<"\n\nAccount Number : ";
cout<<acno;

cout<<"\n\nName : ";
cout<<name;
cout<<"\n\nAccount Type [(C)urrent||(S)avings] : ";

cout<<type;
cout<<"\n\nAmount Deposited : ";
cout<<amt;
}
};
/**END OF CLASS**/

/****function Declarations*****/
void file_makeacc(int);
void file_del(int);
void file_modify(int);
void file_draw(int);
void file_display(int);
void file_deposit(int);
/***End***/

int main()
{
int n,num;

cout<<"\t\t\t\t\tBankersDelight V6.9";

do{

cout<<"\n\n\n1.ADD ACCOUNT ";
cout<<"\n\n2.CLOSE ACCOUNT ";
cout<<"\n\n3.MODIFY ACCOUNT ";
cout<<"\n\n4.WITHDRAWAL ";
cout<<"\n\n5.DEPOSIT ";
cout<<"\n\n6.BALANCE INQUIRY ";
cout<<"\n\n7.EXIT \n";
cout<<"\n\nEnter Choice (1-7) : ";
cin>>n;
system("cls");
switch(n)
{
case 1:
cout<<"\n\nEnter the A/C no : ";
cin>>num;
file_makeacc(num);
break;
case 2:
cout<<"\n\n\tEnter the A/C no. : ";
cin>>num;
file_del(num);
break;
case 3:
cout<<"\n\n\tEnter the A/C no. : ";
cin>>num;
file_modify(num);
break;
case 4:
cout<<"\n\n\tEnter the A/C no. : ";
cin>>num;
file_draw(num);
break;
case 5:
cout<<"\n\n\tEnter the A/C no. : ";
cin>>num;
file_deposit(num);
break;
case 6:
cout<<"\n\n\tEnter the A/C no. : ";
cin>>num;
file_display(num);
case 7:
cout<<"\n\n\tThanks for working with BankersDelightV6.9";
exit(0);

default :cout<<"\nInvalid Input...";
getch();
}

}while(n<7);
return 0;
}

/***********************
FUNCTIONS
***********************/

void file_makeacc(int n)
{
int flag=0;
Account ac;
fstream file,File;
file.open("Accounts.txt",ios::out|ios::binary);
cout<<file.peek();
if(file.peek()!=-1)
{ cout<<"hi";

while(!file.eof())
{

file.read((char *)&ac , sizeof (Account));
cout<<ac.retacc();
if(ac.retacc()==n)
{
cout<<"Same Account Exists ... Re-Enter A/C number! ";
flag=1;
}

}

}
file.close();
if(flag==0)
{
File.open("Accounts.txt",ios::app|ios::in|ios::binary);
ac.makeacc(n);
File.write((char *)&ac , sizeof (Account));
File.close();
}

}

void file_modify(int n)
{
bool flag=false;
Account ac;
fstream file;
file.open("Accounts.txt",ios::in|ios::out|ios::binary);
if(!file)
{
cout<<"No Accounts Found! ";
getch();
}

while(!file.eof()&&flag==false)
{
file.read((char *)&ac , sizeof (Account));

if(ac.retacc()==n)
{
ac.showacc();
getch() ;
cout<<"\n\nEnter New Details\n\n";
ac.modify(n) ;
int pos=-1*(int)(sizeof(Account));
file.seekp(pos,ios::cur);
file.write((char *) &ac, sizeof(Account));
cout<<"\n\nRecord Updated";
flag=true;

}
}
file.close();
if(flag==false)
cout<<"\tAccount not found...";
getch();
system("cls");
}
void file_del(int n)
{
Account ac;
fstream file,file2;
file.open("Accounts.txt",ios::in|ios::binary);
file2.open("Temp.txt",ios::out|ios::binary);

if(!file)
{
cout<<"No Accounts Found! ";
getch();
}
while(!file.eof())
{
file.read((char *)&ac,sizeof(Account));

if(ac.retacc()!=n)
{
file2.write((char *) &ac, sizeof(Account));
}
}
file.close();
file2.close();
remove("Accounts.txt");
rename("Temp.txt","Accounts.txt");
Sleep(1000);
cout<<"Account has been removed! ";
getch();
system("cls");
}
void file_draw(int n)
{
int amt;
Account ac;
fstream file;
file.open("Accounts.txt",ios::in|ios::binary);
if(!file)
{
cout<<"No Accounts Found! ";
getch();
}

while(!file.eof())
{
if(ac.retacc()==n)
{
ac.showacc();
cout<<"Enter the amount to be withdrawn : ";
cin>>amt;
ac.draw(amt);
cout<<"Success!";
getch();
system("cls");
}
}
file.close();
}
void file_deposit(int n)
{
int amt;
Account ac;
fstream file;
file.open("Accounts.txt",ios::in|ios::binary);
if(!file)
{
cout<<"No Accounts Found! ";
getch();
}

while(!file.eof())
{
if(ac.retacc()==n)
{
ac.showacc();
cout<<"Enter the amount to be withdrawn : ";
cin>>amt;
ac.add(amt);
getch();
system("cls");
}
}
file.close();
}
void file_display(int n)
{
Account ac;
int flag=0;
fstream file;
file.open("Accounts.txt",ios::binary|ios::out);
if(!file)
{
cout<<"No Accounts Found! ";
getch();
}
cout<<"\nBALANCE DETAILS\n";

while(file.read((char *)&ac, sizeof(Account)))
{
if(ac.retacc()==n)
{
ac.showacc();
flag=1;
getch();
system("cls");
}
}
file.close();
if(flag==0)
cout<<"\n\nAccount number does not exist!";
}
/******************END OF PROJECT*************************/

CrazyKen (4)

Edit: Seems like using ios::in Solved it , i don't know why, would be grateful if someone told me why.
int flag=0;
Account ac;
fstream file,File;
file.open("Accounts.txt",*ios::in*|ios::out|ios::binary);

shadder (813)

Hi,

when you use fstream you have to define in and out (if you plan on using both simultaneously)

if you are just inputting you may use ifstream and needless to say this goes for outputting too..

just interested which version of gcc are you using?

PS: please use code tags for future posts

http://www.cplusplus.com/articles/jEywvCM9/

CrazyKen (4)

TDM GCC 4.9.2 64bit release
Anyways. If you look i close the file after i opened it just for out i.e file.read...
So why do i need to do both as i open the file again as ios::in when i write

shadder (813)

wait! let me put your code in code tags for my understanding

#include<iostream>
#include<fstream>
#include "conio.h" //GCC conio.h 
#include<iomanip>
#include<windows.h>

using namespace std;

/* **************************************************
CLASSES
***************************************************** */

class Account
{
public:
int acno;
char name[20];
int amt;
char type;


void makeacc(int ac)
{
acno=ac;
cin.ignore();
cout<<"Enter Name : ";
cin.getline(name,20);
cout<<"Enter Account Type [(C)urrent||(S)avings] : ";
cin>>type;
type=toupper(type);
X:
cout<<"Enter Amount to be deposited [Current(>5000)||Saving(>1000)] :";
cin>>amt;
if(amt<5000)
{
if(type=='C')
{
cout<<"Error . Minimum amount = 5000 \n\n";
cin.ignore();
goto X;
}
else if(type=='S'&& amt<1000)
{
cout<<"Error . Minimum amount = 1000 \n\n";
cin.ignore();
goto X;
}

}
system("cls");

}

void modify(int acno)
{
int flag=0;
char ch,ch2;
cout<<"The Selected account is "<<acno;
cout<<"\nDo you want to modify this account? (Y/N)";
cin>>ch;
if(ch=='y'||ch=='Y')
{
cin.ignore();
cout<<"Update Name ? (Y/N)";
cin>>ch2;	
if(ch2=='y'||ch2=='Y')
{	
cin.ignore();
cout<<"Enter new name : ";	
cin.getline(name,20);
flag=1;

}
cout<<"Update Account Type? (Y/N)";
cin>>ch2;
if(ch2=='y'||ch2=='Y')
{
cout<<"Enter new account type : ";
cin>>type;
type=toupper(type);
flag=1;

}

}


else if(flag==0 && ch=='n' || ch=='N')
{

cout<<"Nothing has been modified. Exiting...Press Any Key... ";
getch();	
} 
system("cls");
}
void draw(int x)
{
amt-=x;	
}
void add(int x)
{
amt-=x;	
}
int retacc()
{
return acno;
}
void showacc()
{
cout<<"\n\nAccount Number : ";
cout<<acno;

cout<<"\n\nName : ";
cout<<name;
cout<<"\n\nAccount Type [(C)urrent||(S)avings] : ";

cout<<type;
cout<<"\n\nAmount Deposited : ";
cout<<amt;	
}
};
/**END OF CLASS**/

/****function Declarations*****/
void file_makeacc(int);
void file_del(int);
void file_modify(int);
void file_draw(int);
void file_display(int);
void file_deposit(int);
/***End***/


int main()
{	
int n,num;


cout<<"\t\t\t\t\tBankersDelight V6.9";

do{

cout<<"\n\n\n1.ADD ACCOUNT ";
cout<<"\n\n2.CLOSE ACCOUNT ";
cout<<"\n\n3.MODIFY ACCOUNT ";
cout<<"\n\n4.WITHDRAWAL ";
cout<<"\n\n5.DEPOSIT ";
cout<<"\n\n6.BALANCE INQUIRY ";
cout<<"\n\n7.EXIT \n";
cout<<"\n\nEnter Choice (1-7) : ";
cin>>n;
system("cls");
switch(n)
{
case 1:	
cout<<"\n\nEnter the A/C no : ";
cin>>num;
file_makeacc(num);
break;
case 2:
cout<<"\n\n\tEnter the A/C no. : "; 
cin>>num;
file_del(num);
break;
case 3:
cout<<"\n\n\tEnter the A/C no. : "; 
cin>>num;
file_modify(num);
break;
case 4:
cout<<"\n\n\tEnter the A/C no. : "; 
cin>>num;
file_draw(num);
break;
case 5:
cout<<"\n\n\tEnter the A/C no. : "; 
cin>>num;
file_deposit(num);
break;
case 6:
cout<<"\n\n\tEnter the A/C no. : ";
cin>>num;
file_display(num);
case 7:
cout<<"\n\n\tThanks for working with BankersDelightV6.9";
exit(0);

default :cout<<"\nInvalid Input...";
getch();
}

}while(n<7);
return 0;
}

/***********************
FUNCTIONS
***********************/

void file_makeacc(int n)
{
int flag=0;
Account ac;
fstream file,File;
file.open("Accounts.txt",ios::out|ios::binary);
cout<<file.peek();
if(file.peek()!=-1) 
{	cout<<"hi";

while(!file.eof())
{

file.read((char *)&ac , sizeof (Account));
cout<<ac.retacc();
if(ac.retacc()==n)	
{
cout<<"Same Account Exists ... Re-Enter A/C number! ";
flag=1; 
}

}

}
file.close();
if(flag==0)
{
File.open("Accounts.txt",ios::app|ios::in|ios::binary);
ac.makeacc(n);
File.write((char *)&ac , sizeof (Account));
File.close();
}

}

void file_modify(int n)
{	
bool flag=false;
Account ac;
fstream file;
file.open("Accounts.txt",ios::in|ios::out|ios::binary);
if(!file)
{
cout<<"No Accounts Found! ";
getch();
}

while(!file.eof()&&flag==false)
{
file.read((char *)&ac , sizeof (Account));

if(ac.retacc()==n)
{
ac.showacc(); 
getch()	;	
cout<<"\n\nEnter New Details\n\n";
ac.modify(n) ; 
int pos=-1*(int)(sizeof(Account));
file.seekp(pos,ios::cur);
file.write((char *) &ac, sizeof(Account));
cout<<"\n\nRecord Updated";
flag=true;

}
}
file.close();
if(flag==false)
cout<<"\tAccount not found...";
getch();
system("cls");
}
void file_del(int n)
{
Account ac;
fstream file,file2;
file.open("Accounts.txt",ios::in|ios::binary);
file2.open("Temp.txt",ios::out|ios::binary);

if(!file)
{
cout<<"No Accounts Found! ";
getch();
}
while(!file.eof())
{
file.read((char *)&ac,sizeof(Account));

if(ac.retacc()!=n)
{
file2.write((char *) &ac, sizeof(Account));
}
}
file.close();
file2.close();	
remove("Accounts.txt");
rename("Temp.txt","Accounts.txt");
Sleep(1000);
cout<<"Account has been removed! ";
getch();
system("cls");
}
void file_draw(int n)
{
int amt;
Account ac;
fstream file;
file.open("Accounts.txt",ios::in|ios::binary);
if(!file)
{
cout<<"No Accounts Found! ";
getch();
}

while(!file.eof())	
{
if(ac.retacc()==n)
{
ac.showacc();
cout<<"Enter the amount to be withdrawn : ";
cin>>amt;
ac.draw(amt);	
cout<<"Success!";
getch();
system("cls");	
}
}
file.close();
}
void file_deposit(int n)
{
int amt;
Account ac;
fstream file;
file.open("Accounts.txt",ios::in|ios::binary);
if(!file)
{
cout<<"No Accounts Found! ";
getch();
}

while(!file.eof())	
{
if(ac.retacc()==n)
{
ac.showacc();
cout<<"Enter the amount to be withdrawn : ";
cin>>amt;
ac.add(amt);
getch();
system("cls");	
}
}
file.close();	
}
void file_display(int n)
{
Account ac;
int flag=0;
fstream file;
file.open("Accounts.txt",ios::binary|ios::out);
if(!file)
{
cout<<"No Accounts Found! ";
getch();
}	
cout<<"\nBALANCE DETAILS\n";

while(file.read((char *)&ac, sizeof(Account)))
{
if(ac.retacc()==n)
{
ac.showacc();
flag=1;
getch();
system("cls");
}
}
file.close();
if(flag==0)
cout<<"\n\nAccount number does not exist!";
}
/******************END OF PROJECT*************************/

shadder (813)

could you now point the line number?

CrazyKen (4)

200

Please avoid other func i uploaded this when my program wasn't complete.
But line 200 , that func works fine. I just want to know why it works :P

doug4 (1535)

You open an fstream with the ios::out flag, meaning it is an output stream. Then you do a peek() on it, which is an input stream function. Because you used an fstream, there is a peek() function available, so there won't be a compilation error. I'm not entirely sure what happens when you try to do a peek on an fstream with the ios::out flag set, but it's probably not good.

I would recommend using std::ifstream and std::ofstream whenever possible. There are occasions when you need an fstream (for both read and write), but the function at line 200 is not one of them.

Topic archived. No new replies allowed.

C++

Forum

Write in file in file_makeacc() does overwriting to the file even with ios::app