finding the height of a Binary search tree

[sporx]

my code was working fine until i tried to implement the function to find the height of the tree. any idea where i messed up or a better way of doing this? i need to find the height of both the left and right side so that i can check to see if its balanced or not.
thanks!
-Sporx

#include <iostream>
#include <cstdlib>
using namespace std;
class BinarySearchTree
{
    //private:
    public:
     struct tree_node
        {
           tree_node* left;
           tree_node* right;
           int data;
        };
        tree_node* root;

        BinarySearchTree ()
        {
           root = NULL;
        }
        bool isEmpty() const { return root==NULL; }
        void print_inorder();
        void inorder(tree_node*);
        void insert(int);
int height (tree_node*);

};



// Smaller elements go left
// larger elements go right
void BinarySearchTree::insert(int d)
{
    tree_node* t = new tree_node;
    tree_node* parent;
    t->data = d;
    t->left = NULL;
    t->right = NULL;
    parent = NULL;
  // is this a new tree?
  if(isEmpty()) root = t;
  else
  {
    //Note: ALL insertions are as leaf nodes
    tree_node* curr;
    curr = root;
    // Find the Node's parent
    while(curr)
    {
        parent = curr;
        if(t->data > curr->data) curr = curr->right;
        else curr = curr->left;
    }

    if(t->data < parent->data)
       parent->left = t;
    else
       parent->right = t;
  }
}


void BinarySearchTree::print_inorder()
{
  inorder(root);
}

void BinarySearchTree::inorder(tree_node* p)
{
    if(p != NULL)
    {
        if(p->left) inorder(p->left);
        cout<<" "<<p->data<<" ";
        if(p->right) inorder(p->right);
    }
    else return;
}








int BinarySearchTree::height(tree_node* count){
	int l = 0;
	int r = 0;
cout<<"test";
	if(cout == NULL)
	{
		return 0;
	}
	{
		l = height(count->left);
		r = height(count->right);
		if( l > r || l == r)
		{
			return (l + 1);
		}
		else
		{
			return (r + 1);
		}
	}
cout<<"left is "<<l<<endl<<"right is "<<r<<endl;
}











int main()
{
    BinarySearchTree b;
    int ch,tmp,tmp1;
  int counter=1;
    while(counter==1)
    {
       cout<<endl<<endl;
       cout<<" Binary Search Tree Operations "<<endl;
       cout<<" ----------------------------- "<<endl;
       cout<<" 1. Insertion/Creation "<<endl;
       cout<<" 2. In-Order Traversal "<<endl;
       cout<<" 3. Exit "<<endl;
       cout<<" Enter your choice : ";
       cin>>ch;
       switch(ch)
        {
           case 1 : cout<<" Enter Number to be inserted : ";
                    cin>>tmp;
                    b.insert(tmp);
                    break;
           case 2 : cout<<endl;
                    cout<<" In-Order Traversal "<<endl;
                    cout<<" -------------------"<<endl;
                    b.height();
                    b.print_inorder();
                    break;
           case 3 :
           system("pause");
                    counter=0;

                    break;
       }
    }




}

[maikel]

	if(cout == NULL)
	{
		return 0;
	}

should be

	if(count == NULL)
	{
		return 0;
	}

because cout will never be NULL.


Maikel

[sporx]

thanks for the heads up on the typo!=] i shoulda caught that.. however theres still a problem somewhere, im getting errors on lines 143 stating :
"no matching function call for binarysearchtree::height()",
and line 86, stating
"candidates are: int BinarySearchtree::height(BinarySearchtree::tree_Node*)"

and I dont know what either mean or how to fix them=/ any advice?

[maikel]

b.height(&b);

alternativly do an overload by:

class BinarySearchTree
{
    //private:
    public:
     struct tree_node
        {
           tree_node* left;
           tree_node* right;
           int data;
        };
        tree_node* root;

        BinarySearchTree ()
        {
           root = NULL;
        }
        bool isEmpty() const { return root==NULL; }
        void print_inorder();
        void inorder(tree_node*);
        void insert(int);
        int height (tree_node*);
        int height () { return height(this); } // OVERLOAD
};

Maikel