C++

Forum

 
 
Linked Lists

swaveysaiyan (11)
I can't figure out what I am doing wrong

I'm following an example but I keep getting errors the ones I can see are in my linkeList.cpp file.
I can't figure out what I am doing wrong

I'm following an example but I keep getting errors the ones I can see are in my linkeList.cpp file.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
 
//main.cpp
#include "header.h"
#include "linkedList.cpp"

int main()
{
   cout << "*************************PROGRAM*********************************";
   cout << "\nFind and Delete the node with the smallest info in the list and"
       << "\nFind and Delete all occurrences of a given info from the list .";
  
   unorderedLinkedList<int> myList;
  
   cout << "\n\nInserting random numbers into the list.";
   myList.insertFirst(3);
   myList.insertFirst(15);
   myList.insertFirst(22);
   myList.insertLast(1);
   myList.insertFirst(31);
   myList.insertFirst(48);
   myList.insertFirst(57);
   myList.insertFirst(87);
   myList.insertFirst(67);
   cout << "\n\n\tThe elements in the list : ";
   myList.print();
   
   cout << "\n\tDeleting all occurrences of the smallest element.";
   myList.deleteAllSmall();
  
   cout << "\n\n\tThe elements in the list : ";
   myList.print();
  
   cout << "\n\tDeleting first occurrence of the smallest element.";
   myList.deleteSmallest();
  
   cout << "\n\n\tThe elements in the list : ";
   myList.print();
   cout << "\n\n\t";
   
   system("pause");
   return 0;
}
//header.h
#include<iostream>
using std::cout;
using std::cin;
#ifndef H_NodeType
#define H_NodeType
template<class Type>
struct nodeType
{
   Type info;
   nodeType<Type> *link;
};
#endif


template <class Type>
class linkedListIterator
{
public:
   
   linkedListIterator();
  
   linkedListIterator(nodeType<Type> *ptr);
   Type operator*();

  linkedListIterator<Type> operator++();
  bool operator==(const linkedListIterator<Type> &right) const;
  bool operator!=(const linkedListIterator<Type> &right) const;

private:
   
   nodeType<Type> *current;
};


template<class Type>
linkedListIterator<Type>::linkedListIterator()
{
   current = NULL;
}
template<class Type>
linkedListIterator<Type>::linkedListIterator
(nodeType<Type> *ptr)
{
   current = ptr;
} 
template<class Type>
Type linkedListIterator<Type>::operator*()
{
   return current->info;
} 

template<class Type>
linkedListIterator<Type> linkedListIterator<Type>::operator++()
{
   current = current->link;
   return *this;
} 
template<class Type>
bool linkedListIterator<Type>::operator==(const linkedListIterator<Type>& right) const
{
   return (current == right.current);
} 
template<class Type>
bool linkedListIterator<Type>::operator!=(const linkedListIterator<Type>& right) const
{
   return (current != right.current);
}




Last edited on
swaveysaiyan (11)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
 
//linkedList.cpp

template<class Type>
void linkedListType<Type>::print() const
{
   nodeType<Type> *current;

   current = first;

   while (current != NULL)

   {
     cout << current->info << " ";
     current = current->link;
 }

} 

template<class Type>
int linkedListType<Type>::length() const
{
   return count;
} 
template<class Type>

void linkedListType<Type>::destroyList()

{

   nodeType<Type> *temp;

   while (first != NULL)

   { temp = first;
      first = first->link;
      delete temp;
} 
    last = NULL;
    count = 0;

} 

template<class Type>

Type linkedListType<Type>::front() const

{

   assert(first != NULL);
   return first->info;

} 

template<class Type>

Type linkedListType<Type>::back() const

{

   assert(last != NULL);
    return last->info;

} 

template<class Type>

linkedListIterator<Type> linkedListType<Type>::begin()

{

   linkedListIterator<Type> temp(first);

   return temp;

} 

template<class Type>

linkedListIterator<Type> linkedListType<Type>::end()

{
   linkedListIterator<Type> temp(NULL);
   return temp;

} 

template<class Type>

linkedListType<Type>::~linkedListType()

{

   destroyList();

}

template <class Type>

void linkedListType<Type>::copyList

(const linkedListType<Type>& otherList)

{

   nodeType<Type> *newNode;

   nodeType<Type> *current;

   if (first != NULL)

       destroyList();

   if (otherList.first == NULL)

   {

       first = NULL;

       last = NULL;

       count = 0;

   }

   else

   {
       current = otherList.first;
       count = otherList.count;
       first = new nodeType<Type>;
       first->info = current->info;
       first->link = NULL;
       last = first;
       current = current->link;
       
      while (current != NULL)
       {
           newNode = new nodeType<Type>;
           newNode->info = current->info;
           newNode->link = NULL;
           last->link = newNode;
           last = newNode;
           current = current->link;
       } 
   } 
} 

template <class Type>
class unorderedLinkedList : public linkedListType<Type>
{

public:

   bool search(const Type& searchItem) const;
   void insertFirst(const Type& newItem;
   void insertLast(const Type& newItem);
   void deleteNode(const Type& deleteItem);
   void deleteSmallest();
   void deleteAllSmall();
}; 
template <class Type>
bool unorderedLinkedList<Type>::search(const Type& searchItem) const
{
   nodeType<Type> *current;
   current = first;
   while (current != NULL)
       if (current->info == searchItem)
           return true;
       else
           current = current->link;
   return false;
} 


template <class Type>
void unorderedLinkedList<Type>::insertFirst(const Type& newItem)
{

   nodeType<Type> *newNode;
   newNode = new nodeType<Type>;
   newNode->info = newItem;
    newNode->link = first;

   first = newNode;
   count++;
   if (last == NULL)
    last = newNode;

}

template <class Type>

void unorderedLinkedList<Type>::insertLast(const Type& newItem)

{

   nodeType<Type> *newNode;

   newNode = new nodeType<Type>;

   newNode->info = newItem;

   newNode->link = NULL;
   if (first == NULL)
   {

       first = newNode;

       last = newNode;

       count++;

   }

   else

   {

       last->link = newNode;

       last = newNode;

       count++;

   } 

} 

template <class Type>

void unorderedLinkedList<Type>::deleteNode

(const Type& deleteItem)

{
   nodeType<Type> *current;

  

   nodeType<Type> *trailCurrent;

  

   bool found;

   if (first == NULL)

       cout << "\n\tCannot delete from an empty list.";

   else

   {

       if (first->info == deleteItem)

       {

           current = first;

           first = first->link;

           count--;

           if (first == NULL)

               last = NULL;

           delete current;

       }

       else 

       {

           found = false;

           trailCurrent = first;
           current = first->link;
           while (current != NULL && !found)
           {

               if (current->info != deleteItem)

               {

                   trailCurrent = current;
                   current = current->link;

               }

               else

                   found = true;

           }

           if (found)

           {
             trailCurrent->link = current->link;
             count--;
                if (last == current)
                  last = trailCurrent;
                  delete current;
           }

           else

               cout << "\n\tThe item to be deleted is" << "not in the list.";

       } 

   }

} 

template <class Type>

void unorderedLinkedList<Type>::deleteSmallest()

{

 if (first == NULL)

   {

       cout << "\n\tThere were no elements in the list to delete.";

       return;

   } 


   nodeType<Type> *current;

   current = first;

   Type item = current->info;
   
   current = current->link;

  while (current != NULL)
   {
       if (item > current->info)
           item = current->info;
       current = current->link;
   } 


   deleteNode(item);

} 

template <class Type>

void unorderedLinkedList<Type>::deleteAllSmall()
{
   
   {
       cout << "\n\tThere were no elements in the list to delete.";
       return;

   } 

  nodeType<Type> *current;

   current = first;

   Type item = current->info;

   int count = 1;
   
   current = current->link;

   while (current != NULL)
   {
       
       if (current->info == item)
           count++;
       
       if (item > current->info)
       {
           item = current->info;
           count = 1;
       } 
       current = current->link;
   }   
   deleteNode(item);
}
ne555 (10692)
¿where's linkedListType class definition?
swaveysaiyan (11)
I thought it was covered in this code here 


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
 
template<class Type>
class linkedListType
{
public:
   linkedListType();
   linkedListType(const linkedListType<Type>& otherList);
   const linkedListType<Type>& operator=(const linkedListType<Type>&);
   void initializeList();
   bool isEmptyList() const;
   void print() const;
   int length() const;
   void destroyList();
   Type front() const;
   Type back() const;
   virtual bool search(const Type& searchItem) const = 0;
   virtual void insertFirst(const Type& newItem) = 0;
   virtual void insertLast(const Type& newItem) = 0;
   virtual void deleteNode(const Type& deleteItem) = 0;
   virtual void deleteSmallest() = 0;
   virtual void deleteAllSmall() = 0;
   linkedListIterator<Type> begin();
   linkedListIterator<Type> end();
   ~linkedListType();
protected:
   int count;
   nodeType<Type> *first;
   nodeType<Type> *last;
private:
   void copyList(const linkedListType<Type>& otherList);
};
ne555 (10692)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
 
template <class Type>
class unorderedLinkedList : public linkedListType<Type>
{

public:

   bool search(const Type& searchItem) const;
   void insertFirst(const Type& newItem); //<--there was a missing closing parenthesis
   void insertLast(const Type& newItem);
   void deleteNode(const Type& deleteItem);
   void deleteSmallest();
   void deleteAllSmall();


protected:
   using linkedListType<Type>::first;
   using linkedListType<Type>::last;
   using linkedListType<Type>::count;
};

or use this->first when refering to it
https://stackoverflow.com/questions/3799495/template-inheritance-c


missing these definitions 
1
2
 
linkedListType();
linkedListType(const linkedListType<Type>& otherList);


~linkedListType(); make it virtual

and in deleteNode 
298
299
300
301
302
303
304
305
306
 
           if (found)

           {
             trailCurrent->link = current->link;
             count--;
                if (last == current)
                  last = trailCurrent;
                  delete current; //bad indentation
           }
Last edited on
swaveysaiyan (11)
after what you said to fix I am now getting new errors I will put them in second comment so it is not to much in one reply


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
 
template<class Type>
class linkedListType
{
public:
   linkedListType();
   linkedListType(const linkedListType<Type>& otherList); //these definitions were already 
   //here  unless you ment they also had to  be some where else as well 
  
   const linkedListType<Type>& operator=(const linkedListType<Type>&);
  
   void initializeList();
   
   bool isEmptyList() const;
 
   void print() const;
   
   int length() const;
   void destroyList();
   Type front() const;
   Type back() const;
   virtual bool search(const Type& searchItem) const = 0;
   virtual void insertFirst(const Type& newItem) = 0;
   virtual void insertLast(const Type& newItem) = 0;
   virtual void deleteNode(const Type& deleteItem) = 0;
   virtual void deleteSmallest() = 0;
   virtual void deleteAllSmall() = 0;
   linkedListIterator<Type> begin();
   linkedListIterator<Type> end();
   virtual ~linkedListType();

   
protected:
   int count;
   nodeType<Type> *first;
   nodeType<Type> *last;
private:
   void copyList(const linkedListType<Type>& otherList);
};
swaveysaiyan (11)
exit status 1
In file included from linkedList.cpp:1,
from main.cpp:2:
header.h:16:7: error: redefinition of 'class linkedListIterator<Type>'
class linkedListIterator
^~~~~~~~~~~~~~~~~~
In file included from main.cpp:1:
header.h:16:7: note: previous definition of 'class linkedListIterator<Type>'
class linkedListIterator
^~~~~~~~~~~~~~~~~~
In file included from linkedList.cpp:1,
from main.cpp:2:
header.h:40:1: error: redefinition of 'linkedListIterator<Type>::linkedListIterator()'
linkedListIterator<Type>::linkedListIterator()
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from main.cpp:1:
header.h:40:1: note: 'linkedListIterator<Type>::linkedListIterator()' previously declared here
linkedListIterator<Type>::linkedListIterator()
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from linkedList.cpp:1,
from main.cpp:2:
header.h:45:1: error: redefinition of 'linkedListIterator<Type>::linkedListIterator(nodeType<Type>*)'
linkedListIterator<Type>::linkedListIterator
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from main.cpp:1:
header.h:45:1: note: 'linkedListIterator<Type>::linkedListIterator(nodeType<Type>*)' previously declared here
linkedListIterator<Type>::linkedListIterator
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from linkedList.cpp:1,
from main.cpp:2:
header.h:51:6: error: redefinition of 'Type linkedListIterator<Type>::operator*()'
Type linkedListIterator<Type>::operator*()
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from main.cpp:1:
header.h:51:6: note: 'Type linkedListIterator<Type>::operator*()' previously declared here
Type linkedListIterator<Type>::operator*()
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from linkedList.cpp:1,
from main.cpp:2:
header.h:57:26: error: redefinition of 'linkedListIterator<Type> linkedListIterator<Type>::operator++()'
linkedListIterator<Type> linkedListIterator<Type>::operator++()
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from main.cpp:1:
header.h:57:26: note: 'linkedListIterator<Type> linkedListIterator<Type>::operator++()' previously declared here
linkedListIterator<Type> linkedListIterator<Type>::operator++()
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from linkedList.cpp:1,
from main.cpp:2:
header.h:63:6: error: redefinition of 'bool linkedListIterator<Type>::operator==(const linkedListIterator<Type>&) const'
bool linkedListIterator<Type>::operator==(const linkedListIterator<Type>& right) const
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from main.cpp:1:
header.h:63:6: note: 'bool linkedListIterator<Type>::operator==(const linkedListIterator<Type>&) const' previously declared here
bool linkedListIterator<Type>::operator==(const linkedListIterator<Type>& right) const
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from linkedList.cpp:1,
from main.cpp:2:
header.h:68:6: error: redefinition of 'bool linkedListIterator<Type>::operator!=(const linkedListIterator<Type>&) const'
bool linkedListIterator<Type>::operator!=(const linkedListIterator<Type>& right) const
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from main.cpp:1:
header.h:68:6: note: 'bool linkedListIterator<Type>::operator!=(const linkedListIterator<Type>&) const' previously declared here
bool linkedListIterator<Type>::operator!=(const linkedListIterator<Type>& right) const
^~~~~~~~~~~~~~~~~~~~~~~~
MikeyBoy (5631)
Do you have multiple inclusion guards in your header files?
Topic archived. No new replies allowed.