Sorted List deleteItem & insertItem not working

[elsa]

Hello. My deleteItem and insertItem functions are not working: when you try to delete an item from the array it says "the item is not in the list"...and when you try to insert an item, it does nothing but spit back 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 back to you when the display function is called. Any help would be appreciated in figuring this out. I believe the linear and binary search functions are OK, for what it's worth. Thank you.

#pragma once
#include <iostream>
#include <string>
#include "SortedList.h"
using namespace std;

SortedList::SortedList()
{
	length = 0;
}

SortedList::~SortedList() {}

int SortedList::linearSearch(int item)
{
	int location = 0;
	while ((item >= numbers[length]) && (location < length))
	location++;
	return location;
}

void SortedList::insertItem(int item)
{
	int location = 0;
	location = linearSearch(item);

	numbers[length] = location;
	length++;
}

int SortedList::binarySearch(int item)
{
	int first = 0;
	int midpoint = 0;
	int last = length - 1;

	while (true)
	{
		if (first > last)
		{
			return first;
		}

		midpoint = (first + last) / 2;

		if (item == numbers[midpoint])
		{
			return midpoint;
		}

		else if (item > numbers[midpoint])
		{
			first = (midpoint + 1);
		}

		else if (item < numbers[midpoint])
		{
			last = (midpoint - 1);
		}
	}
}

void SortedList::deleteItem(int item)
{

	int location = 0;
	location = binarySearch(item);

	while (item != numbers[location] && location < length)
	location++;
	if (location < length)
	{
		numbers[location] = numbers[length - 1];
		length--;
		cout << "The item has been deleted." << endl;
	}
	else
	{
		cout << "The number is not in the list." << endl;
	}
}

bool SortedList::isFull() const
{
	return (length == MAX_SIZE);
}

bool SortedList::isEmpty() const
{
	return (length == 0);
}

void SortedList::displayList() const
{
	int location = 0;
	if (location < length)
	{
		while (location < length)
		{
			cout << numbers[location] << endl;
			location++;
		}
	}
	else
		cout << "List is empty." << endl;
}

void SortedList::showMenu()
{
	cout << "a. Insert a number into the list." << endl;
	cout << "b. Delete a number from the list." << endl;
}

[ne555]

void SortedList::insertItem(int item)
{
	int location = 0;
	location = linearSearch(item);

	numbers[length] = location; //¿? ¿why do you store `location'?
	length++;
}

void SortedList::deleteItem(int item)
{

	int location = 0;
	location = binarySearch(item);

	while (item != numbers[location] && location < length) //¿what for?
		location++;
	if (location < length)
	{
		numbers[location] = numbers[length - 1]; //good bye, sorted property
		length--;
		cout << "The item has been deleted." << endl;
	}
	else
	{
		cout << "The number is not in the list." << endl;
	}
}

[elsa]

Hey I think my code right now is not executing from line 18 and skipping to the else statement. What should I do so that I don't say "good bye" to the sorted property?

Also I deleted the while loop and the location++ without any problems so I think you were right.

What should I store instead of location?

[elsa]

I updated my code, but it's not displaying the right deleted number and not putting things in ascending order. How can I fix that? Thanks for the help...anyone?

#include <iostream>
#include <string>
#include "SortedList.h"
using namespace std;

SortedList::SortedList()
{
	length = 0;
}

SortedList::~SortedList() {}

int SortedList::linearSearch(int item)
{
	int location = 0;
	while ((item >= numbers[length]) && (location < length))
	location++;
	return location;
}

void SortedList::insertItem(int item)
{
	int location = 0;
	location = linearSearch(item);

	for (int i = length; i > location; i--)
	{
		numbers[i] = numbers[i - 1];
	}
	numbers[location] = item;
	length++;
}

int SortedList::binarySearch(int item)
{
	int first = 0;
	int midpoint = 0;
	int last = length - 1;

	while (true)
	{
		if (first > last)
		{
			return first;
		}

		midpoint = (first + last) / 2;

		if (item == numbers[midpoint])
		{
			return midpoint;
		}

		else if (item > numbers[midpoint])
		{
			first = (midpoint + 1);
		}

		else if (item < numbers[midpoint])
		{
			last = (midpoint - 1);
		}
	}
}

void SortedList::deleteItem(int item)
{

	int location = 0;
	location = binarySearch(item);

	if (location < length) {
		for (int i = location + 1; i < length; i++)
		{
			numbers[i - 1] = numbers[i];
		}
		length--;
		cout << "The item has been deleted." << endl;
	}
	else {
		cout << "Item is not in the list." << endl;
	}
	
}


bool SortedList::isFull() const
{
	return (length == MAX_SIZE);
}

bool SortedList::isEmpty() const
{
	return (length == 0);
}

void SortedList::displayList() const
{
	int location = 0;
	if (location < length)
	{
		while (location < length)
		{
			cout << numbers[location] << endl;
			location++;
		}
	}
	else
		cout << "List is empty." << endl;
}

void SortedList::showMenu()
{
	cout << "a. Insert a number into the list." << endl;
	cout << "b. Delete a number from the list." << endl;
}

[ne555]

int SortedList::linearSearch(int item)
{
	int location = 0;
	while ((item >= numbers[length]) && (location < length))
	location++;
	return location;
}

test your functions
you check `item' against the same element several times. Moreover, that element (numbers[lenght]) is invalid, as it is outside the "used" range

if the item is not present, `binarySearch()' returns a value that is indistinguishable of a found case.