Random Number???

[Cole99]

Hi. I have used random numbers so many times but I'm confused. It gives me the same number every time. What should I do to fix it. I used the srand(time(0))!!!

My Code:

#include <iostream>
#include <cstdlib>
#include <ctime>

using namespace std;

int main()
{
    srand(time(0));

    int playerHP = 100;
    int cpuHP = 100;
    int playerChoice;
    int playerDamage = rand() % 50 + 1;
    int cpuChoice = rand() % 3 + 1;
    int cpuDamage = rand() % 40 + 1;

    string name;
    string opponent;

    cout << "Enter Name:" << endl;
    cin >> name;
    cout << endl;

    cout << "Enter Opponent:" << endl;
    cin >> opponent;
    cout << endl;

    cout << "Hello and welcome! Today, " << name << " will battle against " << opponent << "." << endl;
    cout << endl;

    while(playerHP > 0 && cpuHP > 0){
        cout << "Choose one of the following moves:" << endl;
        cout << "1) Jab" << endl;
        cout << "2) Uppercut" << endl;
        cout << "3) Hook" << endl;
        cin >> playerChoice;

        if(playerChoice == 1){
            cout << "You chose Jab and dealed " << playerDamage << " damage!" << endl;
            cpuHP = cpuHP - playerDamage;
        }
        else if(playerChoice == 2){
            cout << "You chose Uppercut and dealed " << playerDamage << " damage!" << endl;
            cpuHP = cpuHP - playerDamage;
        }
        else if(playerChoice == 3){
            cout << "You chose Hook and dealed " << playerDamage << " damage!" << endl;
            cpuHP = cpuHP - playerDamage;
        }
        cout << cpuHP << endl << endl << endl;
    }
}

[Mats]

You are generating the random numbers only once. They need to be in the while loop to generate a new one very time.

Btw, it should also be 'dealt' rather than 'dealed'. ;)

[Cole99]

ok thx but can u take my code and copy and paste it in to a comment. and just edit the stuff that i need to do?

[Cole99]

NVM i got it!