### Converting Integers into Words problem.

Hello, I wrote this program, and it runs fine until you go into the thousands. Then things get messed up. Here is the code:

 ``123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351`` ``````//assign_1_12_numberestowords.cpp //Dishant Patel // //This program will take a number of maximum 5 digits, postive or negative, and display the number written out in words. #include using namespace std; int main() { cout << "Please enter an integer" << endl; int num, numhund, numthou, numtenthou, numhundthou, numten;//the number is split into different values that represent each digit cin>>num; if (num<0)//ensures that if num is nugative, then it mentions that { cout<<"negative "; num=-num; } numhundthou=num/100000; num=num%100000; numtenthou=num/10000; if (numtenthou<2) { numthou=num%100; } else { num=num%10000; numthou=num/1000; } num=num%1000; numhund=num/100; num=num%100; numten=num/10; if (numten>2) { num=num%10; } if((numthou!=0)||(numhundthou!=0)||(numtenthou!=0)) { if (numhundthou!=0) { switch (numhundthou)//Case Values begin. { case 1: cout<<"one "; break; case 2: cout<<"two "; break; case 3: cout<<"three "; break; case 4: cout<<"four "; break; case 5: cout<<"five "; break; case 6: cout<<"six "; break; case 7: cout<<"seven "; break; case 8: cout<<"eight "; break; case 9: cout<<"nine "; break; } cout<<"hundred " << endl; } if ((numtenthou>=1)&&(numtenthou<=9)) { switch (numtenthou) { case 2: cout<<"twenty "; break; case 3: cout<<"thirty "; break; case 4: cout<<"forty "; break; case 5: cout<<"fifty "; break; case 6: cout<<"sixty "; break; case 7: cout<<"seventy "; break; case 8: cout<<"eighty "; break; case 9: cout<<"ninety "; break; cout<<" "; break; } switch (numthou) { case 1: cout<<"one "; break; case 2: cout<<"two "; break; case 3: cout<<"three "; break; case 4: cout<<"four "; break; case 5: cout<<"five"; break; case 6: cout<<"six "; break; case 7: cout<<"seven "; break; case 8: cout<<"eight "; break; case 9: cout<<"nine "; break; cout<<" "; break; } cout<<"thousand "; } if ((numtenthou!=0)&&(numtenthou<2)) { switch(numthou) { case 1: cout<<"one "; break; case 2: cout<<"two "; break; case 3: cout<<"three "; break; case 4: cout<<"four "; break; case 5: cout<<"five "; break; case 6: cout<<"six "; break; case 7: cout<<"seven "; break; case 8: cout<<"eight "; break; case 9: cout<<"nine "; break; case 10: cout<<"ten "; break; case 11: cout<<"eleven "; break; case 12: cout<<"twelve "; break; case 13: cout<<"thirteen "; break; case 14: cout<<"fourteen "; break; case 15: cout<<"fifteen "; break; case 16: cout<<"sixteen "; break; case 17: cout<<"seventeen "; break; case 18: cout<<"eighteen "; break; case 19: cout<<"nineteen "; break; cout<<" "; break; } cout<<"thousand "; } } if(numhund!=0) { switch (numhund) { case 1: cout<<"one "; break; case 2: cout<<"two "; break; case 3: cout<<"three "; break; case 4: cout<<"four "; break; case 5: cout<<"five "; break; case 6: cout<<"six "; break; case 7: cout<<"seven "; break; case 8: cout<<"eight "; break; case 9: cout<<"nine "; break; cout<<" "; } cout<<"hundred "; } if ((numten>=2)&&(numten<=9)) { switch (numten) { case 1: cout<<"ten "; break; case 2: cout<<"twenty "; break; case 3: cout<<"thirty "; break; case 4: cout<<"forty "; break; case 5: cout<<"fifty "; break; case 6: cout<<"sixty "; break; case 7: cout<<"seventy "; break; case 8: cout<<"eighty "; break; case 9: cout<<"ninety "; break; cout<<" "; break; } switch (num) { case 1: cout<<"one "; break; case 2: cout<<"two "; break; case 3: cout<<"three "; break; case 4: cout<<"four "; break; case 5: cout<<"five "; break; case 6: cout<<"six "; break; case 7: cout<<"seven "; break; case 8: cout<<"eight "; break; case 9: cout<<"nine "; break; cout<<" "; break; } } if ((num>=10)&&(num<=19)) { switch (num) { case 10: cout<<"ten "; break; case 11: cout<<"eleven "; break; case 12: cout<<"twelve "; break; case 13: cout<<"thirteen "; break; case 14: cout<<"fourteen "; break; case 15: cout<<"fifteen "; break; case 16: cout<<"sixteen "; break; case 17: cout<<"seventeen "; break; case 18: cout<<"eighteen "; break; case 19: cout<<"nineteen "; break; } } return 0; } ``````

If someone figures out my mistake, please tell me. This is an assignment and I have been working on it for a day now, and its due tomorrow. Please help.

The idea that you break a number up into its pieces using the remainder and division operators was smart. However, you missed the part about not repeating code.

When you find yourself doing the same thing over and over again, look into loops, functions, and arrays.

To help you out, try writing out the numbers from one to one hundred and see if you can catch any patterns there. (Hint, the only exceptions occur when the tens place is '1'.)

Once you get the groups of three working, then you can start working on powers of 103. How you do it depends on what scale you are using.
http://en.wikipedia.org/wiki/Names_of_large_numbers

Again, you will need a counter and an array.

Post back with how far you get.
Last edited on
Thank you for your reply Duoas, and I know what you mean, infact, a student asked the same thing, but the teacher wants us to do it this way so we can get our cases, breaks, and if statements pat down. If you could please tell me where the problem exists in line numbers, that would be great, because I looked it over many times, and everything looks good.

Your teacher doesn't belong to be teaching. Give me a little to look your code over.
Haha. I hope you can help me out in the future, because I have the same opinion :/ . I hope we can stay in touch in the future.
OK, so you have a couple of simple problems.

The first is all the conditions you are adding to to splitting the number up. Don't do that. Just go through a straightforward assignment of everything:

 ``12345`` `````` numhundthou=num/100000; num=num%100000; numtenthou =num/ 10000; num=num% 10000; numthou =num/ 1000; num=num% 1000; numhund =num/ 100; num=num% 100; numten =num/ 10; num=num% 10;``````

At this point, I would do a little processing of your values to help in the switches. Since the special cases occur when the tens place is one, just fix it thus:

 ``12345`` `````` if (numtenthou==1) { numtenthou=0; numthou+=10; }``````

Do you see the trick? Don't forget to handle 'numten' and 'num' the same way.

Now that you have a definite value for each of the decimal places (even if that value is zero), you can go through like you want. You only need to check to see that the item you are printing is not zero.

 ``1234567891011121314151617181920212223`` `````` switch (numhundthou) { case 1: cout<<"one hundred "; break; ... case 9: cout<<"nine hundred "; break; } switch (numtenthou) { case 2: cout<<"twenty "; break; ... case 9: cout<<"ninety "; break; } switch (numthou) { case 1: cout<<"one "; break; ... case 9: cout<<"nine "; break; case 10: cout<<"ten "; break; ... case 19: cout<<"nineteen "; break; } if ((numhundthou != 0) || (numtenthou != 0) || (numthou != 0)) cout<<"thousand ";``````

And so on.

Hope this helps.

When you are done with this, let me know and I've got some fun links for you.
OK my friend. Thanks SO MUCH. I finally realized my mistake and it works perfectly. I'll send you a test case in a few, just gotta clean some stuff up.
Make sure you test for all the odd cases.
123456
213456
103456
120456
23456
etc

 ``123456789101112`` ``````This program will write a number up to 6 digits in words. Press Enter to continue. Please enter the 6 digits. 1000000 That is an invalid entry. Please enter a valid number. Only 6 digits please. -1000000 This is an invalid entry. Please enter a valid number. Only 6 digits please. 987541 Nine Hundred Eighty Seven Thousand Five Hundred Forty One Process returned 0 (0x0) execution time : 17.361 s Press any key to continue.``````