Need help with Constructor

[ferigs911]

Class:

class Student
{
	private:
		string name;
		int id;
		int *test;
		int num;
		void makeArray();
	public:
		Student();
		Student(int n);
		Student(string nm, int i, int n);
		void setName(string nm);
		void setID(int i);
		void setScore(int i, int s);
		string getName() const;
		int getID() const;
		void showScore();
		void display();
		~Student();			
};

Constructor:

void Student::makeArray()
{
	int size = Student::num;
	int *studentArray;
	studentArray = new int[num];
	Student::test = studentArray;

	test = 0;
}

I have spent the last few hours getting it down to the error in my code being something to do with the constructor. The constructor should dynamically allocate an int array with num elements, assigns the address of the array to
test, and assigns 0 to all the elements.

i need help very badly. PLEASE HELP ME!!!

[freddy92]

test = 0; does not assign 0 to all elements. It assigns 0 to test, effectively whiping out the address of the array that was put in there. You need to use a for loop. Something like this:

for (int i = 0; i < size; i++)
    test[i] = 0;

[ferigs911]

So now i have the constructor looking like

void Student::makeArray()
{
	int size = Student::num;
	int *studentArray;
	studentArray = new int[num];
	Student::test = studentArray;

	for (int i = 0; i < size; i++)
		test[i] = 0;
}

should that work, or was i suppose to put the loop somewhere else?

because i am still getting the same error as before :(

would it be helpful if i posted my whole code?

[D80DSL3A]

That is not the constructor. That is some other function.
Are you calling makeArray() from the constructor?


What is the actual error you are getting?

Also, a lot of that mumbo-jumbo with the local variables in makeArray() could be eliminated:

void Student::makeArray()
{
	test = new int[num];
	for (int i = 0; i < num; i++)
		test[i] = 0;
}

[ferigs911]

I figured it out, thanks for the help guys it had to do with the ACTUAL contructor, thought makeArray was the constructor but i needed to call makeArray in the constructor.

Thanks for the help :D