Insertion Sort algorithm - list of names

[sephiroth1134]

I am trying to use an insertion sort algorithm to sort out a list of names inputted by the user in the command line prompt. This code compiles and runs just fine, however when I try to get the sorting in order and reverse order, something must be missing because the order is all wrong. Somewhere in the while loop something is missing. Below is my code:

#include <stdio.h>
#include <string.h>
#include <stdlib.h>

void print_array( char **, int);
void insertion_sort( char **, int );
void reverse_sort( char **, int );

char ** names;

int main( int argc, char * argv[] )
{
   names = (char**) malloc(sizeof(char*) * argc );
  
   if( argc == 1 )
   {
      printf( "Please include a list of names\n!" ); 
      return 0;
   }

   for( int i = 1; i < argc; i++)
   {
        names[ i - 1 ] = argv[ i ];
   }
   
    printf( "Before sort:\n" );
    print_array( names, argc - 1 );

    printf( "In order:\n" );
    insertion_sort( names, argc - 1 );
    print_array( names, argc - 1 );

    printf( "In reverse order:\n" );
    reverse_sort( names, argc - 1 );
    print_array( names, argc - 1 );

    getchar();
    return 0;
}

void print_array( char ** array, int size )
{
    int i = 0;
    for( i = 0; i < size; i++ )
    {
      printf( "%d %s\n", i + 1, array[ i ] );
    }
}

void insertion_sort( char ** array, int size )
{
    int i = 0;
    int j = 0;
    char * name;
    for( i = 0; i < size; i++ )
    {
        name = array[ i ];
        j = i - 1;
        while( j >= 0 && strcmp(array[ j ], array[ j + 1 ]) > 0 )
        {
            array[ j + 1 ] = array[ j ];
            j = j - 1;
        }
        array[ j + 1 ] = name;
    }
}

void reverse_sort( char ** array, int size )
{
    int i = 0;
    int j = 0;
    char * name;
    for( i = 0; i < size; i++ )
    {
        name = array[ i ];
        j = i - 1;
        while( j >= 0 && strcmp(array[ j ], array[ j + 1 ]) < 0 )
        {
            array[ j + 1 ] = array[ j ];
            j = j - 1;
        }
        array[ j + 1 ] = name;
    }
}

The output is as follows:

Before sort:
carl
tom
bob
In order:
carl
bob
tom
Reverse order:
carl
tom
bob

Ideas?

[helios]

The right hand operand for the comparison function should be the element you're trying to insert, not the element you just shifted forward.

[sephiroth1134]

Thanks very much, helios. It took me a bit of time to find out which element you were talking about. Once I figured it out, I felt like a dope. Thanks for helping clear up this issue. It was driving me nuts!