C++

Forum

 
Help my Computer Tic Tac toe is not working.

TananTanTananTanToink (11)
// Computer Tic tac toe,

// Include the iostream library
#include <iostream>
#include <string>
#include <ctime>

// Using the standard namespace
using namespace std;
// declare global variables
char Board [9];

// Declare Functions
void showBoard ( );
bool moveIsValid (int m );
int whoWon(); // Returns 0 if no one has won,1 if player 1 has won, 2 if player 2 has won
void main ( )
{

// Seed the random number
srand (time (NULL) );

// Declare Global Variables
string Player_1_name;
string Player_2_name;
int Whose_Turn = 1; // 1 means players turn and 2 means player 2 turns
int Move; // Store where the players wants to move
int Total_Moves = 0;
int num_players = 0;


// Assigns values to the playing board
Board[0] = '0';
Board[1] = '1';
Board[2] = '2';
Board[3] = '3';
Board[4] = '4';
Board[5] = '5';
Board[6] = '6';
Board[7] = '7';
Board[8] = '8';


// Give Choise to play 2 player or against computer
cout << "Welcome to Tic Tac Toe.\n Enter 1 for 1 player or 2 for 2 player" << endl;

if (num_players == 1)
{
//Get PLayer Names
cout << " Player 1: Please enter your name " << endl;
cin >> Player_1_name;

while (whoWon ( ) ==0 && Total_Moves < 9)
{
do
{
// Show the board
showBoard ();

// Tell which player to move
if (Whose_Turn ==1)
{
cout << Player_1_name << ": It's your turn" << endl;
cout << " Enter the number of the spot where you'd like to move." << endl;
cin >> move

}
else
{
cout << "The Computer's move is:" << endl;
Move = rand() % 9;
}
// Get move
cout << "Enter the number of spot you'd like to move" << endl;
cin >> Move;
} while (moveIsValid (Move) != true);

// ADd 1 to Total_Moves
Total_Moves++;
// Change whose turn it is
switch (Whose_Turn)
{
case (1):
{
Board[Move] = 'x';
Whose_Turn = 2;
break;
}
case (2):
{
Board[Move] = 'o';
Whose_Turn = 1;
}
}
}

// sow the board
showBoard ();

if (whoWon () == 1)
{
// show the board
showBoard();
cout << Player_1_name << " has won the game!" << endl;

}
else if (whoWon () == 2)
{
// Show the board
showBoard();
cout << " The computer has won the game! " << endl;
}
else
{
// Show the board
showBoard();
cout << "It;s a tie game!" << endl;
}
{
if (num_players ==2)
}

// Get player names
cout << " Player 1: Please enter your name " << endl;
cin >> Player_1_name;
cout << " Player 2: Please enter your name " << endl;
cin >> Player_2_name;
}
system ("Pause");
}
void showBoard ( )
{
cout << endl;
cout << Board[0] << " | " << Board[1] << " | " << Board[2] << endl;
cout << "--+---+--" << endl;
cout << Board[3] << " | " << Board[4] << " | " << Board[5] << endl;
cout << "--+---+--" << endl;
cout << Board[6] << " | " << Board[7] << " | " << Board[8] << endl;
cout << endl;
}


bool moveIsValid (int m )
{
if (Board[m] != 'x' && Board[m] != 'o')
{
return true;
}
else
{
return false;
}

}

int whoWon ( )
{
if (Board[0] == Board[1] && Board[1] == Board[2])
{
if (Board[0] == 'x')
{
return 1;
}
else
{
return 2;
}
}
if (Board[3] == Board[4] && Board[4] == Board[5])
{
if (Board[3] == 'x')
{
return 1;
}
else
{
return 2;
}
}
if (Board[6] == Board[7] && Board[7] == Board[8])
{
if (Board[6] == 'x')
{
return 1;
}
else
{
return 2;
}
}
if (Board[0] == Board[3] && Board[3] == Board[6])
{
if (Board[0] == 'x')
{
return 1;
}
else
{
return 2;
}
}
if (Board[1] == Board[4] && Board[4] == Board[7])
{
if (Board[1] == 'x')
{
return 1;
}
else
{
return 2;
}
}
if (Board[2] == Board[5] && Board[5] == Board[8])
{
if (Board[2] == 'x')
{
return 1;
}
else
{
return 2;
}
}
if (Board[0] == Board[4] && Board[4] == Board[8])
{
if (Board[0] == 'x')
{
return 1;
}
else
{
return 2;
}
}
if (Board[2] == Board[4] && Board[4] == Board[6])
{
if (Board[2] == 'x')
{
return 1;
}
else
{
return 2;
}
}
return 0;
}
FredFlintstone (11)
You can play alone against the computer. You did not write the section for two players.
I made ​​some changes. Can you see them?
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
 
// Computer Tic tac toe,

// Include the iostream library
#include <iostream>
#include <string>
#include <ctime>

// Using the standard namespace
using namespace std;
// declare global variables
char Board [9];

// Declare Functions
void showBoard ( );
bool moveIsValid (int m );
int whoWon(); // Returns 0 if no one has won,1 if player 1 has won, 2 if player 2 has won
int main ( ) {

// Seed the random number
srand (time (NULL) );

// Declare Global Variables
string Player_1_name;
string Player_2_name;
int Whose_Turn = 1; // 1 means players turn and 2 means player 2 turns
int Move; // Store where the players wants to move
int Total_Moves = 0;
int num_players = 0;

// Assigns values to the playing board
Board[0] = '0';
Board[1] = '1';
Board[2] = '2';
Board[3] = '3';
Board[4] = '4';
Board[5] = '5';
Board[6] = '6';
Board[7] = '7';
Board[8] = '8';

// Give Choise to play 2 player or against computer
cout << "Welcome to Tic Tac Toe.\n Enter 1 for 1 player or 2 for 2 player" << endl;
cin >> num_players;
  if (num_players ==2) {
    // Get player names
    cout << " Player 1: Please enter your name " << endl;
    cin >> Player_1_name;
    cout << " Player 2: Please enter your name " << endl;
    cin >> Player_2_name;
  }
  if (num_players == 1) {
  //Get PLayer Names
    cout << " Player 1: Please enter your name " << endl;
    cin >> Player_1_name;
    while (whoWon ( ) ==0 && Total_Moves < 9) {
      do {
        // Show the board
        showBoard ();
        // Tell which player to move
        if (Whose_Turn ==1) {
          cout << Player_1_name << ": It's your turn" << endl;
          cout << " Enter the number of the spot where you'd like to move." << endl;
          cin >> Move;
        } else {
          Move = rand() % 9;
          cout << "The Computer's move is: " << Move << endl;
        }
        // Get move
       // cout << "Enter the number of spot you'd like to move" << endl;
       // cin >> Move;
      } while (moveIsValid (Move) != true);
      // Add 1 to Total_Moves
      Total_Moves++;
      // Change whose turn it is
      switch (Whose_Turn) {
        case (1): {
          Board[Move] = 'x';
          Whose_Turn = 2;
          break;
        }
        case (2): {
          Board[Move] = 'o';
          Whose_Turn = 1;
        }
      }
    }
    // show the board
    showBoard ();
    if (whoWon () == 1) {
      // show the board
      showBoard();
      cout << Player_1_name << " has won the game!" << endl;
    } 
    if (whoWon () == 2) {
      // Show the board
      showBoard();
      cout << " The computer has won the game! " << endl;
    } 
    if (Total_Moves==9 && !whoWon()) {
      // Show the board
      showBoard();
      cout << "It;s a tie game!" << endl;
    }
  }
  system ("Pause");
  return 0;
}
void showBoard ( ) {
  cout << endl;
  cout << Board[0] << " | " << Board[1] << " | " << Board[2] << endl;
  cout << "--+---+--" << endl;
  cout << Board[3] << " | " << Board[4] << " | " << Board[5] << endl;
  cout << "--+---+--" << endl;
  cout << Board[6] << " | " << Board[7] << " | " << Board[8] << endl;
  cout << endl;
}

bool moveIsValid (int m ) {
  if (Board[m] != 'x' && Board[m] != 'o') {
    return true;
  } else {
    return false;
  }
}

int whoWon ( ) {
if (Board[0] == Board[1] && Board[1] == Board[2]) {
  if (Board[0] == 'x') {
    return 1;
  } else {
    return 2;
  }
}
if (Board[3] == Board[4] && Board[4] == Board[5]) {
  if (Board[3] == 'x') {
    return 1;
  } else {
    return 2;
  }
}
if (Board[6] == Board[7] && Board[7] == Board[8]) {
  if (Board[6] == 'x') {
    return 1;
  } else {
    return 2;
  }
}
if (Board[0] == Board[3] && Board[3] == Board[6]) {
  if (Board[0] == 'x') {
    return 1;
  } else {
    return 2;
  }
}
if (Board[1] == Board[4] && Board[4] == Board[7]) {
  if (Board[1] == 'x') {
    return 1;
  } else {
    return 2;
  }
}
if (Board[2] == Board[5] && Board[5] == Board[8]) {
  if (Board[2] == 'x') {
    return 1;
  } else {
    return 2;
  }
}
if (Board[0] == Board[4] && Board[4] == Board[8]) {
  if (Board[0] == 'x') {
    return 1;
  } else {
    return 2;
  }
}
if (Board[2] == Board[4] && Board[4] == Board[6]) {
  if (Board[2] == 'x') {
    return 1;
  } else {
    return 2;
  }
}
return 0;
}
TananTanTananTanToink (11)
Thanks again FredFlinstone!
Topic archived. No new replies allowed.