Need help with structure, accuracy, formatting etc. of this module.

Hello,

My name is Jeremy and I am an experienced C++ programmer but am completely new to C++11. Below is a module I am working on for a project of mine which is used to manage resources (similiar to a COM interface). It is not tested/debugged etc. so please don't run it as it is the first draft and untested. I have the following questions concerning it:

1) Since I am new to C++11 I would like to know if there are features/optimizations of C++11 that I am not using in this module that would make it better. It has been programmed (for the most part) without my knowledge of C++11.

2) Does C++11 have support for eliminating the need for forward declarations?
(There is one at the top that I do not know if I can eliminate with C++11).

3) It has always been my understanding that you want larger data members declared before smaller data members to save on padding bytes. Is this still accurate these days?

4) Due to its structure/nature, I needed to include the bodies of the methods inside the .h file (at least pre-C++11) although it would be nicer if I could use a .cpp file. With C++11 is there a way to move the method bodies of these template/static methods to a .cpp file?

5) Any other thoughts, recommendations?

Thank you for your help, ok, here it is:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
/* !
*/
#pragma once
#ifndef JSFT_RESOURCE_MANAGER
#define JSFT_RESOURCE_MANAGER

// @ !
#include <map>
// @ End

/* @ !
*/
namespace Jade
{
	/* @ !
	*/
	namespace ResourceManager
	{
		/*
		*/
		class JInvalidRefCount : public std::exception
		{
		public:
		// @
			/*
			*/
			const char* what() const {return "ERROR: Attempted release of resource with reference count 0.";}
		};
		// @ End

		/*
		*/
		class JResourceNotFound : public std::exception
		{
		public:
		// @
			/*
			*/
			const char* what() const {return "ERROR: Attempted access of non-existant resource.";}
		};
		// @ End

		/* !
		*/
		template <class JLoadProperties, class JBaseResource>
		class JResourceManager
		{
		private:
		// @
			// @ !
			template <class JLoadProperties> class JResource;
			// @ End
		// @ End
		public:
		// @
			/* !
			*/
			typedef JResource<JLoadProperties>* PResource;
			// @ End
		// @ End
		private:
		// @
			/* !
			*/
			template <class JLoadProperties>
			class JResource : public JBaseResource
			{
			private:
			// @
				// @ !
				JLoadProperties load_properties_;
				unsigned int ref_count_;
				bool cached_;
				// @ End
			// @ End
			public:
			// @
				// @ 
				JResource() : ref_count_(0), cached_(false){}
				// @ End

				// @ 
				void Initialize(const JLoadProperties& load_properties){load_properties_ = load_properties; JBaseResource::Initialize(load_properties);}
				// @ End

				// @ !
				virtual ~JResource(){}
				// @ End

				/* !
				*/
				bool GetCacheState() const {return cached_;}
				// @ End

				/* !
				*/
				unsigned int GetRefCount() const {return ref_count_;}
				// @ End

				/* !
				*/
				const JLoadProperties& GetLoadProperties() const {return load_properties_;}
				// @ End

				/* !
				*/
				void SetCacheState(bool cache){cached_ = cache;}
				// @ End

				/* !
				*/
				void AddRef(){++ref_count_;}
				// @ End

				/* !
				*/
				unsigned int Release();
				// @ End
			};
			// @ End
		//@ End
		protected:
		// @
			// @
			static std::map<JLoadProperties, JResource<JLoadProperties>> resources_;
			// @ End
		//@ End
		public:
		// @
			/* !
			*/
			static bool GetCacheState(const JLoadProperties& load_properties);
			// @ End

			/* !
			*/
			static unsigned int GetResourceCount(){return resources_.size();}
			// @ End

			/* !
			*/
			static void CacheResource(const JLoadProperties& load_properties);
			// @ End

			/* !
			*/
			static void UncacheResource(const JLoadProperties& load_properties);
			// @ End

			/* !
			*/
			static void UncacheResources();
			// @ End

			/* !
			*/
			static PResource GetResource(const JLoadProperties& load_properties);
			// @ End

			/* !
			*/
			static bool HasReferencedResources();
			// @ End
		//@ End
		private:
		// @
			// @ !
			JResourceManager();
			// @ End
		};
		// @ End

		/*
		*/
		template <class LP, class BR> template <class LP2> unsigned int JResourceManager<LP, BR>::JResource<LP2>::Release()
		{
			if(!ref_count_)
			{
				throw JInvalidRefCount();
			}
			if(1 == ref_count_ && !cached_)
			{
				JResourceManager<LP, BR>::resources_.erase(load_properties_);
				return 0;
			}
			return --ref_count_;
		}
		// @ End

		/* 2
		*/
		template <class LP, class BR> bool JResourceManager<LP, BR>::GetCacheState(const LP& load_properties)
		{
			auto i = resources_.find(load_properties);
			if(resources_.end() == i)
			{
				throw JResourceNotFound();
			}
			return i->second.GetCacheState();
		}
		// @ End

		/* 2
		*/
		template <class LP, class BR> void JResourceManager<LP, BR>::CacheResource(const LP& load_properties)
		{
			auto description = resources_.emplace(std::pair<LP, JResource<LP>>(load_properties, JResource<LP>()));
			if(description.second)
			{
				description.first->second.Initialize(load_properties);
			}
			description.first->second.SetCacheState(true);
		}
		// @ End

		/* 2
		*/
		template <class LP, class BR> void JResourceManager<LP, BR>::UncacheResource(const LP& load_properties)
		{
			auto i = resources_.find(load_properties);
			if(resources_.end() == i)
			{
				throw JResourceNotFound();
			}
			if(i->second.GetRefCount())
			{
				i->second.SetCacheState(false);
			}
			else
			{
				resources_.erase(load_properties);
			}
		}
		// @ End

		/* 2
		*/
		template <class LP, class BR> void JResourceManager<LP, BR>::UncacheResources()
		{
			auto i = resources_.begin();
			while(resources_.end() != i)
			{
				if(i->second.GetCacheState())
				{
					if(i->second.GetRefCount())
					{
						i->second.SetCacheState(false);
					}
					else
					{
						i = resources_.erase(i);
						continue;
					}
				}
				++i;
			}
		}
		// @ End

		/* ! 2
		*/
		template <class LP, class BR> typename JResourceManager<LP, BR>::PResource JResourceManager<LP, BR>::GetResource(const LP& load_properties)
		{
			auto description = resources_.emplace(std::pair<LP, JResource<LP>>(load_properties, JResource<LP>()));
			if(description.second)
			{
				description.first->second.Initialize(load_properties);
			}
			description.first->second.AddRef();
			return &description.first->second;
		}
		// @ End

		/*
		*/
		template <class LP, class BR> bool JResourceManager<LP, BR>::HasReferencedResources()
		{
			for(auto& i : resources_)
			{
				if(i.second.GetRefCount())
				{
					return true;
				}
			}
			return false;
		}
		// @ End

		// @
		template <class LP, class BR> std::map<LP, typename JResourceManager<LP, BR>::JResource<LP>> JResourceManager<LP, BR>::resources_;
		// @ End
	}
	// @ End
}
// @ End

#endif;
// @ End !
// @ End 

Topic archived. No new replies allowed.