binary search tree problem

[DANNY123]

#include <iostream>
using namespace std;
typedef struct node{
	node*right;
	node*left;
	node*father;
	int height;
	int key;
}node,*pnode;
void insert(pnode p1,int n)
{ int h=1;
   //init
	pnode p;
	p=new node;
	p->key=n;
	p->father=NULL;
	p->right=NULL;
	p->left=NULL;
    if(p1==NULL)
	{p1=p;
	return ;
}//logic
if(p1->left==NULL&&n<p1->key)
{     p1->left=p;
p->father=p1;

return ;
}	
if(p1->right==NULL&&n>p1->key)
{     p1->right=p;
      p->father=p1;
	  
	  return ;
}
if(n<p1->key)//recursive
{insert(p1->left,n);}
else if(n>p1->key)//recursive
{insert(p1->right,n);}
else
h++;
	p->height=h;
return ;

}
pnode find(node*p,int k)
{

		if(!p)
			return NULL;
		if(k<p->key)
			return find(p->left,k);
		else if(k>p->key)
			
		return find(p->right,k);
		else
		return p;
}



int main()
{   
	pnode p=NULL;
	insert(p,1);
	insert(p,4);
	insert(p,3);
pnode p2=find(p,4);
cout<<p2->key;
	

system("pause");
return 0;

}

It exit with warning

[ne555]

_ Your indentation is awful
_ Your code does not compile (extra } in line 77)
_ Making it compile, it would segfault, as you're trying to dereference a NULL pointer in line 71.
_ `insert()' is simply leaking memory. It does not modify `p'

[DANNY123]

I change line 17p=new node; to p=(pnode)malloc(sizeof(node)); but it still doesn't work .

[ne555]

What I mean is that line 23 p1=p; is useless.
You passed the argument by value, so `p' in main remains the same (NULL).