Goto - Even Apple is it!

Bug in question:
1
2
3
4
5
6
7
    if ((err = SSLHashSHA1.update(&hashCtx, &serverRandom)) != 0)
        goto fail;
    if ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0)
        goto fail;
        goto fail;
    if ((err = SSLHashSHA1.final(&hashCtx, &hashOut)) != 0)
        goto fail;
Even if we replace goto with throwing an exception or calling a handler function, bug will persist, therefore goto isn't culpit in this case. I bet on copy-pasting refactoring error or git merge when two different people add same line, but one of them uses incorrecly configured Windows client (git will think that there is two different lines:
1
2
goto fail;\n
goto fail;\r\n
)
Last edited on
closed account (EwCjE3v7)
They real ease iOS 7.0.6 to fix it, I saw tweets going around that IE is safer then safari and all
Last edited on
Topic archived. No new replies allowed.