_ Weird indentation (4 tabs per level)
_ global variables
_ obscure names
_ stupid goto (bad scope understanding, by the way)
_ inheritance abuse
_ methods that don't use/modify the state of the object
_ no encapsulation (public members, chained access)
_ misconceptions
• Any function can modify them. Rules imposed on a global variable can be easily forgotten.
• Threading. They are not thread-safe. Since any function can access them, synchronisation becomes problematic, especially when multiple translation units attempt to modify it.
• Dependency. A part of a program may depend on its use, and modification or removal of the variable could cause compilation of the program to fail.
Please fix that indentation, I don't understand how you can read it. My guess is you use two-space tabs and then indent four times to make it look like 8-space tabs, in which case you should just use 8-space tabs.
No, if you use any editor that is configured normally, that is when it looks like that. You've changed some settings. You shouldn't be using Dev-C++ anyway, it's a terrible IDE.
I think you should fix up your code, to me its hardly readable... Also, while your at it make it a habit to put curly brackets the line AFTER the function is called.
Here's an example:
1 2 3 4
void myFunction()
{
//Some code here
}
(You don't have to do the brackets the line after the function thing, it's just more readable that way in my opinion.)