Having a hard time with semaphores

[mothergoose729]

I am trying to write a really simple program that uses semaphores between a parent and child process. I create a semaphore, I fork the process, and then I have both the parent and the child wait for the semaphore to be zero. When either process gets control of the semaphore, they increment it, output a message and take input from the keyboard, then set it to zero again and repeat in a loop. What I am looking for the program to do is pass control of the semaphore between child and parent process back and forth evenly, with the child having control at one time, then releasing it, then the parent picking it up and doing the same.

#include <stdio.h>
#include <sys/types.h>
#include <sys/ipc.h>
#include <sys/sem.h>

union semun
{
	int val;
	struct semid_ds *buf;
	ushort *array;
};

int main()
{
	int i,j; 
  	int pid;
  	int semid; /* semid of semaphore set */
  	key_t key = 1234; /* key to pass to semget() */
  	int semflg = IPC_CREAT | 0666; /* semflg to pass to semget() */
  	int nsems = 1; /* nsems to pass to semget() */
  	int nsops; /* number of operations to do */
	int num;
  	struct sembuf *sops = (struct sembuf *) malloc(2*sizeof(struct sembuf)); 

	if ((semid = semget(key, nsems, semflg)) == -1)
	{
		perror("/nsemget: semget failed/n");
		exit(1);
	}
	else
	{
		printf("\nsemget succeeeded. The id is =\%d\n", semid);
	}

	if ((pid = fork()) < 0)
	{
		perror("fork");
		exit(1);
	}

	if (pid == 0)
	{
		i = 0;
		nsops = 2;
		while (i < 4)
		{
			sops[0].sem_num = 0;
			sops[0].sem_op = 0;
			sops[0].sem_flg = 0;			

			sops[1].sem_num = 0;
			sops[1].sem_op = 1;
			sops[1].sem_flg = 0;

			if (( j = semop(semid, sops, nsops)) == -1)
			{
				perror("child semop failed");
			}
			else
			{
				printf("\nchild has it.");
				sleep(3);
				i++;
				nsops = 1;
				sops[0].sem_num = 0;
				sops[0].sem_op = -1;
				sops[0].sem_flg = 0;
				
				if ((j = semop(semid, sops, nsops)) == -1)
				{
					perror("child semop failed");
				}
				else
				{
					printf("child process gives it up");
					i++;
					sleep(3);
				}
			}
		}
	}
	else
	{
		i = 0;
                nsops = 2;
                while (i < 4)
                {
                        sops[0].sem_num = 0;
                        sops[0].sem_op = 0;
                        sops[0].sem_flg = 0;

                        sops[1].sem_num = 0;
                        sops[1].sem_op = 1;
                        sops[1].sem_flg = 0;

                        if (( j = semop(semid, sops, nsops)) == -1)
                        {
                                perror("parent semop failed");
                        }
                        else
                        {
                                printf("\nparent has it.");
				sleep(3);
                                i++;
                                nsops = 1;
                                sops[0].sem_num = 0;
                                sops[0].sem_op = -1;
                                sops[0].sem_flg = 0;

                                if ((j = semop(semid, sops, nsops)) == -1)
                                {
                                        perror("parent semop failed");
                                }
                                else
                                {
                                        printf("parent process gives it up");
                                        i++;
					sleep(3);
                                }
                        }
                }

	 }
	return 0;
}

the output I am expecting is something like this:

child has it. child process gives it up. 
parent has it. parent process gives it up.
child has it. child process gives it up. 
parent has it. parent process gives it up.
child has it. child process gives it up. 
parent has it. parent process gives it up.
child has it. child process gives it up. 
parent has it. parent process gives it up.
child has it. child process gives it up. 
parent has it. parent process gives it up.

Instead this is what I am getting is the following:

parent has it.
child has it
child process gives it up
parent process gives it up
[system hangs]

Any ideas? Really appreciate some help.

[Cubbi]

you reset your nsops to 1 and never go back to 2, so on the second iteration of the loop, semop() at line 55 and 96 just waits for zero, and never increments the semaphore.
Also you increment i by 2 on every iteration.