logic error after amendment IDEs codeblocks my system is linux

[ebdaa3sea]

[/code#include <iostream>
#include<string>
using namespace std;

class insurance_category
{

int prdouct_id;
	string level_name;
	float Annual_benefit;
	int Period_of_cover;
	bool Cover_inpatient;
	float Total_cover_for_cancer;
	bool Psychiatric;
	bool Maternity;

public:

insurance_category()
{

prdouct_id= 0;
level_name = " ";
Annual_benefit = 0.0;
Period_of_cover = 0;
Cover_inpatient = true;
Total_cover_for_cancer = 0.0;
Psychiatric = true;
Maternity = true;

}
insurance_category(int prdouctid, string levelname, float Annualbenefit, int Period_OfCover, bool Cover_Inpatient, float Totalcoverfor_Cancer, bool psychiatric, bool maternity)
{
prdouct_id= prdouctid;
level_name = levelname;
Annual_benefit = Annualbenefit;
Period_of_cover = Period_OfCover;
Cover_inpatient = Cover_Inpatient;
Total_cover_for_cancer = Totalcoverfor_Cancer;
Psychiatric = psychiatric;
Maternity = maternity;

}


void set()
{

	cout << " enter level name\n";
	cin >> level_name;
	cout << " enter overall annual benefit\n";
	cin >> Annual_benefit;
	cout << "enter period of cover\n";
	cin >> Period_of_cover;
	cout << " cover Inpatient (0-1)\n";
	cin >> Cover_inpatient;
	cout << " enter Total_cover_for_cancer\n";

	cin >> Total_cover_for_cancer;
	cout << " enter Psychiatric (0-1)\n";
	cin >> Psychiatric;
	cout << "enter maternity(0-1)\n";
	cin >> Maternity;
}

void print()
{
	cout << "\n  Prdouct id : " << prdouct_id;
	cout << "\n Level Name : " << level_name;
	cout << "\n Overall annual benefit : " << Annual_benefit;
	cout << "\n Period of cover : " << Period_of_cover;
	cout << "\n Cover inpatient : " << Cover_inpatient;
	cout << "\n Total cover for cancer : " << Total_cover_for_cancer;
	cout << "\n Psychiatric : " << Psychiatric;
	cout << "\n Maternity : " << Maternity;

}

int  get_pri() { return prdouct_id; }
string  get_levname(){ return level_name; }
float  get_annualben(){ return Annual_benefit; }
int  get_pericover(){ return Period_of_cover; }
bool  get_coverinp(){ return Cover_inpatient; }
float get_total_cover(){ return Total_cover_for_cancer; }
bool  get_psychi() { return Psychiatric; }
bool get_mater(){ return Maternity; }

}; //end class insurance_category




class customer

{

	int id;
	string name;
	string address;

public:
customer(int id1, string name1, string addres1)
{

	id = id1;
	name = name1;
	address = addres1;

}
customer(){
	id = 0;
	name = " ";
	address = "";

};

void set_id(int i){
	id = i;
}
void set_name(string n){
	name = n;
}
void set_address(string a){
	address = a;
}

int get_id(){ return id; }
string get_name(){ return name; }
string get_address(){ return address; }


void print(){
	cout << endl << get_id() << endl << get_name() << endl << get_address() << endl;
}


};


class company: public customer
{
	int lincense_num;
	int counter;
	insurance_category **p;
	int x;

public:
company()
{

	lincense_num = 0;
	counter = 0;
	x = 10;
	p = new	insurance_category*[x];
	for (int i = 0; i < 10; i++)
		p[i] = NULL;

}

	company(int lin_num,int x1, int i1, string n1, string a1) :customer(i1, n1, a1)
	{

		lincense_num = lin_num;
		counter = 0;
		x =x1;
		p = new	insurance_category*[x];
		for (int i = 0; i <x; i++)
			p[i] = NULL;
	}

	void set_lincense_num(int l1)
	{

		lincense_num = l1;
	}
	void  set_insurance_category()
	{
		if (counter < x){
			p[counter] = new insurance_category();
			p[counter]->set();
			counter++;
		}
			else cout << "You may not add something \n";


	}

	void delet(int z)

	{
		/*delete p[z];
		p[z] = NULL;*/
		for(int i=0;i<x;i++)
		{if(p[i]->get_pri()==z)
		delete p[i];
		p[i-1]=NULL;
		}
	}
	void modify(int ob_modify)
	{
		p[ob_modify]->set();
		for (int i = 0; i<x; i++)
		{
			if (p[i]->get_pri() == ob_modify)
				p[i]->set();
		}
	}

	int get_lincense_num()
	{
		return lincense_num;

	}
	void print()
	{
		cout << lincense_num << endl;
		print();
		for (int i = 0; i < counter; i++){
		if (p[i] != NULL)
			p[i]->print();
	}
}
};

class individual :public customer
{
	int age;
	int phone_number;
public:

individual()
{
	age = 0;
	phone_number = 0;
}
individual(string name1, int ag1, int phone1, int id1, string addres1) :customer(id1, name1, addres1)
{
	age = ag1;
	phone_number = phone1;
}


void set_age(int ag1){
	age = ag1;
}

void set_phone_number(int phone1){
	phone_number = phone1;
}

int get_age(){
	return age;
}

int get_phone_number(){
	return phone_number;
}

void print()
{
	cout << endl <<"id:"<< customer::get_id() << endl << "name: "<< customer::get_name() << endl <<"address:" <<customer::get_address() << endl <<"age:"<< get_age() << endl << "phone number:"<<get_phone_number() << endl;
}};




int main()
{
	//customer
	int id;
	string name, address;
	//indi
	int Age, phone;
	//company
	int lincen;
	//insura
	int prdouct_id;
	string level_name;
	float Annual_benefit;
	int Period_of_cover;
	bool Cover_inpatient;
	float Total_cover_for_cancer;
	bool Psychiatric;
	bool Maternity;
	int k,c;
	char x,x1;
	insurance_category Print;
	cout << "***** WELOCME TO OUR PROGRAM ***** ";



do
{
	int Customer;
	cout << "\nPlease choice your Customer :  \n";
	cout << "1- Individual :\n";
	cout << "2- Company :\n";
	cin >> Customer;


	if(Customer==1)
{

	cout << "\nYour choice is Individual :\n ";
	cout << "\n Please enter your ID : ";
	cin >> id;
	cout << "\n Please enter your Name : ";
	cin >> name;
	cout << "\n Please enter your Address : ";
	cin >> address;

	cout << " \n Please enter your Age : \n";
	cin >> Age;
	cout << "\n Please enter your Phone Number : \n ";
	cin >> phone;
individual ob1(name,Age,phone,id,address);
ob1.print();
}


if (Customer==2)
{
cout << "\n Your choice is Company : \n ";
cout << "\n Please enter your ID : ";
	cin >> id;
	cout << "\n Please enter your Name : ";
	cin >> name;
	cout << "\n Please enter your Address : ";
	cin >> address;

	cout << "\n Please enter your Lincense Num : \n";
	cin >> lincen;
	cout << "\n Please enter number of array : \n";
	cin >> k;
company ob2(lincen,k,id,name,address);
ob2.print();

	do
	{

	cout << "\nPlease chose what you want \n";
	cout << "\n1- creat new insurance :\n ";
	cout << "\n2- modify any insurance :\n ";
	cout << "\n3- Delete any insurance : \n";
	cout << "\n4- Print all Data insurance :\n ";
	cin >> c;
	switch(c)
	{
	case 1:
	cout << "\n Insurance Data \n  ";
		cout << " enter product id\n";
		cin >> prdouct_id;
		cout << " enter level name\n";
		cin >> level_name;
		cout << " enter overall annual benefit\n";
		cin >> Annual_benefit;
		cout << "enter period of cover\n";
		cin >> Period_of_cover;
		cout << " cover Inpatient enter 1 if you want, 0 if you not :  \n";
		cin >> Cover_inpatient;
		cout << " enter Total_cover_for_cancer\n";

		cin >> Total_cover_for_cancer;
		cout << " enter Psychiatric enter 1 if you want, 0 if you not : \n";
		cin >> Psychiatric;
		cout << "enter maternity enter 1 if you want, 0 if you not : \n";
		cin >> Maternity;
		break;

		case 2:
		cout << "\n Do you want Modify ? enter  Y/y ... if you don't want enter N/n :  ";
		char  m;
		cin >> m;
		if ((m == 'y'||m=='Y') &&  (m!='N'|| m!='n'))
		{
			cout << "\nEnter number of culomn you want to modify it :  ";
			int c;
			cin >> c;
			ob2.modify(c);
		}
		else cout << "\nthere is no modify";
			break;

			case 3:
			cout << "\nenter number of culomn in array you to delete it :";
			int d1;
			cin >> d1;

			ob2.delet(d1);
			break;

			case 4:

			cout << "Print All Data insurance : ";

		Print.print();

	}


	cout << "\n if Do you want see list agin enter  Y/y ... if you don't want enter N/n : ";
		cin >> x;

}
while((x == 'y'|| x == 'Y') && (x!='N'|| x!='n'));

}
cout << "\n If you want creat new customer enter  Y/y ... if you don't want enter N/n : ";
cin >> x1;
}
while((x1 == 'y'|| x1 == 'Y') && (x1!='N'|| x1!='n'));
return 0;
}


[code]

]
This is Programe After amendment

My problem is logic
1- delet and modify function I`m enter the num of element but the compile show me this messge (segmentation fault)

2- object {Print.print();} isn`t print all insurance and some of data the value change to zero during the program

3- void set_insurance_category
this functoin creat array but dosn`t work Idon`t know why ??

4-in class insurance_category the data member if i send value during the program his dosn`t save ?? do you think must be use static bec save the value

[Peter87]

I noticed that the company::print() function calls itself recursively without limit.

[ebdaa3sea]

you are mean infinity loop ??

[Peter87]

It's similar to a loop but it's not. It will use up more and more stack memory until it crash, except if the compiler is able to do some tail call optimization, then it might be able to run infinitely.

[ebdaa3sea]

so do you think this reason for segmentation fault error ??

and my compiler is GNU C++ :)

[Peter87]

Yes. When I tested your program that's where I got the segfault. When the print() function was called it printed the license number over and over again many times and eventually it crashed with a segmentation fault error.

[ebdaa3sea]

I `m amendment on class cpmpany
the amendment is :
1- remove void set_lincense_num(int l1) && void set_insurance_category()

2- void print()
{
print();

} //this is void print after amendment i`m remove loop

3- I am send value to data member of class insurance_category
but some of value change during the program :(
the value change in this varibal

int prdouct_id; // change to 0
string level_name; //change to " "
float Annual_benefit; // change to 0
int Period_of_cover; // change to 0

float Total_cover_for_cancer; // change to 0

4- the function delete and modify dosn`t work :( :(