Segmentation fault (core dumped)

[guerreiro]

I don't know why, but there's an error in my program, I can't see anything wrong with my code.
I compiled the program via terminal: g++ *.cc -I. -o programa and the code where the error stop the program is:

#include <iostream>
#include <string.h>
#include <sys/time.h>
#include <ctime>
#include <Arvore.h>
#include <Logradouro.h>
#include <cstdlib>
#include <fstream>

#define BUFFER_LENGTH 256

using namespace std;

int main(int a, char **v) {
	if(a < 2) {
		cout << "Você deve passar o nome do arquivo como parâmetro na chamada do programa!";
		return 0;
	}
	
	ifstream arquivo(v[1]);
	ofstream saida("dados.dat");
	
	char buffer[BUFFER_LENGTH];
	
	int p, cep = 0, n = 0;
	char *nome;
	
	timeval *inicio, *fim;
	double tempo;
	
	Arvore arv;
	
	bool d = false;
	int i = 0;
	do {
		arquivo.getline(buffer, BUFFER_LENGTH);
	 	
		nome = strtok(buffer, "|");
		
		if(buffer[0] != 0) cep = atoi(strtok(0, "|"));
		
		gettimeofday(inicio, 0);
		
		cout << "Preconstruct" << endl;
		// Here the program stops
		Logradouro *l = new Logradouro();
		cout << "Posconstruct" << endl;
		l->nome = nome;
		l->cep = cep;
		
		arv.inserir(l);
		
		gettimeofday(fim, 0);
				
		tempo = fim->tv_usec - inicio->tv_usec;
		
		saida << cep << " " << tempo << endl;
		
		n++;
	} while(!arquivo.eof());
	
	system("gnuplot -p \"comandos.cmd\"");
}

The Logradouro class header file:

#ifndef _LOGRADOURO_H_
#define _LOGRADOURO_H_

class Logradouro {
	public:
		int cep;
		char *nome;
		
		Logradouro();
		virtual ~Logradouro();
};

#endif 

The constructor of Logradouro is:

Logradouro::Logradouro() {
	cep = 0;
	nome = 0;
}

and the output of the program is:

...
Preconstruct
Segmentation fault (core dumped)

[Athar]

I see no error. Post a fully compilable example.

[ne555]

timeval *inicio, *fim;
//...
gettimeofday(inicio, 0);

`inicio' is uninitialized.
You should do

timeval inicio, fin; //objects, no pointers.
//...
gettimeofday(&inicio, 0);

Also, `buffer' will change its content in the next iteration, so `Logradouro::name' will have garbage


By the way, your example does not compile.

[guerreiro]

Thank you ne555, it worked here after the change you proposed. I also fixed the buffer problem by allocating a new char buffer and using the strcpy function.