Compile Issue with Visual Studio 2015

[Sh0es]

I'm trying to compile a project in Visual Studio 2015 and I'm getting compile errors that, frankly, don't make any sense. They're all related to this class:

#ifndef LINK_H
#define LINK_H

#include <iostream>
#include "ListExceptions.h"

template <class T>
class Link
{
protected:
    T* data;
    Link<T>* next;
    Link<T>* prev;

public:

    //mutators
    void linkRight(T& n);
    void linkLeft(T& p);
    void LinkRight(Link<T>& n);
    void LinkLeft(Link<T>& p);

    void insert(T& d, int i);
    void remove(T& d);
    void removeAt(unsigned int i);
    void clear();

    //accessors
    Link<T>& getNext() const;
    Link<T>& getPrev() const;
    bool isEmpty() const;

    T& getData();
    T getCopy() const;

    unsigned int getSize() const;

    //overloaded operators
    Link<T>& operator =(const Link<T>& l);
    T& operator [](const unsigned int& p) const;
    T& operator [](const unsigned int& p);

    //constructors
    Link();
    Link(const Link<T>& c);
    Link(T& d);
    ~Link();
};

/* mutators */

template <class T>
void Link<T>::linkRight(T& n)
{
    next = new Link<T>(n);
    next->linkLeft(*this);
}

template <class T>
void Link<T>::linkLeft(T& p)
{
    prev = new Link<T>(p);
    prev->LinkRight(*this);
}

template <class T>
void Link<T>::linkRight(Link<T>& n)
{
    next = &n;
}

template <class T>
void Link<T>::linkLeft(Link<T>& p)
{
    prev = &p;
}

template <class T>
void Link<T>::insert(T& d, int i)
{
    if(i == 0)
    {
        this = new Link<T>(d);
        linkLeft(d);
    }
    else
    {
        if(next == nullptr)
            throw LinkedListBounds();
        else
            next->insert(d, i-1);
    }
}

template <class T>
void Link<T>::remove(T& d)
{
    bool found = false;

    if(*data == d)
    {
        prev->linkRight(next);
        next->linkLeft(prev);
        delete data;
        next = nullptr;
        prev = nullptr;
        found = true;
    }
    else if(next == nullptr)
    {
        throw LinkedListNotFound();
    }
    else
    {
        remove(next->getData());
    }
}

template <class T>
void Link<T>::removeAt(unsigned int i)
{
    if(i < 0)
        throw LinkedListBounds();

    if(i == 0)
    {
        prev->linkRight(next);
        next->linkLeft(prev);
        delete data;
        next = nullptr;
        prev = nullptr;
    }
    else
    {
        if(next == nullptr)
            throw LinkedListBounds();
        else
            removeAt(i-1);
    }
}

template<class T>
void Link<T>::clear()
{
    prev->linkRight(next);
    next->linkLeft(prev);
    delete data;
    next = nullptr;
    prev = nullptr;
}

/* accessors */

template <class T>
Link<T>& Link<T>::getNext() const
{
    return *next;
}

template <class T>
Link<T>& Link<T>::getPrev() const
{
    return *prev;
}

template <class T>
bool Link<T>::isEmpty() const
{
    return data == nullptr;
}

template <class T>
T& Link<T>::getData()
{
    return *data;
}

template <class T>
T Link<T>::getCopy()
{
    return *data;
}

template <class T>
unsigned int Link<T>::getSize() const
{
    return 1 + (next->getSize());
}

/* overloaded operators */

template <class T>
Link<T>& Link<T>::operator =(const Link<T>& l)
{
    data = &(l.getData());
    next = &(l.getNext());
    prev = &(l.getPrev());
}

template <class T>
T& Link<T>::operator [](const unsigned int& p) const
{
    if(p == 0)
        return *this;
    else
        return *(next[p-1]);
}

template <class T>
T& Link<T>::operator [](const unsigned int& p)
{
    if(p == 0)
        return *this;
    else
        return *(next[p-1]);
}

template <class T>
std::ostream& operator <<(ostream& o, const Link<T>& l)
{
    unsigned int edn = l.getSize();

    for(unsigned int i = 0; i < edn; i++)
    {
        o << l << " -> ";
        l = l.getNext();
    }

    o << endl;
}

/* constructors */

template <class T>
Link<T>::Link()
{
    data = new T;
    next = new Link<T>();
    prev = new Link<T>();
}

template <class T>
Link<T>::Link(const Link<T>& c)
{
    data = &(c.getCopy());
    prev = new Link<T>(c.getPrev());
    next = new Link<T>(c.getNext());
}

template <class T>
Link<T>::Link(T& d)
{
    data = &d;
    next = nullptr;
    prev = nullptr;
}

template <class T>
Link<T>::~Link()
{
    if(data != nullptr)
        delete data;

    next = nullptr;
    prev = nullptr;
}
#endif 

I'm getting messages related to ostream being undefined, declaration/definition mismatches, and 'T' is not a valid template type argument for parameter 'T'. Could someone look over my code and see if anything is amiss, because I can't find anything wrong.

[Zaita]

You need to #include <ostream> for ostream

[cire]

You need to #include <ostream> for ostream

iostream brings in both ostream and istream.

However, we don't compile headers, and template code isn't compiled at all unless it is instantiated/used, so we don't have the complete code that is causing the issue.

[Sh0es]

Allow me to provide a full list of errors so hopefully you can get a better idea of what's wrong.


error C2244: 'Link<T>::linkRight': unable to match function definition to an existing declaration

error C2244: 'Link<T>::linkLeft': unable to match function definition to an existing declaration

error C2244: 'Link<T>::getCopy': unable to match function definition to an existing declaration

error C2065: 'ostream': undeclared identifier

error C2065: 'o': undeclared identifier

error C2988: unrecognizable template declaration/definition

error C2059: syntax error: 'const'

error C2065: 'T': undeclared identifier

error C2923: 'Link': 'T' is not a valid template type argument for parameter 'T'

error C2143: syntax error: missing ';' before '{'

error C2447: '{': missing function header (old-style formal list?)

[cire]

Your implementation of linkRight begins with a lower case l. Your declaration of LinkRight begins with an upper case L.

Likewise with the left version.

getCopy is a const member function in the declaration, but not in the implementation.

You must qualify the ostream type with the namespace it occurs in (std::.)

[Sh0es]

Yeah I figured that all out eventually. Thanks anyway.