More Networking problems- winsock error 10014

[shaqywacky]

Hullo everyone!

So I'm still working on doing some network programming for windows. For anyone that saw my last thread, I figured out what was wrong and it was basically that the function I was calling was more of a *nix function.

I've finally gotten some code to compile but I'm getting errors. This program should just send the letter 'W' to any connecting client then close the connection then close the program.

The problem arises on the accept() call and I get a 10014 (WSAEFAULT) error. I've googled the error but it doesn't mean much to me. It said that the buffer may be too small, so i increased it but that didn't seem to do anything. So here's the code.

I've checked all the other function calls and accept() is the first one that produces an error.

#include <winsock2.h>
#include <iostream>
using namespace std;

int main()
{
   WSADATA              wsaData;
   SOCKET               ListeningSocket;
   SOCKET               NewConnection;
   SOCKADDR_IN          ServerAddr;
   SOCKADDR_IN          ClientAddr;
   int                  Port = 5150;
   int                  ClientAddrLen;
   char                 data[80];
   int                  bufLen = 80;
   int ret;
   
   // Initialize Winsock version 2.2

   WSAStartup(MAKEWORD(2,2), &wsaData);
   
      // Create a new socket to listen for client connections.
 
      ListeningSocket = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
	  
      // Set up a SOCKADDR_IN structure that will tell bind that we
      // want to listen for connections on all interfaces using port
      // 5150. Notice how we convert the Port variable from host byte
      // order to network byte order.
	  
      ServerAddr.sin_family = AF_INET;
      ServerAddr.sin_port = htons(Port);    
      ServerAddr.sin_addr.s_addr = htonl(INADDR_ANY);
	  
      // Associate the address information with the socket using bind.
	  
      ret = bind(ListeningSocket, (SOCKADDR *)&ServerAddr, 
      sizeof(ServerAddr));
      cout << sizeof(ServerAddr) << '\n';


   // Listen for client connections. We used a backlog of 5, which
   // is normal for many applications.

      ret = listen(ListeningSocket, 5); 
      

   // Accept a new connection when one arrives.

      NewConnection = accept(ListeningSocket, (SOCKADDR *) 
                          &ClientAddr,&ClientAddrLen);
                          
   if (NewConnection == SOCKET_ERROR)
      {
      cout << "WSACleanup failed with error " << WSAGetLastError() << '\n';
      }
 

   // At this point you can do two things with these sockets. Wait
   // for more connections by calling accept again on ListeningSocket
   // and start sending or receiving data on NewConnection. We will
   // describe how to send and receive data later in the chapter.

  data[0] = 'W';
  data[1] = '\0';
  ret = send(NewConnection, data, bufLen, 0);
  




   // When you are finished sending and receiving data on the
   // NewConnection socket and are finished accepting new connections
   // on ListeningSocket, you should close the sockets using the
   // closesocket API. We will describe socket closure later in the 
   // chapter.

      closesocket(NewConnection);
      closesocket(ListeningSocket);

   // When your application is finished handling the connections, 
   // call WSACleanup.

      WSACleanup();
      
  return 0;
}

I've tried everything I can think of, so I could use a little help.

Thanks.

[Texan40]

WSAEFAULT   10014  Bad address.
The system detected an invalid pointer address in attempting to use a pointer
argument of a call. This error occurs if an application passes an invalid pointer
value, or if the length of the buffer is too small. For instance, if the length of an 
argument, which is a sockaddr structure, is smaller than the sizeof(sockaddr).

The only thing I see is that you are passing &ClientAddrLen into accept() without initializing it with ClientAddrLen = sizeof(SOCKADDR_IN);

[kbw]

I was calling was more of a *nix function.

You did get the answer, inet_pton() is available on Vista and later (NT 6+), so you need to set the relevant macro.

You haven't initialised ClientAddrLen before calling accept().

You have the same problem described here: http://www.cplusplus.com/forum/unices/47273/#msg261746