Wrong coopilation

[karla89]

I'm new to using c++ and I have to design and code a C++ program that utilizes a function to calculate the following for each employee from the time record input file employeehours.txt. I'm using void and calling the file on my device. However, I have duplicated code inside the void and in the main function and I don't know how to resolve it. This is what I have so far...

#include <iostream>
#include <string>
#include <fstream>
using namespace std;
void find_pay(string x)
{
    ifstream inputFile;
    string filename;
    // Get the filename from the user.
    cout << "Enter the filename: ";
    cin >> filename;

    // Open the file.
    inputFile.open(filename);

    // If the file successfully opened, process it.
    if(inputFile.is_open()){
            string tp,prev,name,hour;
            double total=0;
            while(getline(inputFile,tp)){
                name = tp.substr(0,30);
                hour = tp.substr(31,2);
                if(prev.compare(name)!=0 ){
                    float gp = 18*total;
                    float tax = (12*gp)/100;
                    float net = gp - tax;
                    if(total!=0)
                        cout << "Employee: " << prev << "\t\tTotal Hours: " << total << " Gross Pay: $" << gp << " Tax" << tax << " Net Pay: " << net << endl;
                    name = tp.substr(0,30);
                    prev = name;
                    total = 0;
                    total+=stod(hour);
                }
                else if(prev.compare(name)==0){
                    total+=stod(hour);
                }
                
            }
        inputFile.close();
        }
}

int main()
{
    string filename;
       cout << "Enter filename: " << endl;
       cin >> filename;
       find_pay(filename);
   return 0;
}

[Ganado]

Can you be a bit more specific as to what the problem is?
It's also hard to diagnose your issue because there we don't know what your file looks like, or what your expected output is.

[doug4]

I'm only guessing what your problem is because you didn't really tell us what it is.

But, look at your total variable.

It is assigned 0 in line 19. Then you calculate and print out gp, tax and net based on that value in line 24 - 28. Then you set it to 0 and increment it by the value derived from hour.

The next time through the loop (line 20) you have total containing the value from the previous line's hour field.

I suspect you want to set total based on the hours in the current line. Maybe remove lines 31 and 32 and add total = stod(hour); after line 22.

[dhayden]

See my comments below.

#include <iostream>
#include <string>
#include <fstream>

using namespace std;

void
find_pay(string filename)		// pass the filename to find_pay
{
    ifstream inputFile;
    // Open the file.
    inputFile.open(filename);

    // If the file successfully opened, process it.
    if (inputFile.is_open()) {
	string tp, prev, name, hour;
	double total = 0;
	while (getline(inputFile, tp)) {
	    name = tp.substr(0, 30);
	    hour = tp.substr(31, 2);
	    if (prev.size() && prev.compare(name) != 0) { // not true the first time through while loop
		// No sense computing stuff unless you're printing it
		if (total != 0) {
		    float gp = 18 * total;
		    float tax = (12 * gp) / 100;
		    float net = gp - tax;
		    cout << "Employee: " << prev << "\t\tTotal Hours: " << total <<
			" Gross Pay: $" << gp << " Tax" << tax << " Net Pay: " << net <<
			endl;
		}
		prev = name;
		total = 0;
	    }
	    total += stod(hour);
	}

	// Handle the last employee
	if (total != 0) {
	    float gp = 18 * total;
	    float tax = (12 * gp) / 100;
	    float net = gp - tax;
	    cout << "Employee: " << prev << "\t\tTotal Hours: " << total <<
		" Gross Pay: $" << gp << " Tax" << tax << " Net Pay: " << net <<
		endl;
	}
	
	inputFile.close();
    }
}

int
main()
{
    string filename;
    cout << "Enter filename: " << endl;
    cin >> filename;
    find_pay(filename);
    return 0;
}

[Ganado]

Woooow, that's what OP meant by "duplicate". I didn't realize the x parameter wasn't being used. Nice catch.