string error

[jamesbarnes69]

hey! I am really new to programming, so please dont kill me if there are any huge mistakes hahahahahah. My question is, what should I do to fix the error:
main.cpp:24:27: error: could not convert ‘(std::string*)(& cars)’ from ‘std::string* {aka std::basic_string*}’ to ‘std::string {aka std::basic_string}’
enter(cars, i);

  #include <iostream>
using namespace std;
int decision;
int i=0;
string cars[100];
string enter(string cars, int i);
string show(string cars);

int main()
{
    beginning:
    cout<<"press 1 to enter a new car model, press 2 to see what cars you have ";
    cin>>decision;
    if(decision=1){
        enter(cars, i);
    }
    if(decision=2){
        show (cars);
    }
    goto beginning;    
return 0;
}

string enter(string cars, int i){
    cout<<"enter a new car model ";
    cin>>cars[i];
    i++;
}

string show(string cars){
    cout<<"these are the cars you have right now: "<<endl;
    for (int y=0;y<i;y++){
        cout<<cars[y]<<endl;
    }
}

[George P]

goto is bad, very bad. You have no way to programmatically terminate your goto loop. You can use a while or do/while loop.

What happens if your car model is two words (or more)? Getting input from the keyboard from std::cin will stop at the first space so your next attempt to input data from the keyboard can fail because there is still data in the input buffer. Use std::getline (from the <string> header) to get the entire input line including spaces.

std::cin leaves the carriage return in the buffer, std::getline removes it, so you could get erroneous input. Ignore what's in the buffer with std::cin::ignore.

You were trying to pass a std::string array into functions that have a std::string (NOT array) as the first parameter.

No need for global variables, you create in main and pass into your functions. Passed as references (&), not by value.

#include <iostream>
#include <string>

void enter(std::string cars[], int&);
void show(std::string cars[], const int&);

int main()
{
   int decision { };
   int i { };
   std::string cars[100];

   do
   {
      std::cout << "1 to enter a new car model, 2 for car list (-1 to exit): ";
      std::cin >> decision;
      std::cin.ignore(100, '\n');

      if (decision == 1)
      {
         enter(cars, i);
      }

      if (decision == 2)
      {
         show(cars, i);
      }
   }
   while (decision != -1);
}

void enter(std::string cars[], int& i)
{
   std::cout << "Enter the new car model #: ";
   std::getline(std::cin, cars[i]);
   std::cout << '\n';
   i++;
}

void show(std::string cars[], const int& i)
{
   std::cout << "\nList of cars:\n";

   for (int y { }; y < i; y++)
   {
      std::cout << cars[y] << '\n';
   }
   std::cout << '\n';
}

1 to enter a new car model, 2 for car list (-1 to exit): 1
Enter the new car model #: Volta Prime

1 to enter a new car model, 2 for car list (-1 to exit): 1
Enter the new car model #: Leaf

1 to enter a new car model, 2 for car list (-1 to exit): 1
Enter the new car model #: Tesla Big Price Tag

1 to enter a new car model, 2 for car list (-1 to exit): 2

List of cars:
Volta Prime
Leaf
Tesla Big Price Tag

1 to enter a new car model, 2 for car list (-1 to exit): -1