### guess the number game using random number generator

Make a "guess the number game", in which the user enters a number and the computer has to guess that number.

My code does works but can you give me a better way to do this.

#include<iostream>
#include<conio.h>
#include<cstdlib>
#include<ctime>

using namespace std;

int main()
{

int count=0;
int playerNumber;
int randomNumber;
int computersGuess;

cout<<"Lets play \n";
cout<<endl;
cout<<"Hey player, Choose your number \n";
cin>>playerNumber;

while(1)
{

srand(static_cast<unsigned int>(time(0)));//seed
randomNumber = rand();
computersGuess = (randomNumber % 100) + 1;
count++;
cout<<computersGuess<<"\n";

if(computersGuess == playerNumber)
{
cout<<"You chose : "<<computersGuess<<"\n";
cout<<"It took me "<<count<<" tries \n";
break;
}

}

getch();
}

Don't seed the random number generator inside the loop. Do it once at the beginning of the program.

Put the computer guess generator in a separate function.

Generalize your random number generation parts with parameters to indicate the range in which you want your random number to fall.
ya , my range is from 1 - 100.
but if i don't seed it everytime how will i get different random numbers.

and could u tell me a way, to guess the number faster.
well, thanks a lot, i just seeded the thing outside loop and it guesses the number in less tries.
but why so?
When you seed the random number generator, you're telling it where to start in a pseudo-random sequence, and the 'time' you seed it with has a resolution of only one second. Basically, your program guesses the same number over and over again for a full second until the time(0) property changes and it seeds using a new number. Try this code and you'll see that the computer guesses the same thing over and over, and only changes its guess once a second or so.
 ``12345678910111213141516171819202122232425262728293031`` ``````#include #include #include void badFunc() { int playerNumber = 12; int count = 0; while(1) { srand(static_cast(time(0)));//seed int randomNumber = rand(); int computersGuess = (randomNumber % 100) + 1; count++; std::cout<
Here's what I meant by parameterizing your random number generation stuff. Now you can generate numbers within a flexible range of positive numbers.
 ``1234567891011121314151617181920212223242526272829303132333435363738`` ``````#include #include #include int getRandomNumber(unsigned int lowEnd, unsigned int highEnd) { //if the range is one number, don't bother with rand if(lowEnd == highEnd) return lowEnd; //swap the values if the user passed them in the wrong order if(highEnd < lowEnd) { unsigned int temp = highEnd; highEnd = lowEnd; lowEnd = temp; } //stick our desired range into a variable for readibility //add one at the end to avoid a fencepost error unsigned int range = (highEnd - lowEnd) + 1; //generate a number within our range and shift it up //based on the lowest number we want to generate return (std::rand() % range) + lowEnd; } int main() { //seed only once! std::srand(std::time(nullptr)); for(int i = 0; i < 10; ++i) { //generate a random number between 7 and 13 std::cout << getRandomNumber(7, 13) << "\n"; } return 0; }``````
Last edited on
thanks.
Topic archived. No new replies allowed.