Can't find the error

[larsenmb]

I'm writing this code just for fun, and to better understand what I'm learning.
But when I build this code, 4 errors keep coming, but I don't know what they mean, or how to fix them..
Here's the code:

#include <iostream>
#include <vector>

#include "vectors.h" // Vector functions

using namespace std;

int main()
{
    cout << "MENU"           << endl
         << "[A] - average"  << endl
         << "[P] - primes"   << endl
         << "[V] - vector"   << endl
         << "[Q] - quit"     << endl;

    bool done = false;
    do
    {
        char choice;
        cin >> choice;
        cout << endl << endl;

        switch (choice){
            case 'a':
            case 'A':
                average();
                break;
            case 'p':
            case 'P':
                printPrimes();
                break;
            case 'v':
            case 'V':
                vector<char> vec(10, 5);
                print_vector_char(vec); // Prints out the vector
                cout << endl;
                fill_vector_char(vec); // Clears vector, and lets the user refill it
                print_vector_char(vec);
                break;
            case 'q':
            case 'Q':
                done = true;
                break;
        }
    } while (!done);
}

The errors are the following:

Line      Message
40        error: jump to case label [-fpermissive]
34        error: crosses initialization of 'std::vector<char> vec'
41        error: jump to case label [-fpermissive]
34        error: crosses initialization of 'std::vector<char> vec'

I really can't figure it out...
please tell me what they mean, and how to fix them :)
thanks in advance!

[Computergeek01]

They mean you have case conditions without break; statements in them. You can avoid having to declare both cases by using the toupper function from the cctype header one your 'choice' variable anytime before the switch statement EDIT: and after the users input is done: http://www.cplusplus.com/reference/cctype/toupper/?kw=toupper

This will ensure that the input is in upper case format.

[mutexe]

put braces around the whole cases spanning more than one line.

See:
http://stackoverflow.com/questions/14669457/initialization-of-element-is-skipped-by-case-label

[mutexe]

They mean you have case conditions without break; statements in them.

Incorrect. The way he's written the cases and the breaks is just fine.

[larsenmb]

Thanks both!

@mutexe
It did the job, but 3 new errors occured..

Line       Message
35         undefined reference to `print_vector_char(std::vector<char, std::allocator<char> >)'|
37         undefined reference to `fill_vector_char(std::vector<char, std::allocator<char> >)'|
38         undefined reference to `print_vector_char(std::vector<char, std::allocator<char> >)'|

so it didn't entirely fix it...

@Computergeek01
Neither did your solution fix it
I did this:

        switch (toupper(choice)){

and included the header file.
But the same errors occured on line 41 and 34..

[edit] I have to go, dinner.. Will be back in 20 minutes or so.

[Computergeek01]

You're supposed to delete the lower case conditions. The "toupper()" function makes them redundant anyway.

[mutexe]

It did the job, but 3 new errors occured..

i presume these methods live in your vectors.h? how are they declared in there?

[larsenmb]

@Computergeek01
I did delete the lower case conditions, forgot to say that :)

@mutexe

Oh, didn't think of that..

Here's the header file:

// header file vectors.h
#include <vector>

using namespace std;


void print_vector_char(vector<char>);

vector<char> create_vector_char();

void fill_vector_char(vector<char>);

And the source file:

#include <vector>
#include <iostream>
#include <stdio.h>
#include "vectors.h"

using namespace std;

void print_vector_char(vector<char>& vec)
{
    for (unsigned i = 0; i < vec.size(); i++){
        cout << vec[i] << " ";
    }
    cout << endl;
}

void fill_vector_char(vector<char>& vec)
{
    vec.clear();
    char elem;
    do{
        cin >> elem;
        cin.ignore();                    
        vec.push_back(elem);
    } while (elem != '.');
}

Now that I think about it, the 'cin.ignore();' on line 22 is supposed to be after the 'vec.push_back(elem)'?

btw thanks for your time! :D hope you still are looking on this thread

[Computergeek01]

Please re-paste your code if you don't mind. Those errors should have gone away with the case statements if you did it correctly.

[mutexe]

computergeek, no offence but your advice is not correct again. It has nothing to do with the case statements.

OP: hint, your cpp implementation has for example:

void print_vector_char(vector<char>& vec)
{
....
}

Yet your declaration of the 'same' function in your header is:

void print_vector_char(vector<char>);

can you see the difference?