question about code using set_new_handler

[santiagorf]

Hi,
The following code was written based on Chapter 7-Check the return value of new- from Effective C++ (1st edition).

#include <iostream>

using namespace std;

typedef void (*PEHF)();


class X
{
private:
    static PEHF currentPEHF;

public:
    static PEHF set_new_handler(PEHF p);
    void * operator new (size_t size);
    static void noMoreMemory(){
        cout<< "Unable to satisfy request for memory!\n";
    }
    double vec;
};


PEHF X::currentPEHF;

PEHF X::set_new_handler(PEHF p)
{
    PEHF oldPEHF = currentPEHF;
    currentPEHF =p;
    return oldPEHF;
}

void * X::operator new(size_t size)
{
    PEHF currentHandler = ::set_new_handler(currentPEHF);
    void *memory = ::new char[size];
    ::set_new_handler(currentHandler);
    return memory;
}

int main()
{
    X::set_new_handler(X::noMoreMemory);

    X * pX = new X[11111111111];
}

In the main function I create a situation where allocation fails, and I was expecting an error message like this
Unable to satisfy request for memory! since set_new_handler was pointing to noMemory().

The problem is that I get this message instead

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Aborted

which means I'm not using set_new_handler properly.

Any idea where is my mistake?
Thanks in advence

[cire]

Since you're using new[], perhaps you should define X::operator new[].

[santiagorf]

thanks cire. Your hint solved the problem!
I guess I have to add abort() so that the messages doesn't repeat for each failed allocation

static void noMoreMemory(){
        cout<< "Unable to satisfy request for memory!\n";
        abort();
}