C++

Forum

 
hangmann

josepho16 (28)
making a hangman game.
usually use a dictionary file but coded in a single word to guess instead. ("jumping")
running this, it works for a while, but it never goes to the drawMan function, so it never draws the man and you can never lose. why is this? thanks
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
 
 #include <iostream>
#include <string>
#include <cstdlib>
#include <ctime>
#include <vector>
#include <fstream>
using namespace std; //just created a replay function. need to draw the hangman man and set a guess limit
//hangman game--simplified



void askForGuess();
void checkGuess(int lert, string wordToGuess, int* Found, int wrongGuessCounter);
void replay();
void drawMan(int counter);



int main()
{
	string response;
	cout << "Hello. enter 'play' if you wish to start a new game" << endl;
	cin >> response;
	if (response == "play")
	{
		askForGuess();
	}


	replay();
	system("pause");
}





void askForGuess() //asks for input and then checks the input against the hidden word----------------------------------------
{
	system("cls");
	//some ambiguous number for size of array
	int found[20] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 };
	vector<string> words;



	//---------------------------------------------------------
	//open dictionary file
	ifstream dictionary;
	dictionary.open("dictionary.txt");


	//check for error
	if (dictionary.fail())
	{
		cerr << "Failure loading dictionary." << endl;
		system("pause");
		exit(0);
	}


	//pick random word from dictionary
	/*string helper[8000];
	srand(time(0));
	vector<string> word;
	cout << "loading dictionary...\n";
	for (int i = 0; i < 8000; i++)
	{
		dictionary >> helper[i];
		word.push_back(helper[i]);
	}


	//--------------------------------------

	int choice=1 + (rand() % 8000); */
	//string wordToGuess = word[choice];
	string wordToGuess = "jumping";
	int lert=wordToGuess.length();
	for (int i = 0; i < lert; i++)
	{
		cout << '*';

	}
	int wrongGuessCounter = 0;
	
	checkGuess(lert,wordToGuess,&found[20],wrongGuessCounter);
}



void checkGuess(int lert, string wordToGuess, int* Found,int wrongGuessCounter)
{
	

	char letter;
	int finishedW = 0;

	cout << " enter a guess: ";
	cin >> letter;

	for (int j = 0; j < lert; j++)
	{
		if (letter == wordToGuess.at(j))
		{
			cout << wordToGuess.at(j);
			Found[j] = 1;
		}
		else if (Found[j] == 1)
		{
			cout << wordToGuess.at(j);

		}
		
		else
		{
			cout << '*';

		}

		
	}
	for (int k = 0; k < lert; k++)
	{
		finishedW += Found[k];

	}
	if (finishedW == lert)
	{
		cout << "\nYou win! ";
		system("pause");
		replay();
	}
	else if (finishedW == 0)
	{
		
		wrongGuessCounter++;
		drawMan(wrongGuessCounter);
	}

	checkGuess(lert,wordToGuess,Found,wrongGuessCounter);

}




void drawMan(int counter)
{
	
	switch (counter)
	{
	case 1:
		cout << " ________" << endl;
		cout << "|       |" << endl;
		cout << "|       |" << endl;
		cout << "|       O" << endl;
		cout << "|" << endl;
		cout << "|" << endl;
		cout << "|" << endl;
		cout << "|" << endl;
		cout << endl;
		break;

	case 2:
		cout << " ________" << endl;
		cout << "|       |" << endl;
		cout << "|       |" << endl;
		cout << "|       O" << endl;
		cout << "|       |" << endl;
		cout << "|" << endl;
		cout << "|" << endl;
		cout << "|" << endl;
		cout << endl;
		break;


	case 3:
		cout << " ________" << endl;
		cout << "|       |" << endl;
		cout << "|       |" << endl;
		cout << "|       O" << endl;
		cout << "|       |" << endl;
		cout << "|      /" << endl;
		cout << "|" << endl;
		cout << "|" << endl;
		cout << endl;
		break;


	case 4:
		cout << " ________" << endl;
		cout << "|       |" << endl;
		cout << "|       |" << endl;
		cout << "|       O" << endl;
		cout << "|       |" << endl;
		cout << "|      / \\" << endl;
		cout << "|" << endl;
		cout << "|" << endl;
		cout << endl;
		break;


	case 5:
		cout << " ________" << endl;
		cout << "|       |" << endl;
		cout << "|       |" << endl;
		cout << "|       O" << endl;
		cout << "|      \|" << endl;
		cout << "|      / \\" << endl;
		cout << "|" << endl;
		cout << "|" << endl;
		cout << endl;
		break;


	case 6:
		cout << " ________" << endl;
		cout << "|       |" << endl;
		cout << "|       |" << endl;
		cout << "|       O" << endl;
		cout << "|      \|/" << endl;
		cout << "|      / \\" << endl;
		cout << "|" << endl;
		cout << "|" << endl;
		cout << endl;
		cout << "YOU LOSE";
		break;


	}
	


}














void replay()
{
	system("cls");
	char answer;
	cout << "play again? (y/n)";
	cin >> answer;
	if (answer == 'y' || answer == 'Y')
		main();
	else
		exit(0);



}
Codermik (835)

wrongGuessCounter is not being updated from what I can see, plus your code has functions calling themselves - this should be avoided and use a do..while loop instead.

There are other issues such as when I entered j, it filled in j and the i

Anyway, I was bored and decided to write you a better structured version before I went to bed - hopefully you will learn something from it. Please feel free to ask questions if there is something you are not sure about.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
 

#include <iostream>
using namespace std; 

void drawMan(int counter);
void drawWord(char *buf, int size);
bool checkGuess( string word, char *buffer, char guess);
bool checkPrevious(char *buffer, char guess, int len);
bool checkWin(char *buf, int len);


int main()
{

	char *buffer;
	char selection;
	unsigned char tryCount;
	bool playing = true;
	bool finished = false;

	do
	{
		// prepare for a new game
		tryCount = 0;
		finished = false;
		
		// grab your random word here, for test we will use
		// a static word.
		string word = "programmer";
		int len;

		// read the string length
		len = word.length();

		// allocate buffer, fill with *
		buffer = new char[len];
		memset(buffer, '*', sizeof(char)*len);

		do
		{
			// draw buffer
			drawWord(buffer, len);
			cout << endl << "Enter letter: ";
			cin >> selection;
			// was it a good guess
			if (checkGuess(word, buffer, selection))
			{
				// yes, its in the word, was this a win?
				if (checkWin(buffer, len))
				{
					// we have won, let the user know
					cout << endl << "Well done, you guessed the word." << endl;
					finished = true;
				}				
			}
			else
			{
				// nope, wrong guess
				tryCount++;
				// draw man update
				drawMan(tryCount);
				// had 6 attempts?
				if (tryCount == 6) {
					cout << endl << "Unlucky, you failed to guess the word." << endl;
					finished = true;
				}
			}

		} while (!finished);

		do
		{
			cout << "Want to play again?";
			cin >> selection;
			selection = tolower(selection);
		} while (selection != 'n' && selection != 'y');

		if (selection == 'n')
			playing = false;			

		// deallocate memory ready for next word,
		// or because we are exiting.  :)
		delete[]buffer;

	} while (playing);
	
	return 0;
}

// check if ive won
bool checkWin( char *buf, int len)
{
	bool win = true;
	for (int i = 0; i < len;i++)
		if (*(buf + i) == '*')
			win = false;
	return win;
}

// check if my guess is in word.
bool checkGuess( string word, char *buffer, char guess)
{
	bool located = false;

	if (checkPrevious(buffer, guess, word.length()))
		return false;

	for (int i = 0; i < word.length(); i++)
	{
		if (word[i] == guess) {
			*(buffer + i) = word[i];
			located = true;
		}
	}
	return located;
}

// check if ive typed the same letter
bool checkPrevious(char *buffer, char guess, int len)
{
	bool found = false;
	for (int i = 0; i < len; i++)
	{
		if (*(buffer + i) == guess)
			found = true;
	}
	return found;
}

// draw buffer of stars (and found letters)
void drawWord(char *buf, int size)
{
	cout << endl << "Word is " << size << " letters:  ";
	for (int i = 0; i < size; i++)
		cout << *(buf + i);
	cout << endl;
}

// draw man on bad try
void drawMan(int counter)
{
	switch (counter)
	{
		case 1:
			cout << " ________" << endl;
			cout << "|       |" << endl;
			cout << "|       |" << endl;
			cout << "|       O" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << endl;
			break;

		case 2:
			cout << " ________" << endl;
			cout << "|       |" << endl;
			cout << "|       |" << endl;
			cout << "|       O" << endl;
			cout << "|       |" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << endl;
			break;


		case 3:
			cout << " ________" << endl;
			cout << "|       |" << endl;
			cout << "|       |" << endl;
			cout << "|       O" << endl;
			cout << "|       |" << endl;
			cout << "|      /" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << endl;
			break;


		case 4:
			cout << " ________" << endl;
			cout << "|       |" << endl;
			cout << "|       |" << endl;
			cout << "|       O" << endl;
			cout << "|       |" << endl;
			cout << "|      / \\" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << endl;
			break;


		case 5:
			cout << " ________" << endl;
			cout << "|       |" << endl;
			cout << "|       |" << endl;
			cout << "|       O" << endl;
			cout << "|      \|" << endl;
			cout << "|      / \\" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << endl;
			break;


		case 6:
			cout << " ________" << endl;
			cout << "|       |" << endl;
			cout << "|       |" << endl;
			cout << "|       O" << endl;
			cout << "|      \|/" << endl;
			cout << "|      / \\" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << endl;
			cout << "YOU LOSE";
			break;


	}
}
josepho16 (28)
woah ok thanks so much man ill take a look at it
Codermik (835)

Your welcome :)

I had made some changes since my original post, and rather than editing it and just overwriting the old one I posted the full code again just so you could look at the changes.

Basically, I corrected a few things (i was tired when I wrote previous one lol) such as:

1) if a word was in lower case and user was typing capitals it would say wrong letter.
2) regardless of the word in the list being upper or lower case, its always shown in capitals, looks much cleaner - convertCapitals() function.
3) when last letter was guessed, it would say well done etc.. yet the last letter in the word was still starred out.
4) removed stars, used _ and spaced them out - again looks cleaner.

Lastly, I added the function chooseWord() which returns a string - this function would either choose from a string array/vector, or file (your choice) but the example just shows a string array - just keeps things nice and structured.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
 

#include <iostream>
#include <time.h>
using namespace std;

void drawMan(int);
void drawWord(char*, int);
bool checkGuess(string, char*, char);
bool checkPrevious(char*, char, int);
bool checkWin(char*, int);
string convertCapitals(string);
string ChooseWord();


int main()
{
	char *buffer;
	char selection;
	unsigned char tryCount;
	bool playing = true;
	bool finished = false;

	// set seed
	srand(time(0));

	do
	{
		// prepare for a new game
		tryCount = 0;
		finished = false;

		// get our first/next word
		// and its length.
		string word = ChooseWord();
		int len = word.length();

		// change to uppercase.
		word = convertCapitals(word);

		// allocate buffer, fill with _
		buffer = new char[len];
		memset(buffer, '_', sizeof(char)*len);

		do
		{
			// draw buffer
			drawWord(buffer, len);
			cout << endl << "Enter letter: ";
			cin >> selection;

			// uppercase
			selection = toupper(selection);

			// was it a good guess
			if (checkGuess(word, buffer, selection))
			{
				// yes, its in the word, was this a win?
				if (checkWin(buffer, len))
				{
					// we have won, draw buffer and 
					// let the user know
					drawWord(buffer, len);
					cout << endl << "Well done, you guessed the word." << endl;
					finished = true;
				}
			}
			else
			{
				// nope, wrong guess
				tryCount++;
				// draw man update
				drawMan(tryCount);
				// had 6 attempts?
				if (tryCount == 6) {
					cout << endl << "Unlucky, you failed to guess the word." << endl;
					finished = true;
				}
			}

		} while (!finished);

		do
		{
			cout << endl << "Want to play again?";
			cin >> selection;
			selection = tolower(selection);
		} while (selection != 'n' && selection != 'y');

		if (selection == 'n')
			playing = false;

		// deallocate memory ready for next word,
		// or because we are exiting.  :)
		delete[]buffer;

	} while (playing);

	return 0;
}

// convert to capitals.
string convertCapitals(string word)
{
	for (int i = 0; i < (int)word.length(); i++)
		word[i] = toupper(word[i]);
	return word;
}

// check if ive won
bool checkWin(char *buffer, int len)
{
	bool win = true;
	for (int i = 0; i < len; i++)
	if (*(buffer + i) == '_')
		win = false;
	return win;
}

// check if my guess is in word.
bool checkGuess(string word, char *buffer, char guess)
{
	bool located = false;

	if (checkPrevious(buffer, guess, word.length()))
		return false;

	for (int i = 0; i < (int)word.length(); i++)
	{
		if (word[i] == guess) {
			*(buffer + i) = word[i];
			located = true;
		}
	}
	return located;
}

// check if ive typed the same letter
bool checkPrevious(char *buffer, char guess, int len)
{
	bool found = false;
	for (int i = 0; i < len; i++)
	{
		if (*(buffer + i) == guess)
			found = true;
	}
	return found;
}

// select a word from a list
string ChooseWord()
{
	// this function would randomly read a word from a file
	// or array of strings, or a vector and return it back.
	// in this example ive just used a string array
	string words[5] = { "programmer", "elephant", "computer", "phone", "calculator" };
	int choice;
	choice = rand() % 5;  // 0 - 4
	// return word string
	return words[choice];
}

// draw buffer of stars (and found letters)
void drawWord(char *buffer, int size)
{
	cout << endl << "Word is " << size << " letters:  ";
	for (int i = 0; i < size; i++)
		cout << *(buffer + i) << " ";
	cout << endl;
}

// draw man on bad try
void drawMan(int counter)
{
	switch (counter)
	{
		case 1:
			cout << " ________" << endl;
			cout << "|       |" << endl;
			cout << "|       |" << endl;
			cout << "|       O" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << endl;
			break;

		case 2:
			cout << " ________" << endl;
			cout << "|       |" << endl;
			cout << "|       |" << endl;
			cout << "|       O" << endl;
			cout << "|       |" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << endl;
			break;


		case 3:
			cout << " ________" << endl;
			cout << "|       |" << endl;
			cout << "|       |" << endl;
			cout << "|       O" << endl;
			cout << "|       |" << endl;
			cout << "|      /" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << endl;
			break;


		case 4:
			cout << " ________" << endl;
			cout << "|       |" << endl;
			cout << "|       |" << endl;
			cout << "|       O" << endl;
			cout << "|       |" << endl;
			cout << "|      / \\" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << endl;
			break;


		case 5:
			cout << " ________" << endl;
			cout << "|       |" << endl;
			cout << "|       |" << endl;
			cout << "|       O" << endl;
			cout << "|      \|" << endl;
			cout << "|      / \\" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << endl;
			break;


		case 6:
			cout << " ________" << endl;
			cout << "|       |" << endl;
			cout << "|       |" << endl;
			cout << "|       O" << endl;
			cout << "|      \|/" << endl;
			cout << "|      / \\" << endl;
			cout << "|" << endl;
			cout << "|" << endl;
			cout << endl;
			cout << endl << "YOU LOSE";
			break;


	}
}
Topic archived. No new replies allowed.