i need some testers please help me!!! it is for my final

[freecody24]

i had to make a game for my final due in 2 days can you guy play/test it and see how it works? if it works good?
any feed back will help thank you and HAVE FUN PLAYING

  //-------------Mastermind--------------

//Libraries
#include <iostream> 
#include <cstdlib> 
#include <ctime> 


//No Global Constants

//Function Prototypes here
void displayInstructions();
void getInput (char [], char [], int &, char [][4], int, int [], int [], int);
char colorconversion (int);
int numCorrect (char [], char []);
int wrongSpot (char [], char [], int);




//Execution begins here
using namespace std;
int main(int argc, char *argv[]) {
 	//Declare Variables
 	int randNum1, randNum2, randNum3, randNum4; //Variable to convert input to integer
 	char correct[4], guess[4]; //Variable for numbers/colors generated
 	char again; //Input by user to play again
    int numguess=0, guessleft=10; //Number of user guesses


	int wrongS=0, totright=0; //Variable to display the users right guesses and right colors but in wrong spot
	char history[10][4];
	int counter=0, hCorrect[10], hWrongS[10];
 
 	do{
 	displayInstructions(); //Function call to display instructions and begin program.
	 
 	srand(time(0)); //RNG function to generate the correct sequence
 	randNum1=rand()%5+1; //Range the random numbers 1-5
 	randNum2=rand()%5+1;
 	randNum3=rand()%5+1;
 	randNum4=rand()%5+1;
 
 	//Get the Correct Sequence
 	correct[0]= colorconversion(randNum1);
 	correct[1]= colorconversion(randNum2);
 	correct[2]= colorconversion(randNum3);
 	correct[3]= colorconversion(randNum4);
  
 	
 	do{ 
 	

	

	getInput(guess, correct, guessleft, history, counter, hCorrect, hWrongS, totright); 
	
	
    
	
	//Break out if user wins
        if (guess[0]==correct[0] && guess[1]==correct[1] && guess[2]==correct[2] && guess[3]==correct[3]) {
            numguess=10;
        }
        numguess++; //Counter for user guesses
		counter++;
 	} while (numguess<10); //Limit user guesses to 10
        
        //Determine if user wins
 	if (guess[0]==correct[0] && guess[1]==correct[1] && guess[2]==correct[2] && guess[3]==correct[3]) {
 	 cout<<"Congratulations you win!";
 	} else {
        
        //If user loses output correct sequence
  	cout<<"Sorry try again. Correct sequence was "<<correct[0]<<" "<<correct[1]<<
  	" "<<correct[2]<<" "<<correct[3]<<" "<<endl;
	 }
        
        //Prompt user to play again
        cout<<"GOOD GAME"<<endl;
        cin>>again;
		      
        //If user wants to play again reset the guesses counter to zero
        if (again=='Y' || again=='y'){
        numguess=0;
		guessleft=10;
		}
        } while (again=='Y' || again=='y');
        
 	return 0;
}

//Function to display instructions
void displayInstructions () {
 cout<<"I will generate 4 random colors that can each be"
 <<" 1 of 5 colors allowing duplicates."<<endl;
 cout<<"You will get 10 guesses of the colors  and I will tell you after\n" 
         "each guess the number of colors that are correct and in the right position"<<endl;
 cout<<"You have 5 colors to pick from: Green Yellow Red Blue Purple"<<endl;
 cout<<"enter first letter of the color so it could be gyrb = green yellow red blue =D have fun"<<endl;
}


//Function to get users guesses
void getInput (char guess[], char correct[], int &guessleft, char history[][4], int counter, int hCorrect [], int hWrongS[], int totright) {
	
cout<<"Good luck"<<endl; //Output for guesses
 
	
		for(int i =0;i<4;i++){
			cin >> guess[i];
			if (guess[i]>91)
				guess[i]= guess[i]-32;			
				history[counter][i]=guess[i];

		
		
		}
			
			hCorrect[counter]=numCorrect(guess, correct);
					hWrongS[counter]=wrongSpot(guess, correct, hCorrect[counter]);
			
			for (int i=0; i<counter+1; i++){
					cout<<"History "<<i+1 << " ";
					for(int j =0;j<4;j++){
						cout << history[i][j];
                                        }
						
							 							cout<<" Correct= "<<hCorrect[i]<<" Wrong spot= "<<hWrongS[i];

							cout<<endl;
							

			}
			
			
	guessleft--;
	cout<<endl;
	cout<<"Guesses left "<<guessleft<<endl;
	cout<<endl;
	if (guessleft==3)
	cout<<"Warning 3 more tries!!!"<<endl;
	if(guessleft==2)
	cout<<"Warning two tries left"<<endl;
	if(guessleft==1)
	cout<<"Last chance, choose wisely!"<<endl;

}

//Convert random number to a character representing a color
char colorconversion (int passNum) {
 switch (passNum) {
  case 1: 
    return 'G'; 
  break;
  case 2: 
    return 'Y'; 
  break;
  case 3: 
    return 'R'; 
  break;
  case 4: 
    return 'B'; 
  break;
  case 5: 
    return 'P';
  break;
 } 
}

//Function to determine how many colors were correct and in the right spot.
int numCorrect (char guess[], char correct[]){
 int totRight=0;
  if (guess[0]==correct[0]) //Determine if 1st color guess is right
   totRight++;       //If true add 1 to counter
  if (guess[1]==correct[1]) //Determine if 2nd color guess is right
   totRight++;       //If true add 1 to counter
  if (guess[2]==correct[2]) //Determine if 3rd color guess is right
   totRight++;       //If true add 1 to counter
  if (guess[3]==correct[3]) //Determine if 4th color guess is right
   totRight++;       //If true add 1 to counter
 return totRight;                  //Return the number right
}


int wrongSpot(char correct[], char guess[],int totright){
	int greenC=0; 
	int sum=0, keepG, keepY, keepR, keepB, keepP;
	for(int i=0; i<4; i++)
	if (correct[i]=='G'){
	greenC++;
	}
	int green=0;  
	for(int i=0; i<4; i++)
	if (guess[i]=='G'){
	green++;
	}
	if (greenC<=green)
	keepG=greenC;
	else keepG=green;
	

	int yellowC=0;  
	for(int i=0; i<4; i++)
	if (correct[i]=='Y'){
		yellowC++;
	}
	int yellow=0;  
	for(int i=0; i<4; i++)
	if (guess[i]=='Y'){
		yellow++;
	}
	if (yellowC<=yellow)
	keepY= yellowC;
	else keepY= yellow;
	

	int redC=0;  
	for(int i=0; i<4; i++)
	if (correct[i]=='R'){
	redC++;
	}
	int red=0;  
	for(int i=0; i<4; i++)
	if (guess[i]=='R'){
	red++;
	}
	if (redC<=red)
	keepR= redC;
	else keepR= red;
	

	int blueC=0;  
	for(int i=0; i<4; i++)
	if (correct[i]=='B'){
	blueC++;
	}
	int blue=0;  
	for(int i=0; i<4; i++)
	if (guess[i]=='B'){
	blue++;
	}
	if (blueC<=blue)
	keepB= blueC;
	else keepB= blue;

	int purpleC=0;  
	for(int i=0; i<4; i++)
	if (correct[i]=='P'){
	purpleC++;
	}
	int purple=0;  
	for(int i=0; i<4; i++)
	if (guess[i]=='P'){
	purple++;
	}
	if (purpleC<=purple)
	keepP= purpleC;
	else keepP= purple;
	sum=keepG+keepY+keepR+keepB+keepP;
	return sum-totright;
}

[machinafour]

Just commenting on how well it works rather than code design.

It's good! I beat it second time. But you need to make the program end when either the player runs out of guesses or when they solve it.

[freecody24]

thanks for the feed back

ya i need to add a loop at the end asking if the player would like to play again =D

@machinafour when you say (Just commenting on how well it works rather than code design.) are you saying the code design is not that good?

[machinafour]

No, I just didn't look through it, I only tested the game :)

[MiiNiPaa]

Problems:
1) Unused variables and unused parameter in function getInput.
2) Use tolower(), do not substract 32. It will not work for every enviroment.
3) Inconsistent and downright confusing identation, unneeded empty lines.

Also several parts are too verbose but it is fine for beginner.

[dhayden]

Fix the things that MiiNiPaa mentioned. Then save the file somewhere before making further changes. You don't want to break the code while trying to "make it better." If you decide to do any of these changes then do them one at a time. Test after each one and save the work again. The point is that you want to save a good version when you have one.

If the user wants to play again, you need to set counter back to zero.

You're doing too much in getInput(). Notice for example that if you solve the puzzle with 3 or fewer tries left, it will give you a warning and then say you solved it. I'd divide this up into 3 functions: getInput() should get the input and update the counts (lines 107-121). PrintHistory() should do what's in 123-134. PrintWarning() should do lines 138-146.

Once you have this, the guessing loop will clean up nicely:

guessInput();
if (hCorrect[counter] == 4) {
    numguess = 10;
} else {
    guessleft--;
    PrintHistory();
    PrintWarning();
    numguess++;
    counter++;
}

Sometimes it's easier to do something with data than with code. Colorconversion could be done like this:

char 
colorconversion(int passNum)
{
    static char map[] = "?GYRBP";
    return map[passNum];
}

NumCorrect should be done with a loop.

WrongSpot() could probably be done with some loops too.