not printing out a few statements for the output

[STCXSL3A]

i want the output be like:

5 total

3 invalid

2 valid

at the end

but it doesnt print the invalid or valid and total prints out after every run instead of at the end

void classify(int x, int y, int z)
{
   cout << "success";
    return ;
}

[srscode]

Do you want your output to be at the end of each iteration, or when your loop stops?

[giblit]

This was the exact post as http://www.cplusplus.com/forum/beginner/147280/ before you edited it.

[STCXSL3A]

i want the output when the loop stops. sorry wasnt that clear earlier.

yeah that was my thread from yesterday but fixed lots of mistakes.

[giblit]

Well on line 19 you are calling the function that does the output. If you want it after the loop maybe do recursion or use a dynamic container such as a vector.

[srscode]

Try this:

EDIT:

#include <iostream>

using namespace std;

void classify (int,int,int);
bool validset(int,int,int);
bool validOrNot(void);

int main()
{
    int valid = 0;
    int invalid = 0;
    int x,y,z;
    char answer;
    int total = 0;
    bool validsetResult; 

    do  {
         cout <<    "Type in the first score" << endl;
         cin >> x;
         cout <<    "Type in the second score" << endl;
         cin >> y;
         cout <<    "Type in the third score" << endl;
         cin >> z;
         total++;
         
         if(validOrNot() == false)
         {
             cout << "The group is invalid" << endl;
             invalid++;
         }
         else if(validOrNot() == true)
         {
             cout << "The group is valid" << endl;
             valid++;
         }
         
         if (validset(x, y, z) == true)
         classify (x,y,z);
         else;
         cout <<    "Type c to continue; s to stop";
         cin >> answer;
         } while (answer == 'c');
         
         
         
         cout << total << " total" << endl;
         cout << valid << " valid" << endl;
         cout << invalid << " invalid" << endl;
         
 
         return 0;
}

bool validset(int x, int y, int z)
{

    int vali = 0;
    int invali = 0;

    if (x < 0 || x > 300)
{
        cout << "The group is invalid" << endl;
        invali++;
        return(false);
}
    else if (y < 0 || y > 300)
{
        cout << "The group is invalid" << endl;
        invali++;
        return(false);
}
    else if (z < 0 || z > 300)
{
        cout << "The group is invalid" << endl;
        invali++;
        return(false);
}
    else
{
        vali++;
        return(true);

        cout << vali;
        cout << invali;
}
return(false);
}

void classify(int x, int y, int z)
{
   cout << "success" << endl;
    return ;
}

bool validOrNot(void)
{
    int x, y, z;
    if(validset(x, y, z))
    {
        return true;
    }
    
    else if(validset(x, y, z) == true)
    {
        return false;
    }
}   

[giblit]

That still outputs while it is iterating and not after it finishes iterating.

[srscode]

It outputs after the loop ends just as he asked for:

i want the output be like:

5 total

3 invalid

2 valid

at the end

[STCXSL3A]

thanks srscode i tweaked ur code a bit and it worked perfectly thank you so much

[giblit]

Okay so he still wants it to print the "group is invalid" I was under the assumption he didn't want it to print anything until it was over. You may be right.

[srscode]

I did edit my first solution to a better version in case you didn't notice. :)

[giblit]

By the way

    if (x < 0 || x > 300)
{
        cout << "The group is invalid" << endl;
        invali++;
        return(false);
}
    else if (y < 0 || y > 300)
{
        cout << "The group is invalid" << endl;
        invali++;
        return(false);
}
    else if (z < 0 || z > 300)
{
        cout << "The group is invalid" << endl;
        invali++;
        return(false);
}

can be one if such as

if(x < 0 || y < 0 || z < 0 || x > 300 || y > 300|| z > 300)
{
    cout << "The group is invalid" << endl;
    ++invalid;
    return false;
}
else
{
    ++valid;
    return true;
}