SFML and matrix drawing

[NoBark]

I've been working on this for a while and after cleaning it up/optimising it,
nothing wanted to show up anymore

#include <SFML/Window.hpp>
#include <SFML/Graphics.hpp>
#include <iostream>
#include <fstream>
#include <cctype>
#include <vector>
#include <sstream>

class character
{

public:
	character()
	{
		//coords
		x = 0;
		y = 0;

	}
	int x;
	int y;

	void keymove();

	sf::Sprite pSprite;
	sf::Texture ptexture;

};

/*...*/

void LoadMap(const char*filename)
{
	std::fstream openfile("map.txt");

	sf::Texture tileTexture;
	sf::Sprite tiles;

	std::vector<std::vector<sf::Vector2i>> map;
	std::vector<sf::Vector2i> tempMap;

	if (openfile.is_open() && !openfile.eof())
	{

		std::string str;
		std::getline(openfile, str);
		tileTexture.loadFromFile(str);
		tiles.setTexture(tileTexture);

		while (!openfile.eof())
		{
			std::getline(openfile, str);
			std::stringstream stream(str);
			std::string value;

			while (std::getline(stream, value, ' '))
			{
				if (value.length() > 0)
				{
					std::string x = value.substr(0, value.find(','));
					std::string y = value.substr(value.find(',') + 1);
					
					tempMap.push_back(sf::Vector2i(stoi(x), stoi(y)));
				}

			}

			map.push_back(tempMap);
			tempMap.clear();

		}
	}
}
int main()
{

	std::vector<std::vector<sf::Vector2i>>map;
	std::vector<sf::Vector2i> tempMap;

	sf::Texture tileTexture;
	sf::Sprite tiles;

	LoadMap("map.txt");
	sf::RenderWindow Window(sf::VideoMode(800, 600), "Window name");

	Window.setKeyRepeatEnabled(false);

	character midget;

	sf::Texture ptexture;
	if (!midget.ptexture.loadFromFile("player.png", sf::IntRect(32, 0, 32, 32)))
		std::cout << "Error player.png";
	ptexture.setSmooth(true);


	while (Window.isOpen())
	{
		sf::Event Event;
		while (Window.pollEvent(Event))
		{
			switch (Event.type)
			{
			case sf::Event::Closed:
				Window.close();
				break;
			case sf::Event::KeyPressed:
				if (Event.key.code == sf::Keyboard::Escape)
				{
					Window.close();
					break;
				}
				else if(Event.key.code == sf::Keyboard::L)
				{
					LoadMap("map.txt");
					break;
				}
	
			}
		}
		Window.clear();

		midget.keymove();
		sf::Sprite pSprite;
		sf::Texture ptexture;
		if (!midget.ptexture.loadFromFile("player.png", sf::IntRect(32, 0, 32, 32)))
			std::cout << "Error player.png";
		ptexture.setSmooth(true);
		pSprite.setTextureRect(sf::IntRect(32, 0, 32, 32));
		Window.draw(midget.pSprite);
		Window.display();
	}
}

aand im clueless why it does so

[Yanson]

keymove() is undefined so this shouldn't even compile.


Don't load textures in a loop you should load a texture into memory exactly once. Any more than that and you are just wasting memory.


Delete all of this from your loop

		midget.keymove();
		sf::Sprite pSprite;
		sf::Texture ptexture;
		if (!midget.ptexture.loadFromFile("player.png", sf::IntRect(32, 0, 32, 32)))
			std::cout << "Error player.png";
		ptexture.setSmooth(true);
		pSprite.setTextureRect(sf::IntRect(32, 0, 32, 32));

nothing wanted to show up anymore.

You load your player.png into memory but you never pass it to your characters sprite.

ie. midget.pSprite.setTexture(midget.ptexture);



You do realize that ptexture and midget.ptexture are two different things?

	sf::Texture ptexture;
	if (!midget.ptexture.loadFromFile("player.png", sf::IntRect(32, 0, 32, 32)))
		std::cout << "Error player.png";
	ptexture.setSmooth(true);

you never actually do anything with ptexture.