why does this code throw an error

[SECMoG1T]

Hi , am faced with a little bug here, I don't get why my compiler couldn't afford to convert the parameter in my constructor to a reference, instead it throws this error,please help me understand why, I will gladly appreciate your help


no match to function call foo::foo(std::string)

  class foo
   {
     public:
         foo (std::string &s1);
     private:
         std::string str;
   }

   foo::foo (std::string &s1) :str (s1) {}

   int main ()
   {
     std::string st ("hello");
     
     foo var(st); ///this works
     foo var1 (std::string(" hi ")); /// this throws an error. 
   }

Thanks in advance.

[Yanson]

FYI you have a syntax error in your code you need a ';' at the end of your class

To answer your question you cant reference a temporary object unless its by const reference



This should work

#include <iostream>
#include <string>


class foo
{
public:
	foo(const std::string &s1);
private:
	std::string str;
};

foo::foo(const std::string &s1) :str(s1) {}

int main()
{
	std::string st("hello");

	foo var(st); ///this works
	foo var1(std::string(" hi ")); /// this throws an error.


	std::cin.ignore();
	return 0;
}

[SECMoG1T]

Absolutely correct it's workin now, thank you very much @Yanson for the insight, how I dint realize my
std::string ("hi"); was a temporal object, I definetly got no idea.
For the missing ',' , that was definitely a typo, probably am very weary by now and should have a little break.

Cheers man.