How to rename a file?

[sectumsempra]

The part of code where I rename the file just won't work. I tried writing it separately in another project, it works. And yes, I've tried closing "myfile" before renaming it Help me please.

  #include <iostream>
#include <stdio.h>
#include <fstream>

using namespace std;

int main () {
	char address[] = "";
	char newname[] = "";
	int action;
	char confirm;
	int result;
	
	cout << "File Manipulator 1.0" << endl;
	cout << "--------------------" << endl << endl;
	cout << "Type the full address of a file you wish to manipulate." << endl << endl;
	ADDRESS:cin >> address;
	fstream myfile;
	myfile.open(address);
	if (!myfile.good()) {
		cout << "The selected file does not exist! Would you like to create it? ";
		goto ADDRESS;
	} else {
		cout << endl << "-----------------------------------" << endl;
		cout << "Type 1 to move the selected file." << endl;
		cout << "Type 2 to rename the selected file." << endl;
		cout << "Type 3 to delete the selected file." << endl;
		cout << "-----------------------------------" << endl << endl;
		ACTION:cin >> action;
		
		if (action == 1) {
			cout << 1;
		} else if (action == 2) {
			cout << "Enter the new name: ";
			cin >> newname;
			cout << "Are you sure you want to rename the selected file? Y/N ";
			CONFIRM:cin >> confirm;
			if (confirm == 'Y' || 'y') {
				myfile.close();
				rename(address, newname);
				
			} else if (confirm == 'N' || 'n') {
				cout << "No";
			} else {
				cout << "You typed an invalid command! Try again. ";
				goto CONFIRM;
			}
		} else if (action == 3) {
			cout << 3;
		} else {
			cout << "You typed an invalid command! Try again." << endl;
			goto ACTION;
		}
	}
	return 0;
}

BTW the whole code is not finished, so check just the renaming part. Thanks.

[ultifinitus]

You didn't specify a buffer size for your array/strings, add a size your code will work.

However there are other things that should be mentioned:

1. You can't use anything with a space in the file name in your code. (eg. c:\\documents and settings\\blahblahblah.txt)

2. You may want to consider using std::string instead of char arrays, but your code=your call

3. You'll start a flame war using goto :)

[sectumsempra]

Can you please be more specific about how to fix the problem.

1. Not using the space, I'm aware of that, it's a char ofc.
2. Tried with strings also, same issue.
3. I have it under control :P

[rafae11]

http://www.cplusplus.com/reference/cstdio/rename/

[rafae11]

the code is not complete but it works in renaming the file.

#include <iostream>
#include <cstdio>
#include <fstream>
#include <string>

using namespace std;

int main() 
{
	std::string address;
	std::string newname;
	char input;
	int action;
	char confirm;
	int result;

	cout << "File Manipulator 1.0" << endl;
	cout << "--------------------" << endl << endl;
	cout << "Type the full address of a file you wish to manipulate." << endl << endl;
	
	std::getline(std::cin, address);
		
	ifstream myfile(address);

	// try to open the file
	if (myfile.is_open())
	{		
		cout << "File Good" << std::endl;
		myfile.close();
	}
	else
	{
		cout << "The selected file does not exist! Would you like to create it? ";
		std::cin >> input;	

		if (input == 'y' || input == 'Y')
		{
			// create the file.
			ofstream output(address.c_str());
			output.close();

			cout << endl << "-----------------------------------" << endl;
			cout << "Type 1 to move the selected file." << endl;
			cout << "Type 2 to rename the selected file." << endl;
			cout << "Type 3 to delete the selected file." << endl;
			cout << "-----------------------------------" << endl << endl;

			std::cin >> action;

			switch (action)
			{
				case 1:
				{	
					// do nothing.
				}
				break;

				case 2:
				{
					// rename file.
					std::cout << "Enter the new name" << endl << endl;	
					cin.ignore();
					std::getline(std::cin, newname);
					std::cout << "Are you sure you want ot rename the selected file ? Y/N" << endl << endl;
					std::cin >> confirm;

					if (confirm == 'Y' || confirm == 'y')
					{
						rename(address.c_str(), newname.c_str());
					}
					
					
				}
				break;
				
				case 3:
				{
					// delete file.
					std::remove(address.c_str());
				}
				break;

				default:
				{
					std::cout << "You typed an invalid command!" << std::endl;
				}
				break;
			}
		}
		


	}
	
	system("pause");
	return 0;
}

[ultifinitus]

To be more specific, change

     char address[] = "";
     char newname[] = "";

To both have an array size instead of a blank size.

[sectumsempra]

@rafae11 the code u provided works perfect on an online c++ shell, but still doesn't work for me. Line 23 gives me an error:
[Error] no matching function for call to 'std::basic_ifstream<char>::basic_ifstream(std::string&)'

[rafae11]

http://stackoverflow.com/questions/6323619/c-ifstream-error-using-string-as-opening-file-path

ifstream myfile(address);

to

ifstream myfile(address.c_str());