code reads outputs results twice for some reason
Apr 28, 2015 at 7:25pm UTC
Hello. I am writing a code for a school project which asks me to read in certain values from 2 text files and then output them to another file called report.txt. Here is a little snippet of my code:
1 int main()
{
ifstream materialProperties;
ifstream testCases;
ofstream report;
materialProperties.open("material_properties.txt" );
testCases.open("test_cases.txt" );
report.open("report.txt" );
// Counter for Test Case
int n = 1;
// Counter for "Acceptable"
int x = 0;
// Use while loop to go through n lines of code
while (not testCases.fail())
{
// Read in test_cases.txt
testCases >> timeTaken;
testCases >> tempDiff;
testCases >> height;
testCases >> thickness;
testCases >> htThreshold;
testCases >> ysThreshold;
testCases >> cThreshold;
testCases >> numMaterials;
report << "Test Case " << n << endl;
report << "Q = " << htThreshold << endl;
report << "S = " << ysThreshold << endl;
report << "C = " << cThreshold << endl;
report << "Processing " << numMaterials << " materials" << endl;
// Series of nested loops going through all possible varitions
.....
else if (numMaterials == 2)
{
testCases >> one;
testCases >> two;
if (one == 1 && (slumpyQ > htThreshold) && (slumpyYS > ysThreshold) && (slumpyCost < cThreshold))
{
report << "Slumpy Wetcrete is acceptable" << endl;
x = x+1;
}
else if (one == 1 && ((slumpyQ < htThreshold) || (slumpyYS < ysThreshold) || (slumpyCost > cThreshold)))
{
report << "Slumpy Wetcrete is unacceptable" << endl;
}
else if (one == 2 && (skyQ > htThreshold) && (skyYS > ysThreshold) && (skyCost < cThreshold))
{
report << "Sky Iron is acceptable" << endl;
x = x+1;
}
else if (one == 2 && ((skyQ < htThreshold) || (skyYS < ysThreshold) || (skyCost > cThreshold)))
{
report << "Sky Iron is unacceptable" << endl;
}
else if (one == 3 && (primalQ > htThreshold) && (primalYS > ysThreshold) && (primalCost < cThreshold))
{
report << "Primal Iron Strongcrete is acceptable" << endl;
x = x+1;
}
else if (one == 3 && ((primalQ < htThreshold) || (primalYS < ysThreshold) || (primalCost > cThreshold)))
{
report << "Primal Iron Strongcrete is unacceptable" << endl;
}
else if (one == 4 && (fluffyQ > htThreshold) && (fluffyYS > ysThreshold) && (fluffyCost < cThreshold))
{
report << "Fluffy Marshmallent is acceptable" << endl;
x = x+1;
}
else if (one == 4 && ((fluffyQ < htThreshold) || (fluffyYS < ysThreshold) || (fluffyCost > cThreshold)))
{
report << "Fluffy Marshmallent is unacceptable" << endl;
}
else if (one == 5 && (wimpyQ > htThreshold) && (wimpyYS > ysThreshold) && (wimpyCost < cThreshold))
{
report << "Wimpy Pig Ironcrete is acceptable" << endl;
x = x+1;
}
else if (one == 5 && ((wimpyQ < htThreshold) || (wimpyYS < ysThreshold) || (wimpyCost > cThreshold)))
{
report << "Wimpy Pig Ironcrete is unacceptable" << endl;
}
else if (one == 6 && (airQ > htThreshold) && (airYS > ysThreshold) && (airCost < cThreshold))
{
report << "Air Entrained Polycarbonate is acceptable" << endl;
x = x+1;
}
else if ( one == 6 && ((airQ < htThreshold) || (airYS < ysThreshold) || (airCost > cThreshold)))
{
report << "Air Entrained Polycarbonate is unacceptable" << endl;
}
else
{
report << "Unknown material is unacceptable" << endl;
}
if (two == 1 && (slumpyQ > htThreshold) && (slumpyYS > ysThreshold) && (slumpyCost < cThreshold))
{
report << "Slumpy Wetcrete is acceptable" << endl;
x = x+1;
}
else if (two == 1 && ((slumpyQ < htThreshold) || (slumpyYS < ysThreshold) || (slumpyCost > cThreshold)))
{
report << "Slumpy Wetcrete is unacceptable" << endl;
}
else if (two == 2 && (skyQ > htThreshold) && (skyYS > ysThreshold) && (skyCost < cThreshold))
{
report << "Sky Iron is acceptable" << endl;
x = x+1;
}
else if (two == 2 && ((skyQ < htThreshold) || (skyYS < ysThreshold) || (skyCost > cThreshold)))
{
report << "Sky Iron is unacceptable" << endl;
}
else if (two == 3 && (primalQ > htThreshold) && (primalYS > ysThreshold) && (primalCost < cThreshold))
{
report << "Primal Iron Strongcrete is acceptable" << endl;
x = x+1;
}
else if (two == 3 && ((primalQ < htThreshold) || (primalYS < ysThreshold) || (primalCost > cThreshold)))
{
report << "Primal Iron Strongcrete is unacceptable" << endl;
}
else if (two == 4 && (fluffyQ > htThreshold) && (fluffyYS > ysThreshold) && (fluffyCost < cThreshold))
{
report << "Fluffy Marshmallent is acceptable" << endl;
x = x+1;
}
else if (two == 4 && ((fluffyQ < htThreshold) || (fluffyYS < ysThreshold) || (fluffyCost > cThreshold)))
{
report << "Fluffy Marshmallent is unacceptable" << endl;
}
else if (two == 5 && (wimpyQ > htThreshold) && (wimpyYS > ysThreshold) && (wimpyCost < cThreshold))
{
report << "Wimpy Pig Ironcrete is acceptable" << endl;
x = x+1;
}
else if (two == 5 && ((wimpyQ < htThreshold) || (wimpyYS < ysThreshold) || (wimpyCost > cThreshold)))
{
report << "Wimpy Pig Ironcrete is unacceptable" << endl;
}
else if (two == 6 && (airQ > htThreshold) && (airYS > ysThreshold) && (airCost < cThreshold))
{
report << "Air Entrained Polycarbonate is acceptable" << endl;
x = x+1;
}
else if (two == 6 && ((airQ < htThreshold) || (airYS < ysThreshold) || (airCost > cThreshold)))
{
report << "Air Entrained Polycarbonate is unacceptable" << endl;
}
else
{
report << "Unknown material is unacceptable" << endl;
}
report << x << " of 2 were acceptable" ;
report << endl;
}
n = n+1;
}
}
For some reason, when I go to report, the results are inputted twice for some reason. The report.txt looks like this:
1Test Case 1
Q = 90000
S = 800
C = 600000
Processing 2 materials
Wimpy Pig Ironcrete is unacceptable
Air Entrained Polycarbonate is unacceptable
0 of 2 were acceptable
Test Case 2
Q = 90000
S = 800
C = 600000
Processing 2 materials
Wimpy Pig Ironcrete is unacceptable
Air Entrained Polycarbonate is unacceptable
0 of 2 were acceptable
Why are the results inputted twice and how do I fix it? Any help is appreciated
Apr 29, 2015 at 4:20pm UTC
The problem is probably being caused by this line:
while (not testCases.fail())
The stream won't fail until you actually read the file, which would happen right after you do this test. You really should either use the read operation it's self or pre-read the file prior to the loop, and move the reading that is inside the loop to the end of the loop.
1 while (testCases >> timeTaken >> tempDiff >> height >> thickness >> htThreshold
>> ysThreshold >> cThreshold >> numMaterials)
{
Topic archived. No new replies allowed.
