Good way to start a login system

[Blackhart98]

Hello I am trying to wonder how would someone go about starting a login system? Just want criticism on how this looks so far it is far from complete just want the most constructive criticism throw it at me.
StudentID

  #include "StudentsID.h"
#include <iostream>
using namespace std;

//Created by Justin
StudentsID::StudentsID()
{
    password = NULL;
    username;

}

void StudentsID::Displayusername(string TheUsername)
{

   for (int i = 0; i < username.size(); i++)
    cout << username[i] << endl;
}
vector <string> StudentsID::getusername()
{
return username;
}
void StudentsID::Adduser(string user)
{
    username.push_back(user);
}
void StudentsID::setpassword(bool *ThePassword)
{
    *ThePassword = &password;

}
bool StudentsID::Getpassword()
{
    
    if (password == password)
    {
        return true;
    }
    else
    {
        return false;
        return 1;
    }
    return password;
}

StudentID.h

#ifndef STUDENTSID_H
#define STUDENTSID_H
#include <iostream>
#include <vector>
using namespace std;
class StudentsID
{
    public:
        StudentsID();
        void setpassword(bool *ThePassword);
        bool Getpassword();
        void Displayusername(string TheUsername);
        vector <string> getusername();
        void Adduser (string user);
    protected:

    private:
        bool password;
       vector <string> username;

};

#endif // STUDENTSID_H

--Blackhart

[mutexe]

why are you using pointers? surely the password should be string?

and this:

       return false;
        return 1;

make no sense.

You need a mechanism of mapping the user to their password (std::map maybe?)

edit:

These:

void StudentsID::Displayusername(string TheUsername)
{

   for (int i = 0; i < username.size(); i++)
    cout << username[i] << endl;
}

are not doing what you think they are. There is not point in iterating through all the characters in a username, you can just cout the whole thing in one go.

perhaps you meant something like this:

void StudentsID::Displayusernames(vector<string> usernames)
{

   for (int i = 0; i < usernames.size(); i++)
   {
       cout << username[i] << endl;
   }
}

? i.e. display all the usernames in your vector?

[Blackhart98]

Thanks yeah I noticed some of these mistakes I will fix them.