Class function performing on an operator

[brawdyll]

I figured out how the operator errors but now I am unsure about how to make fracMult(f2) be preformed on f1. I would really appreciate any input about the right code to make it work

  class fraction

{
    private:
        int numerator;
        int denom;
        bool positive;
    
    public:
        void inputFrac();
        void printFrac();
     
        fraction fracMult(fraction b);
        fraction fracDiv(fraction b);
        fraction fracAdd(fraction b);
        fraction fracSub(fraction b);
};

 void fraction::printFrac()
{
    if (!positive)
    {
    cout << "-";
    }
    cout << numerator << " / " << denom;
}
void fraction::inputFrac()
{    
    cout<<"Please input the numerator ";
    cin>>numerator;
    cout<< "Please input the denominator ";
    cin>>denom;           
}

 fraction fraction::fracMult(fraction b)
{
     
     numerator=b.numerator;
     denom=b.denom;
}

int main(int argc, char** argv) {

    fraction f1, f2, fresult;
    
    f1.inputFrac(); //input the first fraction
    f2.inputFrac(); //input the second fraction
    cout<<endl;
    f1.printFrac();
    cout<<endl;
    f2.printFrac();
    cout<<endl;

    cout << "The result of a * b is: ";
    
    fresult = f1.fracMult(f2); // calculate a * b
    fresult.printFrac(); // print out the result 

[Peter87]

fracMult has return type void. It doesn't return anything. That's why it doesn't work when you try to assign the result to the variable fresult.

[tallyman]

fracMult is void (no return type) so line 57 is wrong. fresult is not needed, along with top & bottom inside of fracMult.

Additionally, how do you set fraction::positive? Right now I see that you don't.

[brawdyll]

There tallyman i moved it over here and changed the code

[tallyman]

f1.fracmult(f2) actually does what you want it to do. It multiplies f1 & f2, and assigns the resulting value to f1. So, you should make the return type void once again, and remove fresult altogether if that is what you're going for.

[teez]

To add to what has been said. Your method fracMult is doing everything apart from multiplying the two fractions. Check line 38 and 39!
You are simply just assigning the numerator and denominator of f2 to f1.

In as much as I do not intend to query the purpose of your program, what is this code

if (!positive)
    {
    cout << "-";
    }

used to archive in printFrac because I don't see where else, that variable is been toggled.

[48T7M4Gy]

http://www.cplusplus.com/forum/beginner/179750/