Problem with maze generator not completing itself

[lilbigwill99]

I'm not too sure what the problem is at all, but what should happen is in the maze generation function I have 2 vectors, 1 for row, 1 for column. I set random values to the first element in both vectors and then use the recursive function. every time the recursive function runs, it adds a new element. if there are no more moves for the recursive function it deletes the last element and tries again. (I am really sorry I suck at explaining things)

TL:DR;
My maze should complete the whole square, not only make a path, or split off into two different mazes, or stop at all honestly until I run out of elements in the vector {which is the starting point}

#include <iostream>
#include <ctime>
#include <cstdlib>
#include <vector>
using namespace std;

class theMapClass{
public:

    theMapClass(){//constructor

        srand(time(0));


    }//ends constructor




    char themaze[25][25];  //must be odd in each dimension

    vector<int> x;
    vector<int> y;




    void generateTheMaze(){

        int startRowroll = 1+rand()%25;
        int startColroll = 1+rand()%25;

        while(startRowroll%2 == 1){           //the starting numbers must be odd for it to work right
            startRowroll = 1+rand()%25;
        }

        while(startColroll%2 == 1){
            startColroll = 1+rand()%25;
        }

        int r = startRowroll;
        int c = startColroll;

        /////delete later
        r = 13;
        c = 13;
        /////////////////


        x.push_back(r);
        y.push_back(c);

        themaze[r][c] = ' ';


        while(x.size() != 0 || y.size() != 0){

            r = x.back();
            c = y.back();

            recursion(r, c, themaze);




            x.pop_back();
            y.pop_back();
        }//ends while loop





    }//ends maze generation

    void printTheMaze(){

        for(int r=0; r<25; r++){
            for(int c=0; c<25; c++){
                cout << themaze[r][c] << " ";

            }

            cout << endl;

        }



    }

    void makeTheWallsForTheMaze(){

        for(int r=0; r<25; r++){
            for(int c=0; c<25; c++){        //making a 25 by 25 "# wall" grid
                themaze[r][c] = '#';

            }

        }

    }

    void recursion(int row, int column, char maze[25][25]){

        // 1 is up, 2 is left, 3 is down, 4 is right //

        int r1, r2, r3, r4;

        r1 = 1+rand()%4;

        if(r1 == 1){
             if(maze[row-2][column] == '#'){

                    maze[row-1][column] = ' ';
                    maze[row-2][column] = ' ';
                    row -= 2;
                    x.push_back(row);
                    y.push_back(column);
                    recursion(row, column, maze);
            }

        }//ends 1 or up

        if(r1 == 2){
             if(maze[row][column-2] == '#'){

                    maze[row][column-1] = ' ';
                    maze[row][column-2] = ' ';
                    column -= 2;
                    x.push_back(row);
                    y.push_back(column);
                    recursion(row, column, maze);
            }

        }//ends 2 or left

        if(r1 == 3){
             if(maze[row+2][column] == '#'){

                    maze[row+1][column] = ' ';
                    maze[row+2][column] = ' ';
                    row += 2;
                    x.push_back(row);
                    y.push_back(column);
                    recursion(row, column, maze);
            }

        }//ends 3 or down

        if(r1 == 4){
             if(maze[row][column+2] == '#'){

                    maze[row][column+1] = ' ';
                    maze[row][column+2] = ' ';
                    column += 2;
                    x.push_back(row);
                    y.push_back(column);
                    recursion(row, column, maze);
            }

        }//ends 4 or right





    }//ends recursion




    void MAZECREAION(){

        makeTheWallsForTheMaze();
        generateTheMaze();
        printTheMaze();

    }


};



int main(){

    theMapClass mapobject;

    mapobject.MAZECREAION();

    return 0;
}

[lilbigwill99]

in the recursion function, I have 3 unused variables I forgot to delete, I'm sorry.

[cire]

Maybe I'm not seeing it, but where is any effort made to ensure recursion is called with valid row and column parameters?

[lilbigwill99]

@cire I'm not too sure what you mean by "valid" parameters. When recursion is called within itself, it uses the same int "row" or int "column" that recursion requires for an argument for itself. when recursion is called outside of itself, the argument is plugged in with variables that will be changed in recursion itself to be entered as parameters again until there aren't any more options.

sorry I suck at explaining things.