logical error with Fstream

[om4r97]

i have to initializes data from file and use array of struct to output the final result

my text File

Sam Albert 18 20162176110 86.7 Math101 CS101 Bio101
Sara Ali 21 20150091030 65.2 CS112 Physics102 CIS240
John Mathio 20 20160175098 70.8 English112 NES201 EE212

My code

  

#include<iostream>
#include<string>
#include<fstream>

using namespace std;

struct PersonInfo {

	string FirstName;
	string LastName;
		int Age;

};


struct StudentInfo {

	PersonInfo HumanBeing;
	unsigned long long int UniversityID;
	double GPA;
	string Courses[3];
};



void print (StudentInfo s[] , int size ) 
{
for ( int i = 0 ; i < size ; i++)
{
cout<<"Full Name :\t"<<s[i].HumanBeing.FirstName<<" "<<s[i].HumanBeing.LastName<<endl;
cout<<"Unversity ID : "<<s[i].UniversityID<<endl;
cout<<"Age : "<<s[i].HumanBeing.Age<<endl;
cout<<"GPA : "<<s[i].GPA<<endl;
for ( int j = 0 ; j <= i ; j++){
	cout<<"Course Taken : "<<s[i].Courses<<" ";
}

}
cout<<endl;

}





void initializes (StudentInfo s[], int x)
{


	ifstream i;
	ofstream o;
	i.open("lol.txt");
	while (!i.eof())
	{

		for (int j = 0; j < 3; j++)
		{

			for (int b = 0; b < 3; b++)
			{ 
			i >> s[j].HumanBeing.FirstName >> s[j].HumanBeing.LastName >> s[j].HumanBeing.Age >> s[j].UniversityID >> s[j].GPA >> s[j].Courses[b];
			}
		}


	}
	

}


int main() {
	ifstream i;
	ofstream o;
	int x = 3;
	StudentInfo s[3];
	initializes(s, x);
		 print (s , 3);

	

}

[SakurasouBusters]

Remove an unnecessary for loop.

for (int b = 0; b < 3; b++)
{ 
	i >> s[j].HumanBeing.FirstName >> s[j].HumanBeing.LastName >> s[j].HumanBeing.Age >> s[j].UniversityID >> s[j].GPA >> s[j].Courses[b];
}

Should be :
i >> s[j].HumanBeing.FirstName >> s[j].HumanBeing.LastName >> s[j].HumanBeing.Age >> s[j].UniversityID >> s[j].GPA >> s[j].Courses[b];

You don't have good variable naming in some of your variables it seems.

[om4r97]

do you mean this

#include<iostream>
#include<string>
#include<fstream>

using namespace std;

struct PersonInfo {

	string FirstName;
	string LastName;
		int Age;

};


struct StudentInfo {

	PersonInfo HumanBeing;
	unsigned long long int UniversityID;
	double GPA;
	string Courses;
};



void print (StudentInfo s[] , int size ) 
{
for ( int i = 0 ; i < size ; i++)
{
cout<<"Full Name :\t"<<s[i].HumanBeing.FirstName<<" "<<s[i].HumanBeing.LastName<<endl;
cout<<"Unversity ID : "<<s[i].UniversityID<<endl;
cout<<"Age : "<<s[i].HumanBeing.Age<<endl;
cout<<"GPA : "<<s[i].GPA<<endl;
cout<<"Course Taken : "<<s[i].Courses<<" ";


}


}





void initializes (StudentInfo s[], int x)
{


	ifstream i;
	ofstream o;
	i.open("lol.txt");
	while (!i.eof())
	{

		for (int j = 0; j < 3; j++)
		{

			
			i >> s[j].HumanBeing.FirstName >> s[j].HumanBeing.LastName >> s[j].HumanBeing.Age >> s[j].UniversityID >> s[j].GPA >> s[j].Courses;
		
		}


	}
	

}


int main() {
	ifstream i;
	ofstream o;
	int x = 3;
	StudentInfo s[3];
	initializes(s, x);
	 print (s , 3);

	

}

still not not working

[SakurasouBusters]

while (!i.eof())
{
	for (int j = 0; j < 3; j++)
	{	
		i >> s[j].HumanBeing.FirstName >> s[j].HumanBeing.LastName >> s[j].HumanBeing.Age >> s[j].UniversityID >> s[j].GPA >> s[j].Courses;	
	}
}

Should be :

while (i)
{
	i >> s[j].HumanBeing.FirstName >> s[j].HumanBeing.LastName >> s[j].HumanBeing.Age >> s[j].UniversityID >> s[j].GPA >> s[j].Courses;	
	j++;
}

[SakurasouBusters]

i.open("lol.txt");

Should be :

string fileName("lol.txt");
i.open(fileName.c_str());

while(!i.is_open())
{
    cout << "The file " << fileName << " not found. Please enter another file name : ";
    cin >> fileName; i.open(fileName.c_str());
}