C++

Forum

 
Tic-Tac-Toe not recognizing winner

MisterTams (125)
Hey guys, I'm not quite done with my Tic-Tac-Toe code but I was debugging and testing to see if it would recognize a winner. But it doesn't seem to recognize when there is a winner. Where did I go wrong?

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
 
//Practice making a Tic-Tac-Toe game
#include <iostream>
#include <string>
#include <iomanip>
using namespace std;

char symbol, Player1;
const int ROW = 3;
const int COLUMN = 3;
int location;
char Board[ROW][COLUMN] =  {
		{'1','2','3'},
		{'4','5','6'},
		{'7','8','9'}				
						};
//function prototype
void LocationLetterO();
void LocationLetterX();
void PrintBoard();
void CheckWinner();

int main ()
{
	
	cout << "Player 1 please choose (X) or (O)." << endl;
	cin >> symbol;

	if (symbol == 'o' || symbol == 'O')
	{
		cout << "Player 1 chose: O" << endl;
		cout << "Player 2 is now: X" << endl;
		Player1 = 'O';
	}
	else if (symbol == 'x' || symbol == 'X')
	{
		cout << "Player 1 chose: X" << endl;
		cout << "Player 2 is now: O" << endl;
		Player1 = 'X';
	}
	
	cout << endl;
	PrintBoard();

	while (Player1 = 'O')
	{
	cout << "\nPlayer 1 (O) choose a location on the board. (1-9) " << endl;
	cin >> location;
	LocationLetterO();
	CheckWinner();
	PrintBoard();
	
	cout << "\nPlayer 2 (X) choose a location on the board. (1-9) " << endl;
	cin >> location;
	LocationLetterX();
	CheckWinner();
	PrintBoard();
	
	}

system("pause");
return 0;
}

void LocationLetterO()
{
	if (location == 1)
		Board[0][0] = 'O';
	else if (location == 2)
		Board[0][1] = 'O';
	else if (location == 3)
		Board[0][2] = 'O';
	else if (location == 4)
		Board[1][0] = 'O';
	else if (location == 5)
		Board[1][1] = 'O';
	else if (location == 6)
		Board[1][2] = 'O';
	else if (location == 7)
		Board[2][0] = 'O';
	else if (location == 8)
		Board[2][1] = 'O';
	else if (location == 9)
		Board[2][2] = 'O';
}

void LocationLetterX()
{
	if (location == 1)
		Board[0][0] = 'X';
	else if (location == 2)
		Board[0][1] = 'X';
	else if (location == 3)
		Board[0][2] = 'X';
	else if (location == 4)
		Board[1][0] = 'X';
	else if (location == 5)
		Board[1][1] = 'X';
	else if (location == 6)
		Board[1][2] = 'X';
	else if (location == 7)
		Board[2][0] = 'X';
	else if (location == 8)
		Board[2][1] = 'X';
	else if (location == 9)
		Board[2][2] = 'X';
}

void CheckWinner()
{
	if (Board[0][0] == Board[0][1] == Board[0][2])
	{
		if(Board[0][0] == 'O')
		{
			cout << " Winner: O" << endl;
		}
		else
		{
			cout << " Winner: X" << endl;
		}
	}
	else if (Board[0][0] == Board[1][1] == Board[2][2])
	{
		if(Board[0][0] == 'O')
		{
			cout << " Winner: O" << endl;
		}
		else
		{
			cout << " Winner: X" << endl;
		}
	}
	else if (Board[1][0] == Board[1][1] == Board[1][2])
	{
		if(Board[1][0] == 'O')
		{
			cout << " Winner: O" << endl;
		}
		else
		{
			cout << " Winner: X" << endl;
		}
	}
	else if (Board[2][0] == Board[2][1] == Board[2][2])
	{
		if(Board[2][0] == 'O')
		{
			cout << " Winner: O" << endl;
		}
		else
		{
			cout << " Winner: X" << endl;
		}
	}
	else if (Board[0][2] == Board[1][1] == Board[2][0])
	{
		if(Board[0][2] == 'O')
		{
			cout << " Winner: O" << endl;
		}
		else
		{
			cout << " Winner: X" << endl;
		}
	}
	else if (Board[0][0] == Board[1][0] == Board[2][0])
	{
		if(Board[0][0] == 'O')
		{
			cout << " Winner: O" << endl;
		}
		else
		{
			cout << " Winner: X" << endl;
		}
	}
	else if (Board[0][1] == Board[1][1] == Board[2][1])
	{
		if(Board[0][1] == 'O')
		{
			cout << " Winner: O" << endl;
		}
		else
		{
			cout << " Winner: X" << endl;
		}
	}
	else if (Board[0][2] == Board[1][2] == Board[2][2])
	{
		if(Board[0][2] == 'O')
		{
			cout << " Winner: O" << endl;
		}
		else
		{
			cout << " Winner: X" << endl;
		}
	}
}

void PrintBoard()
{
	cout << endl;
	for (int x = 0; x < 3; x++)
	{
		for (int y = 0; y < 3; y++)
	{
		cout << "|" << Board[x][y] << "|";
	}
		cout << endl;
	}
}
Peter87 (11178)
The == operator takes two arguments and returns a bool.

Board[0][0] == Board[0][1] == Board[0][2] is treated as (Board[0][0] == Board[0][1]) == Board[0][2].


Board[0][0] == Board[0][1] will evaluate to true or false, neither of which is equal to 'X' or 'O'.

What you need to do is to do two separate comparisons with == and combine them with && (logical AND).

 
 
Board[0][0] == Board[0][1] && Board[0][1] == Board[0][2]
MisterTams (125)
Peter87,

Thank you. That really worked and helped me out. I have updated the code below. My question is this. How can I end the loop after a winner has been determined? If Player 1 wins, the code will say that Player 1 (whatever the symbol chosen) won, the loop keeps on going to ask Player 2 for their next input. How can I stop this?

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
 
//Practice making a Tic-Tac-Toe game
#include <iostream>
#include <string>
#include <iomanip>
using namespace std;

char symbol, Player1;
const int ROW = 3;
const int COLUMN = 3;
int location;
string gameover;
char Board[ROW][COLUMN] =  {
		{'1','2','3'},
		{'4','5','6'},
		{'7','8','9'}				
						};
//function prototype
void LocationLetterO();
void LocationLetterX();
void PrintBoard();
void CheckWinner();
void FunctionO();
void FunctionX();

int main ()
{
	
	cout << "Player 1 please choose (X) or (O)." << endl;
	cin >> symbol;

	if (symbol == 'o' || symbol == 'O')
	{
		cout << "Player 1 chose: O" << endl;
		cout << "Player 2 is now: X\n" << endl;
		Player1 = 'O';
		PrintBoard();
		FunctionO();
	}
	else if (symbol == 'x' || symbol == 'X')
	{
		cout << "Player 1 chose: X" << endl;
		cout << "Player 2 is now: O\n" << endl;
		Player1 = 'X';
		PrintBoard();
		FunctionX();
	}

system("pause");
return 0;
}

void LocationLetterO()
{
	if (location == 1)
		Board[0][0] = 'O';
	else if (location == 2)
		Board[0][1] = 'O';
	else if (location == 3)
		Board[0][2] = 'O';
	else if (location == 4)
		Board[1][0] = 'O';
	else if (location == 5)
		Board[1][1] = 'O';
	else if (location == 6)
		Board[1][2] = 'O';
	else if (location == 7)
		Board[2][0] = 'O';
	else if (location == 8)
		Board[2][1] = 'O';
	else if (location == 9)
		Board[2][2] = 'O';
}

void LocationLetterX()
{
	if (location == 1)
		Board[0][0] = 'X';
	else if (location == 2)
		Board[0][1] = 'X';
	else if (location == 3)
		Board[0][2] = 'X';
	else if (location == 4)
		Board[1][0] = 'X';
	else if (location == 5)
		Board[1][1] = 'X';
	else if (location == 6)
		Board[1][2] = 'X';
	else if (location == 7)
		Board[2][0] = 'X';
	else if (location == 8)
		Board[2][1] = 'X';
	else if (location == 9)
		Board[2][2] = 'X';
}

void CheckWinner()
{
	if (Board[0][0] == Board[0][1] && Board[0][1] == Board[0][2])
	{
		if(Board[0][0] == 'O')
		{
			cout << "\nWinner: O" << endl;
		}
		else
		{
			cout << "\nWinner: X" << endl;
		}
	}
	else if (Board[0][0] == Board[1][1] && Board[1][1] == Board[2][2])
	{
		if(Board[0][0] == 'O')
		{
			cout << "\nWinner: O" << endl;
		}
		else
		{
			cout << "\nWinner: X" << endl;
		}
	}
	else if (Board[1][0] == Board[1][1] && Board[1][1] == Board[1][2])
	{
		if(Board[1][0] == 'O')
		{
			cout << "\nWinner: O" << endl;
		}
		else
		{
			cout << "\nWinner: X" << endl;
		}
	}
	else if (Board[2][0] == Board[2][1] && Board[2][1] == Board[2][2])
	{
		if(Board[2][0] == 'O')
		{
			cout << "\nWinner: O" << endl;
		}
		else
		{
			cout << "\nWinner: X" << endl;
		}
	}
	else if (Board[0][2] == Board[1][1] && Board[1][1] == Board[2][0])
	{
		if(Board[0][2] == 'O')
		{
			cout << "\nWinner: O" << endl;
		}
		else
		{
			cout << "\nWinner: X" << endl;
		}
	}
	else if (Board[0][0] == Board[1][0] && Board[1][0] == Board[2][0])
	{
		if(Board[0][0] == 'O')
		{
			cout << "\nWinner: O" << endl;
		}
		else
		{
			cout << "\nWinner: X" << endl;
		}
	}
	else if (Board[0][1] == Board[1][1] && Board[1][1] == Board[2][1])
	{
		if(Board[0][1] == 'O')
		{
			cout << "\nWinner: O" << endl;
		}
		else
		{
			cout << "\nWinner: X" << endl;
		}
	}
	else if (Board[0][2] == Board[1][2] && Board[1][2] == Board[2][2])
	{
		if(Board[0][2] == 'O')
		{
			cout << "\nWinner: O" << endl;
		}
		else
		{
			cout << "\nWinner: X" << endl;
		}
	}
}

void PrintBoard()
{
	cout << endl;
	for (int x = 0; x < 3; x++)
	{
		for (int y = 0; y < 3; y++)
	{
		cout << "|" << Board[x][y] << "|";
	}
		cout << endl;
	}
}

void FunctionO()
{
	while (Player1 = 'O')
	{
	cout << "\nPlayer 1 (O) choose a location on the board. (1-9) " << endl;
	cin >> location;
	LocationLetterO();
	PrintBoard();
	CheckWinner();
	
	cout << "\nPlayer 2 (X) choose a location on the board. (1-9) " << endl;
	cin >> location;
	LocationLetterX();
	PrintBoard();
	CheckWinner();
	}
}

void FunctionX()
{
	while (Player1 = 'X')
	{
	cout << "\nPlayer 1 (X) choose a location on the board. (1-9) " << endl;
	cin >> location;
	LocationLetterX();
	PrintBoard();
	CheckWinner();
	
	cout << "\nPlayer 2 (O) choose a location on the board. (1-9) " << endl;
	cin >> location;
	LocationLetterO();
	PrintBoard();
	CheckWinner();
	}
}
Enot02 (50)
You should use break to stop the loop.
closed account (48T7M4Gy)
http://www.cplusplus.com/forum/beginner/205365/
Topic archived. No new replies allowed.